From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 35129559C for <dev@dpdk.org>; Wed, 5 Aug 2015 15:17:02 +0200 (CEST) Received: by wicgj17 with SMTP id gj17so192160625wic.1 for <dev@dpdk.org>; Wed, 05 Aug 2015 06:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=V7VVfPf3xJNWxiPGjHj1jIHigtKYDCF/2MD3RlyP0vw=; b=YEi/DcA1S2wTPLmZuZnt0xfD792Ac3JeTswChc3uC8CiV4i8PVfKYTOOy1ekDpMZ+y 5RS2HhM1FnDYG2FkTP9jeJRcDwxi6w/k6ioZlyJ6w8KzmJrMa54zlkwC6v5TFLh/0uRV zESij5qNvWOdTTn8SPMJovvnrZFq+SYjVRXYwESqkk8dNkWuQ2Gvvkj6QO/5K5LaE1Rn 61KbDSILFUT7Zkv0HZu/O5sF1eQg3ftFhsUeT4eOlZKFLdcK994prUwkihYaITodr/2q Z8Wl67Fb+QNroK+PRCumiCEcVLjQ0OGqrwpF/5ItbTvmTJVvCaXibe93R0pL4XeMPPVg WpDg== X-Gm-Message-State: ALoCoQn3XtQ+Jd/RIy0bCFC42hL79OXz4Kawghpw/05ZKKjSIbyZ8U5mna2iQ56mPBk9nBwEkkMx X-Received: by 10.194.57.166 with SMTP id j6mr19210117wjq.29.1438780622002; Wed, 05 Aug 2015 06:17:02 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id go5sm7616950wib.5.2015.08.05.06.17.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2015 06:17:01 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Bernard Iremonger <bernard.iremonger@intel.com> Date: Wed, 05 Aug 2015 15:15:46 +0200 Message-ID: <1514392.p4W8R5bZo1@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> References: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 05 Aug 2015 13:17:02 -0000 2015-08-05 13:36, Bernard Iremonger: > if the name parameter to rte_eth_bond_create() was NULL, > there was a segmentation fault because eth_dev was also NULL. You also add error handling of mac_addrs alloc and release_port(). It deserves to be said in this commit message.