From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Liang, Cunming" <cunming.liang@intel.com>
Cc: dev@dpdk.org, John Linville <linville@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork
Date: Wed, 25 Feb 2015 09:45:46 +0100 [thread overview]
Message-ID: <1514821.oaVEE2NRMm@xps13> (raw)
In-Reply-To: <D0158A423229094DA7ABF71CF2FA0DA3118DE679@shsmsx102.ccr.corp.intel.com>
2015-02-25 00:57, Liang, Cunming:
> From: John W. Linville [mailto:linville@tuxdriver.com]
> > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote:
> > > 2015-02-12 17:08, Cunming Liang:
> > > > --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> > > > +++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> > > > @@ -439,13 +439,15 @@ rte_pmd_init_internals(const char *name,
> > > > size_t ifnamelen;
> > > > unsigned k_idx;
> > > > struct sockaddr_ll sockaddr;
> > > > - struct tpacket_req *req;
> > > > + struct tpacket_req *req = NULL;
> > >
> > > If *internals is set to NULL, there should be no case where req used
> > > and undefined.
>
> [LCM] Agree, so that's why I add '*internals = NULL' below as well.
> >
> > I agree -- it looks to me like req is protected by checking for
> > *internals == NULL. I don't think this patch is necessary.
>
> [LCM] The major piece of the patch is add setting for '*internals=NULL;'.
Yes understood, but it is already initialized to NULL before calling
rte_pmd_init_internals():
http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_af_packet/rte_eth_af_packet.c#n706
next prev parent reply other threads:[~2015-02-25 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 9:08 Cunming Liang
2015-02-20 10:19 ` Thomas Monjalon
2015-02-20 18:38 ` John W. Linville
2015-02-25 0:57 ` Liang, Cunming
2015-02-25 8:45 ` Thomas Monjalon [this message]
2015-02-25 9:52 ` Liang, Cunming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514821.oaVEE2NRMm@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=linville@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).