From: Qi Zhang <qi.z.zhang@intel.com>
To: beilei.xing@intel.com
Cc: dev@dpdk.org, jingjing.wu@intel.com,
Qi Zhang <qi.z.zhang@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH 23/25] net/i40e/base: fix unaligned data issue
Date: Sun, 7 Jan 2018 22:43:33 -0500 [thread overview]
Message-ID: <1515383015-28042-24-git-send-email-qi.z.zhang@intel.com> (raw)
In-Reply-To: <1515383015-28042-1-git-send-email-qi.z.zhang@intel.com>
This fix prevents errors or warnings while accessing unaligned 32-bit
data words on non-x86 platforms during getting link info from firmware.
Fixes: e8228f1a16b7 ("net/i40e/base: report supported link modes")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/base/i40e_common.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
index a0a1f84b6..f3e34965f 100644
--- a/drivers/net/i40e/base/i40e_common.c
+++ b/drivers/net/i40e/base/i40e_common.c
@@ -2025,7 +2025,11 @@ enum i40e_status_code i40e_aq_get_link_info(struct i40e_hw *hw,
if (hw->aq.api_maj_ver == I40E_FW_API_VERSION_MAJOR &&
hw->aq.api_min_ver >= 7) {
- hw->phy.phy_types = LE32_TO_CPU(*(__le32 *)resp->link_type);
+ __le32 tmp;
+
+ i40e_memcpy(&tmp, resp->link_type, sizeof(tmp),
+ I40E_NONDMA_TO_NONDMA);
+ hw->phy.phy_types = LE32_TO_CPU(tmp);
hw->phy.phy_types |= ((u64)resp->link_type_ext << 32);
}
--
2.14.1
next prev parent reply other threads:[~2018-01-08 10:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 3:43 [dpdk-dev] [PATCH 00/25] net/i40e: update base code Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 01/25] net/i40e/base: add new PHY type Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 02/25] net/i40e/base: add capability macros Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 03/25] net/i40e/base: add (Q)SFP module memory access definitions Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 04/25] net/i40e/base: release spinlock before function returns Qi Zhang
2018-01-09 6:32 ` Xing, Beilei
2018-01-08 3:43 ` [dpdk-dev] [PATCH 05/25] net/i40e/base: retry AQC to overcome IRCRead hangs Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 06/25] net/i40e/base: add byte swaps in PHY register access Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 07/25] net/i40e/base: add macro for 25G device Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 08/25] net/i40e/base: code refactoring for LED blink Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 09/25] net/i40e/base: add link speed convert function Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 10/25] net/i40e/base: add AQ command for DCB parameters Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 11/25] net/i40e/base: fix NVM lock Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 12/25] net/i40e/base: code clean Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 13/25] net/i40e/base: add NVM update preservation flags Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 14/25] net/i40e/base: enable AQ event get in NVM update Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 15/25] net/i40e/base: fix link LED blink Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 16/25] net/i40e/base: add defines for flat NVM Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 17/25] net/i40e/base: enhanced loopback AQ command Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 18/25] net/i40e/base: add rearrange process " Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 19/25] net/i40e/base: add AQ critical error type Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 20/25] net/i40e/base: fix compile issue for GCC 6.3 Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 21/25] net/i40e/base: code clean Qi Zhang
2018-01-09 6:21 ` Xing, Beilei
2018-01-08 3:43 ` [dpdk-dev] [PATCH 22/25] net/i40e/base: fix reading LLDP configuration Qi Zhang
2018-01-08 3:43 ` Qi Zhang [this message]
2018-01-08 3:43 ` [dpdk-dev] [PATCH 24/25] net/i40e: rename a field Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 25/25] net/i40e/base: update README file Qi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515383015-28042-24-git-send-email-qi.z.zhang@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).