From: Qi Zhang <qi.z.zhang@intel.com>
To: beilei.xing@intel.com
Cc: dev@dpdk.org, jingjing.wu@intel.com, Qi Zhang <qi.z.zhang@intel.com>
Subject: [dpdk-dev] [PATCH 06/25] net/i40e/base: add byte swaps in PHY register access
Date: Sun, 7 Jan 2018 22:43:16 -0500 [thread overview]
Message-ID: <1515383015-28042-7-git-send-email-qi.z.zhang@intel.com> (raw)
In-Reply-To: <1515383015-28042-1-git-send-email-qi.z.zhang@intel.com>
Add byte swap commandwhen transferring data between memory and firmware
while using PHY register access functions. Endianness also need to be
handled correctly during these swaps.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++--
drivers/net/i40e/base/i40e_common.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h
index 30e31edbe..fcfb90253 100644
--- a/drivers/net/i40e/base/i40e_adminq_cmd.h
+++ b/drivers/net/i40e/base/i40e_adminq_cmd.h
@@ -2183,8 +2183,8 @@ struct i40e_aqc_phy_register_access {
#define I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE 2
u8 dev_addres;
u8 reserved1[2];
- u32 reg_address;
- u32 reg_value;
+ __le32 reg_address;
+ __le32 reg_value;
u8 reserved2[4];
};
diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
index 1dc5c62cb..7e7fa228c 100644
--- a/drivers/net/i40e/base/i40e_common.c
+++ b/drivers/net/i40e/base/i40e_common.c
@@ -7018,8 +7018,8 @@ enum i40e_status_code i40e_aq_set_phy_register(struct i40e_hw *hw,
cmd->phy_interface = phy_select;
cmd->dev_addres = dev_addr;
- cmd->reg_address = reg_addr;
- cmd->reg_value = reg_val;
+ cmd->reg_address = CPU_TO_LE32(reg_addr);
+ cmd->reg_value = CPU_TO_LE32(reg_val);
status = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);
@@ -7052,11 +7052,11 @@ enum i40e_status_code i40e_aq_get_phy_register(struct i40e_hw *hw,
cmd->phy_interface = phy_select;
cmd->dev_addres = dev_addr;
- cmd->reg_address = reg_addr;
+ cmd->reg_address = CPU_TO_LE32(reg_addr);
status = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);
if (!status)
- *reg_val = cmd->reg_value;
+ *reg_val = LE32_TO_CPU(cmd->reg_value);
return status;
}
--
2.14.1
next prev parent reply other threads:[~2018-01-08 10:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 3:43 [dpdk-dev] [PATCH 00/25] net/i40e: update base code Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 01/25] net/i40e/base: add new PHY type Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 02/25] net/i40e/base: add capability macros Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 03/25] net/i40e/base: add (Q)SFP module memory access definitions Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 04/25] net/i40e/base: release spinlock before function returns Qi Zhang
2018-01-09 6:32 ` Xing, Beilei
2018-01-08 3:43 ` [dpdk-dev] [PATCH 05/25] net/i40e/base: retry AQC to overcome IRCRead hangs Qi Zhang
2018-01-08 3:43 ` Qi Zhang [this message]
2018-01-08 3:43 ` [dpdk-dev] [PATCH 07/25] net/i40e/base: add macro for 25G device Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 08/25] net/i40e/base: code refactoring for LED blink Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 09/25] net/i40e/base: add link speed convert function Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 10/25] net/i40e/base: add AQ command for DCB parameters Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 11/25] net/i40e/base: fix NVM lock Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 12/25] net/i40e/base: code clean Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 13/25] net/i40e/base: add NVM update preservation flags Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 14/25] net/i40e/base: enable AQ event get in NVM update Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 15/25] net/i40e/base: fix link LED blink Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 16/25] net/i40e/base: add defines for flat NVM Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 17/25] net/i40e/base: enhanced loopback AQ command Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 18/25] net/i40e/base: add rearrange process " Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 19/25] net/i40e/base: add AQ critical error type Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 20/25] net/i40e/base: fix compile issue for GCC 6.3 Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 21/25] net/i40e/base: code clean Qi Zhang
2018-01-09 6:21 ` Xing, Beilei
2018-01-08 3:43 ` [dpdk-dev] [PATCH 22/25] net/i40e/base: fix reading LLDP configuration Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 23/25] net/i40e/base: fix unaligned data issue Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 24/25] net/i40e: rename a field Qi Zhang
2018-01-08 3:43 ` [dpdk-dev] [PATCH 25/25] net/i40e/base: update README file Qi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515383015-28042-7-git-send-email-qi.z.zhang@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).