DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h?
@ 2016-04-07 18:10 Sean Hope (shope)
  2016-04-07 19:16 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Hope (shope) @ 2016-04-07 18:10 UTC (permalink / raw)
  To: dev

Hello,

I see that rte_pci_dev_ids.h has been removed.

We are using it on our product to get supported device ids.

I understand the desire to move that data out of a central place and into
each driver. Any chance that instead of living in a .c file, that each
driver could hold it in a .h file so that it could be easily consumed by
an external program?

Thanks,
Sean


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h?
  2016-04-07 18:10 [dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h? Sean Hope (shope)
@ 2016-04-07 19:16 ` Thomas Monjalon
  2016-04-08  3:27   ` Sean Hope (shope)
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2016-04-07 19:16 UTC (permalink / raw)
  To: Sean Hope (shope); +Cc: dev

2016-04-07 18:10, Sean Hope:
> Hello,
> 
> I see that rte_pci_dev_ids.h has been removed.

No it has not been removed (yet):
	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/rte_pci_dev_ids.h

> We are using it on our product to get supported device ids.
> 
> I understand the desire to move that data out of a central place and into
> each driver. Any chance that instead of living in a .c file, that each
> driver could hold it in a .h file so that it could be easily consumed by
> an external program?

Yes there is a plan to move the PCI ids in the drivers but
we need to make a tool to retrieve the ids from the ELF files.
Why do you want to get them from a .h file?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h?
  2016-04-07 19:16 ` Thomas Monjalon
@ 2016-04-08  3:27   ` Sean Hope (shope)
  0 siblings, 0 replies; 3+ messages in thread
From: Sean Hope (shope) @ 2016-04-08  3:27 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev


>2016-04-07 18:10, Sean Hope:
>> Hello,
>> 
>> I see that rte_pci_dev_ids.h has been removed.
>
>No it has not been removed (yet):
>	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/rte_pci_de
>v_ids.h
>
>> We are using it on our product to get supported device ids.
>> 
>> I understand the desire to move that data out of a central place and
>>into
>> each driver. Any chance that instead of living in a .c file, that each
>> driver could hold it in a .h file so that it could be easily consumed by
>> an external program?
>
>Yes there is a plan to move the PCI ids in the drivers but
>we need to make a tool to retrieve the ids from the ELF files.
>Why do you want to get them from a .h file?

The need for a .h file isn't an absolute, but we have some code that was
using the existing file. If each driver had their Ids in a per-driver .h
file then we just include one h file per driver instead of
rte_pci_dev_ids.h and our tool still works.

Thanks,
Sean


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-08  3:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 18:10 [dpdk-dev] ethdev: replacement for rte_pci_dev_ids.h? Sean Hope (shope)
2016-04-07 19:16 ` Thomas Monjalon
2016-04-08  3:27   ` Sean Hope (shope)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).