From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0069.outbound.protection.outlook.com [104.47.1.69]) by dpdk.org (Postfix) with ESMTP id AAD081B246 for ; Wed, 10 Jan 2018 16:19:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qenBNUOyFEiwn1WKP9tcLjBhnm/Z1vCpOzPIbyvJV9Y=; b=cjIRrjCfz7N1APZuIWsNfx6ep+Yyg0PZ6KO7Dten/HnPEl13j8PIYwMxBMGxOWkzFtU+MzUbBaO2HBVMkZXw4D95ztJKhZhx+xc6u6NoMxJSE+ne7TC187kE/tx9mAbksirujfrDxwyd6kXgFo2KPZyW1Sd8O4Gw4DRxyazA460= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR05MB3207.eurprd05.prod.outlook.com (2603:10a6:6:1a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 15:19:17 +0000 From: Moti Haimovsky To: adrien.mazarguil@6wind.com, shahafs@mellanox.com Cc: dev@dpdk.org, Moti Haimovsky Date: Wed, 10 Jan 2018 17:19:01 +0200 Message-Id: <1515597541-37459-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1515082323-179525-1-git-send-email-motih@mellanox.com> References: <1515082323-179525-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: AM5PR0701CA0002.eurprd07.prod.outlook.com (2603:10a6:203:51::12) To DB6PR05MB3207.eurprd05.prod.outlook.com (2603:10a6:6:1a::33) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cbc9660-6e1e-4d8a-64a9-08d5583d842b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020052)(4652020)(5600026)(4604075)(4534082)(4602075)(4627178)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3207; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3207; 3:Ai4Fy/usODDMj3wOerDfnGbFSkxvhTnwjPifLAPiOwK+3wSLcyOQJQyrSIZ2LSiiG5A/mLHaSyqZAedZM3VmVz9nZWyzZyf8+LSiE6/ErJKKDMYJrM1TKJ0EP9sgNsadC3M47kFTTvE0+LMO6//2Yc6u7eZAiwRU9oTILhdFBp/FxlqL79dHsPDxE3xT4QGr8xl0MP42vXbFw8pHNtSHnHsnvJC4GlR8y3DkP1J0CpYtz0Vu1dv/jvmkAABEDKn/; 25:zQi4fjfPhvjevDx6rq5PD2XgWWnL1DzYN+hGa2iuGGNoRees5hSt+UpFrLQ3+uLqzsbhYGEbwPDAGtBvlu/AwkGCxtMY6qVh/hvCYDvk5WnLWhZFKFZGsK59cF+eYA79XdAdZXVr8iJvCsdMzuRzs3CrODCzUSuX/CmDNv9QOSUkYjPxherYEjyzRUFYC9X6UpwNXONcsixhmxMeMSZCKMDKaYc39C1BUxQQNhrGKdx/AZPQOSiMGZZVhVtKleyxgWRhHFeOlw5LVKQh2Yp/fum4+ksRg70nAPzssO+HBi81zK8zrGuG/5bSZ8ZoHi5ZyTHSNkVaocce1yK7FIGb+A==; 31:7zOixOSF/eaIJ3fO4ub3/XylLPIgvDTcmK626ZL9Q3VkgFM6JqM1sqqqh/ca2bTNfFtCE+g1thQqw0RJsyUJXl1+CqcU7Wr0O2hlx2nAGiuQtB22n2fDPgCNwfxiYBhxJg+DjzcDWtcOY40Joc3bYwv10Jek+SmkxoKrCGkLD+KlQkjzfvIGjcXXXa8DXJmIvbBKF/v8aSka1SsqPGK4xsrYYSNhmRdQn/JbprByUEo= X-MS-TrafficTypeDiagnostic: DB6PR05MB3207: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3207; 20:2UyY88biyqhmJLZAr3a4+l//b3QEti4moe6hSjsRem4msW5sNH7cxzLJcFe2vD1pGWPI8MnEkm+Xp3VQjM2vZAl5KunEUk58nA1ZQqN4MhZOTouP+Tsi+UuWP8xJ8OfC+hK48SgSlhkGfSa4BpwFcDtI/KYnYCwLbQYrjA96Oe6bni/43vObvQNPXNotCxPzp5gJ0qHTKMQB5PHoNuGoN9DW+7dGNpYkpQ0vhTOwXXpqJ4E0d/6gDP+Avlfkfo35ZwS/SFTJ+kIcoAHWHVHTehUlgGgFPbzs8OPBU05KzpjjYdQ7HpPX6hxQ/JQ3pcJbJk5ioFpJ31SEw3q7ZiUuhvjyPKP8C+mne2zn/faVQEH58N2Jh5S1ZDpKrSw8VvkDwZLLzN7GgFxCIsemfhpYUxcwJx3ReotcZu/psEqflo3EnKh3stS4NirWUKbxb3CC0xGHOhsFfBli3NkTb+9nWmTOsXZV2xM9lsfZOv6aJeZIemjkY9cJBeHUnr8zxfzn; 4:hyBxmvsy6ql9GKGscz5FxWOXyo4Qs9dGiWZZaE1d9s1hAh6bLtaS8TNV9VhX83bo93Jji99+WtPKWeIt8/XZtMfIDCB7FijMG5U1Rkbbs9sGWAlllcVHW+/z756xmj2POfbxWNiD6GkeT0mCQ4HnlrpOg43MwuWaeU35MaQmvRXO6hLRuvwkElcX3pBKL2I1RdU0Ngz9fkIk1si/Z1BAJSOtyfYAHwZUUHyeRnhHeXWkmiyTMmNgF4K0mXJ9ikoyEcjZ0GjB71RAZ+N3YMXKTw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231023)(944501119)(6055026)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR05MB3207; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB6PR05MB3207; X-Forefront-PRVS: 0548586081 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(366004)(39860400002)(396003)(346002)(376002)(39380400002)(189003)(199004)(6666003)(6636002)(97736004)(4326008)(47776003)(478600001)(36756003)(16586007)(6116002)(3846002)(55016002)(66066001)(2950100002)(305945005)(53936002)(25786009)(86362001)(16526018)(7736002)(69596002)(4720700003)(316002)(68736007)(8936002)(50226002)(5660300001)(81156014)(81166006)(8676002)(107886003)(33026002)(21086003)(15650500001)(50466002)(48376002)(2906002)(51416003)(52116002)(7696005)(106356001)(386003)(59450400001)(105586002)(76176011)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3207; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3207; 23:k52glitEgvSAwzrXmZrdrfxBjN81fsA2MMfsGX6Rp?= =?us-ascii?Q?UbnepxMYsimRZC7+bC4eJiGvJw64meKj+5tpTkR/f5pJ6hJZiBNJObBk+wOk?= =?us-ascii?Q?B/R8DYePf+Y+SRtbLIl9J56ypsxg2wDzygMlr9T2QCCqVJ6dnHOIVbMBqKd1?= =?us-ascii?Q?O7VqFb8+k4xdMctLYhRh/BBr2wTuJZmPOZNpbYmJhiy976pzr1y5z33RUAET?= =?us-ascii?Q?d8D+3pVtmOG3lovtZFx9hrXN34ggZZHKWO/Uzt1G2GU7wR744pxfsEbbJ9t3?= =?us-ascii?Q?LmedvOxQJkNNB7cttnaWriszHUo2oqT2tDag1oN1AyF736micdW2/b+bE2Ao?= =?us-ascii?Q?9tIYy/cECWQbjo01r3qKATOZHTdrF3cpMY1M74heZfpdU9smQ4o8NV95Lsay?= =?us-ascii?Q?tsUV0+Mdp8uwfRHeWfL1uTT7VPSlAol1UIZ20pHnAsqhWy9FApsmaZ99MymF?= =?us-ascii?Q?P/PQqRMLggb3mta3e5uoCQBVLupj5WNN0btmTO3j0pMfpfuOP6JgVlBNAK4y?= =?us-ascii?Q?/vyl6Rozq6+hjDWRvjK1SJRO0XYsGpvgJe6XH4CD2qO2naAM9fFmurgbR2nG?= =?us-ascii?Q?+OkbDlFhKuLWY/gff4ZSkc+8qKLl3m7KK/gExyHlhcbyveGgJOwIL04jIxCy?= =?us-ascii?Q?wVUGDsPPyZ9pGlKLW7Xe9UEtQ5k6/bISxER+4jrpB6aM7IDvrY/d3glL1pbw?= =?us-ascii?Q?R+v1hI8HputEQ0k8ddOgt95eahWQnqp1AYPPVr7Z7cWidvyDFz/DLXlzRVuy?= =?us-ascii?Q?f6lyTFE/nKPSN4uMxxP42UTwE3vbTsZYylDk8OJEWio4Vhavu3+CIE4qzVKU?= =?us-ascii?Q?KDhrI5PA+nrHEu/6aVCxqlIOQjD1+Xml5vuYGNLvFSs7FZncQI0iP91yIGTU?= =?us-ascii?Q?O6BCn5hgS+UV0g/CMRWj7hnWv62NzgnPa5tOI05IlY8fGyUMzcu/vYi6UkyT?= =?us-ascii?Q?PYWRhTmb969JOnQ5fTH8NKD9JP8mT6/0BvxRzdoYGNzBhDhyJcEM+WJ8LXCD?= =?us-ascii?Q?2vm7CdS+B1R9pUwJhom01VCHbQXZrvCiPLkHt1gxDBqJbMuPiMN3QDRRlGTo?= =?us-ascii?Q?vkRLcczofWEv38IiOe5VrigpwvVL2rghPqxefjDrNlFqC/bmPwP98gBIz5v9?= =?us-ascii?Q?1W0H2oSGd6+yUBXSNvlhrmMoIuueCmRndLcuISZG7QKwqJAgPA7YrYbXoe/r?= =?us-ascii?Q?Hq+DizuiBEvi2VWRFUQU9Jn37SygWSypuV5ZQGvbweKV5wR8nQLO4E81EClb?= =?us-ascii?Q?Eza/p4kvPg4tIPccf2H5hfEig0w9cCUvRmEiLq/n0qoZMz7H4qDEl+kKySe+?= =?us-ascii?Q?6D3+H7VbOh/zRL0x19z+9M=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3207; 6:PCgYBuHdZtdCIS02EH8rXuF6PKI4QFmFMchVJeeC3dwhf4DTIQ2hOCtY3oVMwnDZVRjSeKfqM6ODrIV4jSRdHM3VHzKCn57avKZHwtgIIut6iS5bGpxwh7MKimaICaIxE1QJCxh0iXh/9us64zPGWwZUPnEy2giwCD9SWHaLIe7GQ4pnd0xd9erbpmikcaBcwAX0vhS3JZ2SOcMRtQAzHhM3ckUB0/fYwrb9kNOq827DOWAEeHtBE6if+Gzu8805jn7PE8uQBuzdYgQ345SIAxUwQIMXTxUeajigdYDvGE5p9sm0mYTWqdLcoBPRN+1qRQYmkBGAyOdXYSERg47preFgxIs1WeahLZo1zd+jaUo=; 5:/tv6C1JuCFIduAZ7n65KpolZkD9ZoU+TIRJpK/NT5yea5zauKUi0zkQKJDI/SUd89exiS+R9eqr/6VnRdmB2uemkwHpzbPDo7tDYzMVkY14FZ8bTV4vspb+ZTG9eK31adG35XSa4kccJHjQvzP3N8eN3emPFkHXFsVWIweYtPP8=; 24:dO+16YZ4s/0Efdhcwk/51bcMKAd8EIsr5M4Uxfp3cQgk/3iBlXfaKPEolvCQTiOJ8AnVCAD6+AjXp61of0/HLowGhU0VmwAlVQL5xPySIwc=; 7:JTf2vngQEkjPxYnFPsDTHdO4mVEeHsoTnPddmcRPBtVVqqUgESBno65MGkx5u4Zj4whvrZaVDQeK1ls3+uqdjzj7ii1owHuKE3C9MPLrQ0myKBLzZ23XdYj5zRSJgDFvQdOzO2dOAwl8VIow7oFYk/zrQUDmnN18vSUQDF/4/4mng1+7pg/+ce+XtJBxFAumFjgX+oOupHEMIg9lbHcl5ueGNIFWaixkk52t0EBqSjQZfZv9DGBORZNEd4da7AfV SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 15:19:17.0697 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cbc9660-6e1e-4d8a-64a9-08d5583d842b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3207 Subject: [dpdk-dev] [PATCH V2] net/mlx4: verify Tx max sges X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 15:19:19 -0000 Max number of Tx scatter-gather entries is a property of the device and is queried at init. This value was not changed in a while and most probably will not be changed in the future, Therefore and in order to enhance Tx performance, the Tx max-sge value is hardcoded in mlx4 PRM code. This patch adds a verification that the above assumption still holds and that the hardcoded value is still supported by the mlx4 hardware. Signed-off-by: Moti Haimovsky --- V2: * Modifications according to inputs from Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 1 + drivers/net/mlx4/mlx4_prm.h | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 4bc4a6f..61c5bf4 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -505,6 +505,7 @@ struct mlx4_conf { rte_errno = ENODEV; goto error; } + assert(device_attr.max_sge >= MLX4_MAX_SGE); for (i = 0; i < device_attr.phys_port_cnt; i++) { uint32_t port = i + 1; /* ports are indexed from one */ struct ibv_context *ctx = NULL; diff --git a/drivers/net/mlx4/mlx4_prm.h b/drivers/net/mlx4/mlx4_prm.h index 217ea50..3803cbd 100644 --- a/drivers/net/mlx4/mlx4_prm.h +++ b/drivers/net/mlx4/mlx4_prm.h @@ -53,7 +53,10 @@ #define MLX4_TXBB_SIZE (1 << MLX4_TXBB_SHIFT) /* Typical TSO descriptor with 16 gather entries is 352 bytes. */ -#define MLX4_MAX_WQE_SIZE 512 +#define MLX4_MAX_SGE 32 +#define MLX4_MAX_WQE_SIZE \ + (MLX4_MAX_SGE * sizeof(struct mlx4_wqe_data_seg) + \ + sizeof(struct mlx4_wqe_ctrl_seg)) #define MLX4_SEG_SHIFT 4 /* Send queue stamping/invalidating information. */ -- 1.8.3.1