* [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets
@ 2018-01-10 17:08 garwilkie
2018-01-18 12:02 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: garwilkie @ 2018-01-10 17:08 UTC (permalink / raw)
To: skhare; +Cc: dev, George Wilkie
From: George Wilkie <george.wilkie@intl.att.com>
With bonding, after sending sufficient ipv4 packets,
bond_ethdev_rx_burst_8023ad() no longer recognizes LACP packets
because the packet_type is set to RTE_PTYPE_L3_IPV4.
Ensure packet_type is reset for non-ipv4 packets in vmxnet3_rx_offload.
Signed-off-by: George Wilkie <george.wilkie@intl.att.com>
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index f9416f3..abea641 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -674,6 +674,8 @@ vmxnet3_rx_offload(const Vmxnet3_RxCompDesc *rcd, struct rte_mbuf *rxm)
if ((rcd->tcp || rcd->udp) && !rcd->tuc)
rxm->ol_flags |= PKT_RX_L4_CKSUM_BAD;
}
+ } else {
+ rxm->packet_type = RTE_PTYPE_UNKNOWN;
}
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets
2018-01-10 17:08 [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets garwilkie
@ 2018-01-18 12:02 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-18 12:02 UTC (permalink / raw)
To: garwilkie, skhare; +Cc: dev, George Wilkie
On 1/10/2018 5:08 PM, garwilkie@gmail.com wrote:
> From: George Wilkie <george.wilkie@intl.att.com>
>
> With bonding, after sending sufficient ipv4 packets,
> bond_ethdev_rx_burst_8023ad() no longer recognizes LACP packets
> because the packet_type is set to RTE_PTYPE_L3_IPV4.
> Ensure packet_type is reset for non-ipv4 packets in vmxnet3_rx_offload.
>
> Signed-off-by: George Wilkie <george.wilkie@intl.att.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets
[not found] <1515585942-10720-1-git-send-email-george.wilkie@intl.att.com>
@ 2018-01-18 6:04 ` Shrikrishna Khare
0 siblings, 0 replies; 3+ messages in thread
From: Shrikrishna Khare @ 2018-01-18 6:04 UTC (permalink / raw)
To: garwilkie; +Cc: skhare, dev, George Wilkie
On Wed, 10 Jan 2018, garwilkie@gmail.com wrote:
> From: George Wilkie <george.wilkie@intl.att.com>
>
> With bonding, after sending sufficient ipv4 packets,
> bond_ethdev_rx_burst_8023ad() no longer recognizes LACP packets
> because the packet_type is set to RTE_PTYPE_L3_IPV4.
> Ensure packet_type is reset for non-ipv4 packets in vmxnet3_rx_offload.
>
> Signed-off-by: George Wilkie <george.wilkie@intl.att.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
> ---
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index f9416f3..abea641 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -674,6 +674,8 @@ vmxnet3_rx_offload(const Vmxnet3_RxCompDesc *rcd, struct rte_mbuf *rxm)
> if ((rcd->tcp || rcd->udp) && !rcd->tuc)
> rxm->ol_flags |= PKT_RX_L4_CKSUM_BAD;
> }
> + } else {
> + rxm->packet_type = RTE_PTYPE_UNKNOWN;
> }
> }
>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-18 12:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 17:08 [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets garwilkie
2018-01-18 12:02 ` Ferruh Yigit
[not found] <1515585942-10720-1-git-send-email-george.wilkie@intl.att.com>
2018-01-18 6:04 ` Shrikrishna Khare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).