From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B097D1B1E5 for ; Thu, 11 Jan 2018 09:20:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 00:20:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="scan'208";a="18366397" Received: from dpdk26.sh.intel.com ([10.67.110.152]) by FMSMGA003.fm.intel.com with ESMTP; 11 Jan 2018 00:20:54 -0800 From: Wenzhuo Lu To: chas3@att.com, dev@dpdk.org Date: Thu, 11 Jan 2018 16:22:54 +0800 Message-Id: <1515658974-63940-1-git-send-email-wenzhuo.lu@intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <20171020032339.24079-1-3chas3@gmail.com> References: <20171020032339.24079-1-3chas3@gmail.com> Subject: Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 08:20:57 -0000 Hi, > Date: Thu, 19 Oct 2017 23:23:39 -0400 > > From: Chas Williams > > The transmit and receive controller state machines are only enabled after > receiving an interrupt and the link status is now valid. If an adapter > is being used in conjunction with NC-SI, network controller sideband > interface, the adapter may never get a link state change interrupt since > the adapter's PHY is always link up and never changes state. > > To fix this, always enable and disable the transmit and receive with > .dev_start and .dev_stop. This is a better match for what is typically > done with the other PMD's. Since we may never get an interrupt to check > the link state, we also poll once at the end of .dev_start to get the > current link status. > > Signed-off-by: Chas Williams Acked-by: Wenzhuo Lu