DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rosen Xu <rosen.xu@intel.com>
To: beilei.xing@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/i40e: fix issue of pctype doesn't take effect in X722
Date: Mon, 15 Jan 2018 18:05:55 +0800	[thread overview]
Message-ID: <1516010755-136835-1-git-send-email-rosen.xu@intel.com> (raw)
In-Reply-To: <1515740544-62985-1-git-send-email-rosen.xu@intel.com>

Pctype should be setted after Port's MAC type setted, but in current code
pctype is setted before Port's MAC type setted. Move pctype initialization
after shared code initialization which initialize Port's MARC type.

Fixes: a286ebeb0714 ("net/i40e: add dynamic mapping of SW flow types to HW pctypes")
Cc: stable@dpdk.org

Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 7796e9e..9882701 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1057,7 +1057,6 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw)
 		return 0;
 	}
 	i40e_set_default_ptype_table(dev);
-	i40e_set_default_pctype_table(dev);
 	pci_dev = RTE_ETH_DEV_TO_PCI(dev);
 	intr_handle = &pci_dev->intr_handle;
 
@@ -1103,6 +1102,8 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw)
 		return ret;
 	}
 
+	i40e_set_default_pctype_table(dev);
+
 	/*
 	 * To work around the NVM issue, initialize registers
 	 * for packet type of QinQ by software.
-- 
1.8.3.1

  reply	other threads:[~2018-01-15 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12  7:02 [dpdk-dev] [PATCH] net/i40e: fix issue of pctype does't " Rosen Xu
2018-01-15 10:05 ` Rosen Xu [this message]
2018-01-15 10:18   ` [dpdk-dev] [PATCH v2] net/i40e: fix issue of pctype doesn't " Xing, Beilei
2018-01-15 16:14     ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516010755-136835-1-git-send-email-rosen.xu@intel.com \
    --to=rosen.xu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).