From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id CE77AC5C4 for ; Sun, 28 Jun 2015 22:37:59 +0200 (CEST) Received: by wgqq4 with SMTP id q4so125880902wgq.1 for ; Sun, 28 Jun 2015 13:37:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=mAv+xa20Te6reNrd41vBQHmeKEsDH0sHD2rHLy3J0Is=; b=cqr86E1zCRt2/zVboLDQh/cT7wghGgsNM6QWRmzZT8g7onsO4lJ36zlyZbHqxLVirt aqIekTe2dOh/W8xfqfRpRajXwwm4d4H/OdTSmidARHrkMxH/+DXgqxGkOckk484X7KZe LgcqhjlOSBbRb7tLUK/pTIAxufDTmx+RAaq72yldeXToSQaSMjemz7g/+AD6XJLepN6c 4OrJsHuv5ZU/F6vNIsO00W5QBibCskEfkWd2/LNg3LQHtnz7jR6SMDcPHdA1QgVbse7y YAX3WvDzgtagt+lmIBvQ/mkWhMJeoJFKdg51zGrmcqsXUtt4gEnSukRcQT2EYkBy0QDl oIkw== X-Gm-Message-State: ALoCoQkwzI3K7Q9Ea4OjJ/zZGKq9qDKtFREITRZ7XHceHAf/kUDzUslxOoMU1j6yPeNkJZV/aBfH X-Received: by 10.180.189.209 with SMTP id gk17mr15725631wic.93.1435523879688; Sun, 28 Jun 2015 13:37:59 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u7sm8897056wif.3.2015.06.28.13.37.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2015 13:37:58 -0700 (PDT) From: Thomas Monjalon To: Neil Horman , olivier.matz@6wind.com Date: Sun, 28 Jun 2015 22:36:51 +0200 Message-ID: <1516139.mFtrbLFMUC@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1433214967-22247-1-git-send-email-helin.zhang@intel.com> <1434006240-7271-3-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/7] mbuf: use the reserved 16 bits for double vlan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2015 20:38:00 -0000 Neil, Olivier, Your opinions are requested here. Thanks 2015-06-25 08:31, Zhang, Helin: > Hi Neil [...] > > -279,7 +285,7 @@ struct rte_mbuf { > > uint16_t data_len; /**< Amount of data in segment buffer. */ > > uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ > > uint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order) */ > > - uint16_t reserved; > > + uint16_t vlan_tci_outer; /**< Outer VLAN Tag Control Identifier (CPU > > +order) */ > Do you think here is a ABI break or not? Just using the reserved 16 bits, which was > intended for the second_vlan_tag. Thanks in advance! > I did not see any "Incompatible" reported by validate_abi.sh. > > Regards, > Helin