From: Moti Haimovsky <motih@mellanox.com>
To: thomas@monjalon.net
Cc: dev@dpdk.org, Moti Haimovsky <motih@mellanox.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-dev] [PATCH v2] vfio: fix compilation errors in bsdapp
Date: Wed, 17 Jan 2018 19:24:15 +0200 [thread overview]
Message-ID: <1516209855-139507-1-git-send-email-motih@mellanox.com> (raw)
In-Reply-To: <1516206196-137537-1-git-send-email-motih@mellanox.com>
This patch fixes the following compilation errors in bsdapp
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
error: no previous prototype for function 'rte_vfio_clear_group'
[-Werror,-Wmissing-prototypes]
int rte_vfio_clear_group(int vfio_group_fd)
^
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
int rte_vfio_clear_group(int vfio_group_fd)
^
Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
V2:
* Added a stub routine instead of including the rte_vfio.h file which is only valid
in Linux applications
---
lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 7239243..04cbd81 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -748,6 +748,7 @@ int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
int rte_vfio_enable(const char *modname);
int rte_vfio_is_enabled(const char *modname);
int rte_vfio_noiommu_is_enabled(void);
+int rte_vfio_clear_group(int vfio_group_fd);
int rte_vfio_setup_device(__rte_unused const char *sysfs_base,
__rte_unused const char *dev_addr,
@@ -779,7 +780,7 @@ int rte_vfio_noiommu_is_enabled(void)
return 0;
}
-int rte_vfio_clear_group(int vfio_group_fd)
+int rte_vfio_clear_group(__rte_unused int vfio_group_fd)
{
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2018-01-17 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 16:23 [dpdk-dev] [PATCH] " Moti Haimovsky
2018-01-17 17:07 ` Burakov, Anatoly
2018-01-17 17:24 ` Moti Haimovsky [this message]
2018-01-17 17:50 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516209855-139507-1-git-send-email-motih@mellanox.com \
--to=motih@mellanox.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).