From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0051.outbound.protection.outlook.com [104.47.1.51]) by dpdk.org (Postfix) with ESMTP id F194C1B16F; Thu, 18 Jan 2018 09:44:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a44iwuxPdrug9q0yyqckpNbS89ZFrleju5p3Es6xISo=; b=G46s8ZYpSu+P559VYYBkft6VnTpYBZ2ATrGWPcr8smdwEV5FoxMyXlUt0Ajsxtj0g+uCG++Fur3ZsJM9g0BU5Dca44GiiSjfm8Q0omEmKp9StyA8oTzCGPe+64x365AGleTybVotUyIFgyG52q89IOEBh0BCQjUlpLinH1qNb+g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3797.eurprd05.prod.outlook.com (2603:10a6:209:a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 18 Jan 2018 08:44:05 +0000 From: Matan Azrad To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stephen@networkplumber.org, Adrien Mazarguil , stable@dpdk.org, Gaetan Rivet Date: Thu, 18 Jan 2018 08:43:39 +0000 Message-Id: <1516265026-6469-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516265026-6469-1-git-send-email-matan@mellanox.com> References: <1515509253-17834-1-git-send-email-matan@mellanox.com> <1516265026-6469-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0902CA0040.eurprd09.prod.outlook.com (2603:10a6:802:1::29) To AM6PR0502MB3797.eurprd05.prod.outlook.com (2603:10a6:209:a::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ba48a67-fe0d-4bac-b916-08d55e4fa28f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3797; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3797; 3:Q/8VGzwTDw0PmVR95vEFCc7IeaeiW0y5ZjrogKGfRx6+u82YHC/2Sll8W0iGYuV015ZnnKurq7j/dmljNlM8bePc5V1EUfFF4/2Ui4Ik6ezTp5FzC7H8iLpLraW1PrvLP8i0vaoXOcc+Fal5z4YFnK0O0AU7i7U+pKwparF7PhkiGsKHOg8tNVhGkfsDWvhNG1eOa/mLtcDprCxUQTGqBNcmoRf+dZrcBp2vjBueQQP6gRHtKucqa/BqH0LVIQ/i; 25:4b4NMNDwMZSxwQgzASKdzuFY4v9vrSPsLkdOYXk7fKA09gtbyrNrtu62YFh548CwcXnuVunum97wpW2cZKesBGkxwWJKy8wW51AoVKcXOTJbnRkLymLpsOxPp8IA2YuzUITKZzF1z86nFqo+tolhW9ZXyKmim1meMhe5ZNaJk4hO4DkXkXkUI2yNs8CodKaHZWJDVAxKYEzu9pEp9Jkt++oggGwQHiJDNGMTIIPyiy2ROSmHLittGHDOH8V3kVms8UB5vHfGHog9a2qgMbHTONAZNkqpbZ9DXexHgLIYZmaMQYmPxnDEBqo4hb7GV95GLqe7yROBW5ApKBfhk5j9iQ==; 31:sWFRHE80cXgdp1zawu16kc70MDj4pHRucld3z3jWeW1fl1zHu9h6QWC5yvWUFmcu5iHwXJpduTOxSIZcbvGTwVevZgT6SaaLdpwbO7iUtZaNuMOSaoNkSzuc9l+pujl57VQ+RBXirlGUHXiy789F7BOv2B+VIEk/NPNi0uhhVsS5p8aM3PAgOIKu3RqxGiXdWZbCS7ZcVRLbZWHBsHb1VOZ0yUorxRRVTZv/V0BOdxE= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3797: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3797; 20:lduLOW4u92M9FJZy7+bnt2ABBkQsHSB8oe1LbkRcKxPu6vcR/J2AwAo2AFd1MW/Kbtu9CyL+hM97+cHqRkxC8/ydXqvrziqCEbR2uN/SUYp3xZQj645JHdfbzIyipYjqk/INBmWNbiSS0Fx5oTzB5Dj3emfDcx1B67ol70587q/52bp+WjZcZDXMHst50kYN1Y+/5Do2sv2VUP/w+Cdz0hfP9n7HgfdL3qZbwKINXljg37b1zzw3MqrblM0xIyJs4RH1Zc1gzji3s9iYc0aKc6528gzCOEE3n5R+WxfSR4tEEK1RnCA7BmINgXIIPhqcQQGZywganM1uzxwUBsmFNZebSOjDIBBQYWNVUkfF9OUtKKW9/HzE+7ToDfvMHLgigCkaIf5JC9gCbaT1wgUWBUq/HYuiZhzeCxA2MEWy62wwjm+UhJnKcwHXLDmWlsn1pmILoDymQBKvjo+y/bsC/ExQ9LL7/jPOHATwdVzy+juaTawXu6gP+9iQjoa5aEM6; 4:EXh2cGXANIWaHSBFhT/n4w78buQYNwDoqR8uQEwJ0efzwBAooVUfZ6053c/vtpwaZOlFqWAwh8lK0ufkIG7TZWJRhfb3FnWBTwJXgcHIxJtJYmSZgSGmnyu9F6V5SJYv9lrwLhhZPidVCa3VCHYqRZSvctAB5sO7SZrbe+0G8wHypGURIBW2PsV7YtdzoLcgPoh+dBOZmmBvDw7O3nOs4WidihUixRzGHZ3tKUN++c4+m/KgccY0kb/ALDOJWBTxEU3sOemI0DY9fQdrKKNsrA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(3231023)(2400058)(944501161)(3002001)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:AM6PR0502MB3797; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3797; X-Forefront-PRVS: 05568D1FF7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(396003)(376002)(366004)(39860400002)(189003)(199004)(97736004)(68736007)(36756003)(50226002)(4326008)(86362001)(16526018)(81156014)(81166006)(8936002)(33026002)(55016002)(105586002)(5660300001)(106356001)(69596002)(3846002)(53936002)(66066001)(7736002)(305945005)(47776003)(2906002)(6116002)(76176011)(26005)(59450400001)(386003)(4720700003)(50466002)(52116002)(6666003)(51416003)(6916009)(7696005)(25786009)(21086003)(2950100002)(48376002)(16586007)(54906003)(8676002)(316002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3797; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3797; 23:xhbilwb0ey56YDXDIuM69z5LCrcFM2Zk2o2p3cj?= =?us-ascii?Q?uhRSfcAmicAcaF22QwCg/Kc9hc3DwPmxRnrj6e9XJtO6rxwnCFf8CIOpKmwv?= =?us-ascii?Q?up8d2TIDSsp6PyKiVJtTGvgy/4XEgNAryDTyOuCgwn57Y1ak8tMXPHjSr2bX?= =?us-ascii?Q?DYlrCx01xPDGbYxqCnLsrbsBQSYbQxsplMRO7AzqeLb0UYAKPbl9K5hP0YE2?= =?us-ascii?Q?DhpzUC+UiuO3a8EnDYu0vC/5jEiOLB7cDBTVEJUj2lLNUmz15hmQmGurEBmL?= =?us-ascii?Q?tH8YIFMrllPV/mXSfO8lBTxvBNcFD3priNMoEegEPdhKpSv9qeCYrdWCUQPE?= =?us-ascii?Q?WweA+kbKdwVh42FXjrMZdqbSQOiZI8lVUopG5wA7QuBNZqXHqPjR5XeWEGbs?= =?us-ascii?Q?BRrRX96jzt5ITZ1TogYqg7dkDqRfNcBjD0HdbSZLuwtizCgj05vedO1C1igF?= =?us-ascii?Q?0fS2twkoX1jZYrQxFqolZlY1CByMIFNIvq44Iug7imU5HhwhIWGaQSC+MXGG?= =?us-ascii?Q?0JQG9VmFm0YhqGdl8gaK1aSRmBiTEHQVyBLaiRKiyYOQfE+4bT5HWSrsC4gU?= =?us-ascii?Q?ty/vd4n1qmepCu6kdDN+c22FynvUQQy+5pVcf3gTPzZzpiRcE9HBRd8zVFF5?= =?us-ascii?Q?9Ng1sL7yM+P662vQafasp4xi/OQNCMoJCrXlBbzBGTKBLGNgUCANS+AP4cHD?= =?us-ascii?Q?ZCDGPOgUcaH5UezDc53ChZ3uCSzjdedQGiHtGnqKUy2+74joy2CtzBPFP4Ny?= =?us-ascii?Q?jEcDtNfOYiZAW92yNXMMT358YQICfswfRD118o0X8QNTSIBfL4vlvAk3ArIp?= =?us-ascii?Q?zW6H65SgAOflIqkAGMqrSovJKC+7ACpJwHQ1yZElDLk04VhzVpPLslJuXNoE?= =?us-ascii?Q?Hh8p2OqqbHyPw/KLwNjZR9CMmEEmeOun1snO0ilmu0GnqiUY+O+BhMtqJ2Ch?= =?us-ascii?Q?fifqY+/qWUsFTXDIgw9o0s4dHd/M7SyW3IEdwFnt8XtTcvOojWKSh6pRO+9r?= =?us-ascii?Q?noeZokT9SoDLg0TDB6iLKdTG3aUc5o53J0vH98Q50YdwViZC2aHaJrgmN6+W?= =?us-ascii?Q?Xh0y5Iufymjd/auv2n5W7WqMtflS/IHjFzaMt20MJ9q06zv5IiJBPkcUWZE2?= =?us-ascii?Q?wnrVNYINxHd7+41FDM8WQCS2l5GcT0SWO0Cs/u2c2xdDn6pa0nxDV+ZHvOIs?= =?us-ascii?Q?hNHsZytqRliEn1BKG3T8ZeZKKNe1CPG74/613?= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3797; 6:fySHgt9aKqOSywmR28PKAt3bnWKT/PrWVy7dY5ZRmGNTvqfyL2sxlrWQMXFxt1EIWpvQLnosx5CTM0tkNGz/wRPAZ2zILBdsIHkA7VEg8iKBUKy0wdm4zLMgJtPT+kiPhWQThz8TtalFN6LYJVsbjFnqrQK8Bn9tNMn1BowsZBw5/8hDFmDOhuVbVgTjJOl6LK+MhQ1DwqB5AB+v5ZVZZlbN+nW2AOtxJrza8x9HwSwbNvLLs3iChzTtXQtU1sVUfumnpA+NQ973Vk0ThHVtfR3+MVc4OkdxfcrfS5NOoWys5TN72dOu9gyTyc7QW/lHBGJ3BX4CG7vLslnI8WVZvfCyzRvKdxIgMNu4TQX6vyY=; 5:9xvJ5FDkxXmNioF8QEkq7d3WPc0ZEfbijuzmh9D+540jSsjd+qMWq2fstT0bXyIR0wd9eHFTzUEkfV1tEq9PGceH10x09RtllGh3j4cWFl7plinMl0E1yV+K2LHgiGz7bjpHUCc2ZNRA9xLi3Rv1ZP2aeRLGLcg8sci/MRKwwmg=; 24:jh+xMe74ZSJt0ESR0WA/lNSz1QCXZ6zdpTZ3KYqpvxTbWTelQr8l8IdvgpbYFZLf+4sZeNeVNfAhG70A5rO+lj8uWSR5ngWfKBjRjwqbjg0=; 7:v3yNal90JopvBrfr9EEdQt4wVcDhGFUBiGkg1q/W7VnO1JFLuRoStDTG1vOPfe8I2mhX5yrXeBLFRXJ/cSO7rBoyLJECxn9AHvrZZqOzjbMVazgG00BEw3AzQU0BR0Z+BsYAEscsPURxURKF+8EOC0gAHYeE78HYAyj6CO9/eGrKDxfaH0sqtx21OtXxAaKMLlUEFRfx89GsRoYlHqgJFq9mRlVTCj1h0bpWbZvm4jtKKznl6u7dzCHH2rjzLo4u SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 08:44:05.6017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ba48a67-fe0d-4bac-b916-08d55e4fa28f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3797 Subject: [dpdk-dev] [PATCH v4 1/8] net/failsafe: fix invalid free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 08:44:08 -0000 From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: stable@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index cfc83e3..ec63ac9 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params, uint8_t i; FOREACH_SUBDEV(sdev, i, dev) { - rte_free(sdev->cmdline); + free(sdev->cmdline); sdev->cmdline = NULL; free(sdev->devargs.args); sdev->devargs.args = NULL; -- 1.8.3.1