DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tomasz Duszynski <tdu@semihalf.com>
To: dev@dpdk.org
Cc: jck@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
	jianbo.liu@arm.com, Tomasz Duszynski <tdu@semihalf.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/2] net/mrvl: allow adding ether addr before port init
Date: Thu, 18 Jan 2018 11:57:37 +0100	[thread overview]
Message-ID: <1516273057-20557-3-git-send-email-tdu@semihalf.com> (raw)
In-Reply-To: <1516273057-20557-1-git-send-email-tdu@semihalf.com>

Since DPDK restores ether address configuration after device
is started it is safe to add ether address to uninitialized port (ppio).

Fixes: c0511a8f741f ("net/mrvl: check if ppio is initialized")
Cc: stable@dpdk.org

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/net/mrvl/mrvl_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c
index a011675..16a964b 100644
--- a/drivers/net/mrvl/mrvl_ethdev.c
+++ b/drivers/net/mrvl/mrvl_ethdev.c
@@ -909,7 +909,7 @@ mrvl_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
 		return -1;

 	if (!priv->ppio)
-		return -EPERM;
+		return 0;

 	/*
 	 * Maximum number of uc addresses can be tuned via kernel module mvpp2x
--
2.7.4

  parent reply	other threads:[~2018-01-18 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 10:57 [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Tomasz Duszynski
2018-01-18 10:57 ` [dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init Tomasz Duszynski
2018-01-18 10:57 ` Tomasz Duszynski [this message]
2018-01-18 16:26 ` [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516273057-20557-3-git-send-email-tdu@semihalf.com \
    --to=tdu@semihalf.com \
    --cc=dev@dpdk.org \
    --cc=dima@marvell.com \
    --cc=jck@semihalf.com \
    --cc=jianbo.liu@arm.com \
    --cc=nsamsono@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).