* [dpdk-dev] [PATCH] ethdev: move internal callback list definition
@ 2018-01-22 12:25 David Marchand
2018-01-24 15:58 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2018-01-22 12:25 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
This structure is not exposed through public apis, we should just move it
to the core header.
Signed-off-by: David Marchand <david.marchand@6wind.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
lib/librte_ether/rte_ethdev.h | 4 ----
lib/librte_ether/rte_ethdev_core.h | 4 ++++
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index ccf4a15..1a5b4cd 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1120,10 +1120,6 @@ struct rte_eth_dev;
#define RTE_ETH_ALL RTE_MAX_ETHPORTS
-struct rte_eth_dev_callback;
-/** @internal Structure to keep track of registered callbacks */
-TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);
-
/* Macros to check for valid port */
#define RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, retval) do { \
if (!rte_eth_dev_is_valid_port(port_id)) { \
diff --git a/lib/librte_ether/rte_ethdev_core.h b/lib/librte_ether/rte_ethdev_core.h
index f44b40e..3073e78 100644
--- a/lib/librte_ether/rte_ethdev_core.h
+++ b/lib/librte_ether/rte_ethdev_core.h
@@ -17,6 +17,10 @@
*
*/
+struct rte_eth_dev_callback;
+/** @internal Structure to keep track of registered callbacks */
+TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);
+
/*
* Definitions of all functions exported by an Ethernet driver through the
* the generic structure of type *eth_dev_ops* supplied in the *rte_eth_dev*
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: move internal callback list definition
2018-01-22 12:25 [dpdk-dev] [PATCH] ethdev: move internal callback list definition David Marchand
@ 2018-01-24 15:58 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-01-24 15:58 UTC (permalink / raw)
To: David Marchand, dev
On 1/22/2018 12:25 PM, David Marchand wrote:
> This structure is not exposed through public apis, we should just move it
> to the core header.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-24 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 12:25 [dpdk-dev] [PATCH] ethdev: move internal callback list definition David Marchand
2018-01-24 15:58 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).