From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by dpdk.org (Postfix) with ESMTP id B0E0C1B025; Wed, 24 Jan 2018 00:33:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w9q14PskWTdYmyiQcksCQEbkux7bGHzEuDQmkZmLiHw=; b=UwovdXlTk4o61UB8ocjPamLQwZBXXPDaCsYb4FtCBZXDatId5uavlGWPtvxH4Dh28i3AIEsDVb+34JdgvFRHwqRWuzbltKCsbtzBfhLtSMmCFuvHncVScHRlvVZMdxsUsUiS3rG6boKRg1X0M6Z6bo2SZ1eM07Y6xRUV1LvkyRM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR0502MB3881.eurprd05.prod.outlook.com (2603:10a6:7:87::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Tue, 23 Jan 2018 23:33:22 +0000 From: Ophir Munk To: dev@dpdk.org, Adrien Mazarguil Cc: Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org Date: Tue, 23 Jan 2018 23:32:47 +0000 Message-Id: <1516750367-26610-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0701CA0034.eurprd07.prod.outlook.com (2603:10a6:800:90::20) To HE1PR0502MB3881.eurprd05.prod.outlook.com (2603:10a6:7:87::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 06e894f5-9c89-4a7b-64d0-08d562b9b20d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0502MB3881; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3881; 3:3JJ6gXcBpQ7qBVMRTQonzndgexGk0LgBFVCfx0BDd7vx7+ObD6og6snPyehH3gH5yRxFVjh6p3pTl0qKrpCzR2I7bzmrAGEgwWITdnJQAKdlvW5nb87bqhgFbUW9tATA+ZCUBsAaywsiSROOO1OIrgdr/X+HdnNBJo5D6oCBvrAtjZgai9BO2AMnCTwF85vacKw5cA1JAZn5Z0wjuhtk90zSdj1YDu6kYVEPapNL4GZ8zROniW3Ql990sdjChTYZ; 25:oFE0SCeB5IYAqZJdj+2HMiQPQaovPeQhBq+dj8GDIbS9iDXq0txxrawLTIbGCJh4fboNiY9M8JNNqvcmjTDBmepRp3CFlxuQrJFly+tcLva942utdfPIaktGtzyE8o97uYc6vUVCKw78BFLBiGULLnX+wwtXqfRcrW51CulMKpJLQqjRADWNpvF1qP+31qW07eDxuV59z9+1A94ySgQkQKW3dHfoaFAYiEQW6JwYaGSE6AwYkMZCRkv7Q0G2zdXnUsPpV12COf9JNAQE0EK/33MfXu55zaFPToGkwJntn0Tw0WEVFIM4a16QwsMbMK8tQjKZXXXqcr+CRBjk+KaDzw==; 31:Lp6wTj6i8LJOQSoRkuz27J3/kj5rlvHQHbZMhW3hyQGuMNvprxGsAeaKTEUov5mwyJqyjr4hvueclit7e07/99OTqNjc8lhcRzjKRvd0XlOfG7hjtAxZb/V+WZM8MXTQ7T1ifNjNKAbAyrv5duLNzw9876caBskS6e/+THTfvnrVjFJRQsK5FtgLk/4HFRD9dLso68QT8qq5E1UEVqbhICVC5lIJ/QGPa3ibSYTqk1c= X-MS-TrafficTypeDiagnostic: HE1PR0502MB3881: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3881; 20:nyHeKskS51JG/vrGhoNzB+5ixGGdM83YXW/sBpKFkmsqVoQ5yqA11THI8IpdQBHZ05eOuDCuuHwFfqY0HD9zdDIyc7Zq9kgAz65wnexg3mzgW4E9YiU0yJmIggeu/5O1gACA0Vkk7I5QZAc4l0ZYL0u1bg2fw2kd30jjcwLueHHOt/C6P58RPD+9JnsZlLKmAE2519jjTtbYSb1PX7AgVI7k7Wxh/ToRzDYHqz9MP7g8n8plJ0H3nzIy2zpAIkKl9IdXaAFn5fFxLj/CjfduN0txtAyYwVJgz5stB6uSbu/vM3J+4GsDSLBXXVas5vwvcoHCK/r7vXrc3qw7iInsgShJnxQurK+fclGfn4xUbiQfEC+Pwg6c+IWQZ9mZSYdXdORUqq+bnxEi3ZI4fsyyPXJ3TDYnDN2LiFfcM3lMJx1PxMN8y9xNZo7UmH5+Oo3u8gyl4bFxjgUnY05Xigh9pstyBDL/oGoVsADpn5Bnym9IeBSgyWOQ3HSdXXjtf2XE; 4:yv/NLcW9wKub0PUWiP/sIrbNt+g8RKE5T7ul+jKNpW+f1IKYYqukYYeuB3uGbHwkD1Dq56e8tfTg92JapMe297z3AdF1HF1DnPfSiSg3yLgcHsTiS93MIgiIY54kgYsVvHAgjheykx/kL1/4cCxxhvnprzyDFT1HbggY/tWEnhiS2D4KBG5c8b6L3+QzsTBqM/djU0IGwi4vcKA0WfmtiF/dOOTp1Py7+N6esEecaVCCPcAev+9wKdd+lDaV8rGzptnmEZg2TMUSGxY5Anv4MA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0502MB3881; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0502MB3881; X-Forefront-PRVS: 05610E64EE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(366004)(376002)(39840400004)(346002)(199004)(189003)(25786009)(66066001)(47776003)(8936002)(50226002)(4326008)(86362001)(2906002)(8676002)(316002)(48376002)(81166006)(81156014)(386003)(50466002)(33026002)(97736004)(59450400001)(16526018)(68736007)(51416003)(26005)(7696005)(52116002)(55016002)(3846002)(4720700003)(36756003)(53936002)(69596002)(6916009)(106356001)(478600001)(105586002)(305945005)(6116002)(16586007)(6666003)(21086003)(5660300001)(54906003)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0502MB3881; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0502MB3881; 23:pH8IV1ZKEvYZYeT0sht1gw1P3+3AN9xqceF2FyG?= =?us-ascii?Q?A5o+qC4IYCrw3CV94HIFZ5wiq/goMora+bY+2kv18lGFPBV7NMEifprVPgja?= =?us-ascii?Q?HC8bcilUn7AqZk4po8T7+XTtYTL3uTHgA48nNJB6x2WIYOEt8R/9F2+RC8ou?= =?us-ascii?Q?bNDOonWGyt1OdJ88EGXEAwbzFz8SzOF6irYbCAp89+kRT87L7if3zhJbmG+P?= =?us-ascii?Q?QOY8DEvqOyGZr0G1NBApZyfzTyiCS24VZcCYUuqW77KQ6pk6q5MyblptQw0P?= =?us-ascii?Q?5imgdQFQ8JAMign2rrG82l1a/bSvWxzjU6tYw5/Jtqoc5cQwgX7r6G1pKijK?= =?us-ascii?Q?ApvQQkCQLy8Ib3PRwMomUX8nTvqhJDzSAibcvkaEQVQRowbAPe8BQLo6Hh1L?= =?us-ascii?Q?GxIO0gjV8ken7aDOZO8J8OZ2lGUrq+q+3rHhcMmUwV6R+WxuKhChHL+FuGLt?= =?us-ascii?Q?8xwr58C/mbw398Ux3UP3na9n4TI8qeDmVI3GuKFr0o/OZUVbJA0ZIAgjF/aF?= =?us-ascii?Q?eLxh5p7lMJpY/dHAWc8TPa/1PyOp8CFbLKO+hT5KVtV+r0fyAUvfpkn+fVfN?= =?us-ascii?Q?0yEvSFyQ/rOQ4B47E0/09+iy55Wm3R6KpnmWN6H6pZiwsR/ud7rYsP8WXcKl?= =?us-ascii?Q?fgPBW0UE/lbZn+Gx2Abjej+7dH8GmhlIhywpjHV9Qx/kYRDRWNQa+x3gwavf?= =?us-ascii?Q?ZEOcbMXLDbUCJQLecV9JTT098XN3y3Ikr6VSigOv+B3fY7gv/hIfNbT3goD8?= =?us-ascii?Q?MxTTg7zmepZaeDYEoLGW4m7EPuPE74dwwufL0BAQ2byzkoJsCeFbe99PJdSx?= =?us-ascii?Q?uyp3qaaH9HEfXUubrLtKvZlFwJ02c6zruYLrPTaNC8D6PgmAzU0RHqDJqmFk?= =?us-ascii?Q?k0w12CnB0VkmrSwOK4zyh1uDmxXV0iJE5pHFGCBsDtgv9Eo8F/Ah1yJenyUy?= =?us-ascii?Q?+t026dg8kzW07CmreTnyqi+lW+o2bh8svNEGuPMPuhAZy6npkJhoWu35jDzc?= =?us-ascii?Q?ncPXRraSADVCp2AEucnI/a7iyUjE3Jqdq1S7ZzcOfLrT/cOxFKaeIi9UNH56?= =?us-ascii?Q?VHK3NULbJeE6YYMRDXiH9dfMT291Qt1whr3V64IBqXKOJ4tv9igHTsIlCOaT?= =?us-ascii?Q?Opx5a7PyY4eCbi7rvro8fHWgHPsZ5EKEGXvlpiPmr4gw3xuNY2yDWng=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0502MB3881; 6:sf89DszJrTuJr+DDpKmmuQcxe3DdUM1IKuT2o/871iQFOUTdtCEDQ8GE5AhjwqW4sPMcE393tBo8ZuyrAICP0bm68ZVkQR1ZtFgSGY8gV8OLEq65ABfKpmi9JJpR8DFB8YyAeSW4tuRJEDJc1eoNJdICx1qW3dzHh09oxwgMF5+iOFrtiBFRKJbA+Fdhpd2Ot9eU0h6F6CSAPv9IwFGg0vVlebpIJmwMGWSTkoFPEz5iysM+zUIOjkO9ox0JwJPZPvP+Wpv6cCsZMdvHakmuw2QWL1U5kiqtl8wgcsV0HLkCaHEUQN59n48nPCGDPUw9Jb2MeM8tO2t4rhAhwuFuvPQOQDUHT4wvmzbwJ9BjmPE=; 5:dSJ8dkCTP1GPDcG6ZcVr1sFaMcAGVj3k3AGhyk8URUq+faYY9cYv5KMb45d3WDabSF+e0Eqp7kSh0KzAgEM2gml+s8vGWu77At5T3qozqX3xLqrxZwXdGcF+pdvRCOz+w5I4XZUFQOyFYdPZ2VwpMQUwlb+uqI02qfAsv/9w/uQ=; 24:+iDH+dtxLgsWuJgRsmwWVKF6yqckAh3vL3WlKgqr2sG/pWatw1P83eDqvQVDsrIK6c10uGU00yjerHThR93fFdp0SOKH/auRjKc6P/KHhj0=; 7:8xGVuVX9/2UVzSobTLud7tOu7Rxc+Br4AtpzmaVrFuIf0ThcenOUlAHeqZdT2ZrMIBWzBDF9Pkz6lAw0kr0XrvO/UZzw/C2qHIBmQSsA2ccVClZ1u2MhJNUBhu0leZGMOpMLS/PgasMU81PmtTNKN7c04SMta5ZRrIcKL9AIkaXk8b1Bz4hxlKsQQxJ8S84hOYTVvoTTWiMI2ZriQoCh8cBPyLgH75NGugNqw4dESq6QZgSEmIcVyD3EEx2qsgNv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2018 23:33:22.6768 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06e894f5-9c89-4a7b-64d0-08d562b9b20d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0502MB3881 Subject: [dpdk-dev] [PATCH v1] net/mlx4: fix single port configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2018 23:33:27 -0000 The number of mlx4 present ports is calculated as follows: conf.ports.present |= (UINT64_C(1) << device_attr.phys_port_cnt) - 1; That is - all ones sequence (due to -1 subtraction) When retrieving the number of ports, 1 must be added in order to obtain the correct number of ports to the power of 2, as follows: uint32_t ports = rte_log2_u32(conf->ports.present + 1); If 1 was not added, in the case of one port, the number of ports would be falsely calculated as 0. Fixes: 82642799 ("net/mlx4: check max number of ports dynamically") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 2a721e7..952dae0 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -337,7 +337,7 @@ mlx4_arg_parse(const char *key, const char *val, struct mlx4_conf *conf) return -rte_errno; } if (strcmp(MLX4_PMD_PORT_KVARG, key) == 0) { - uint32_t ports = rte_log2_u32(conf->ports.present); + uint32_t ports = rte_log2_u32(conf->ports.present + 1); if (tmp >= ports) { ERROR("port index %lu outside range [0,%" PRIu32 ")", -- 2.7.4