[dpdk-dev] [PATCH 0/4] fix VF RX queue interrupt enabling

[dpdk-dev] [PATCH 0/4] fix VF RX queue interrupt enabling

[Wenzhuo Lu]

If multiple interrupt not supported, the driver should not
try to enable RX queue interrupt. Then APP can know the RX
queue interrupt is not enabled and only choose the polling
mode.

Wenzhuo Lu (4):
  net/i40e: fix VF RX queue interrupt enabling
  net/ixgbe: fix VF RX queue interrupt enabling
  net/e1000: fix VF RX queue interrupt enabling
  net/avf: fix VF RX queue interrupt enabling

 drivers/net/avf/avf_ethdev.c      | 10 +++++++---
 drivers/net/e1000/igb_ethdev.c    |  3 ++-
 drivers/net/i40e/i40e_ethdev_vf.c |  3 ++-
 drivers/net/ixgbe/ixgbe_ethdev.c  |  3 ++-
 4 files changed, 13 insertions(+), 6 deletions(-)

-- 
1.9.3

[dpdk-dev] [PATCH 1/4] net/i40e: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 0cca0d3..60783f9 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1976,7 +1976,8 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 					dev->data->nb_tx_queues);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		if (rte_intr_efd_enable(intr_handle, intr_vector))
 			return -1;
-- 
1.9.3

[dpdk-dev] [PATCH 2/4] net/ixgbe: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 4f4334d..91ff54c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5033,7 +5033,8 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
 	ixgbevf_dev_rxtx_start(dev);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		/* According to datasheet, only vector 0/1/2 can be used,
 		 * now only one vector is used for Rx queue
 		 */
-- 
1.9.3

[dpdk-dev] [PATCH 3/4] net/e1000: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 077e094..15347df 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -3295,7 +3295,8 @@ static int eth_igbvf_link_update(struct e1000_hw *hw)
 	}
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		ret = rte_intr_efd_enable(intr_handle, intr_vector);
 		if (ret)
-- 
1.9.3

[dpdk-dev] [PATCH 4/4] net/avf: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

As UIO doesn't support multiple interrupt, and the interrupt
is occupied by the control plane. PMD should not try to enable
RX queue interrupt. Then APP can know the RX queue interrupt
is not enabled and only choose the polling mode.

Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/avf/avf_ethdev.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index b36d317..16e5fc9 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -292,7 +292,8 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 	uint16_t interval, i;
 	int vec;
 
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		if (rte_intr_efd_enable(intr_handle, dev->data->nb_rx_queues))
 			return -1;
 	}
@@ -344,7 +345,9 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 			vf->msix_base = AVF_MISC_VEC_ID;
 			for (i = 0; i < dev->data->nb_rx_queues; i++) {
 				vf->rxq_map[0] |= 1 << i;
-				intr_handle->intr_vec[i] = AVF_MISC_VEC_ID;
+				if (rte_intr_dp_is_en(intr_handle))
+					intr_handle->intr_vec[i] =
+						AVF_MISC_VEC_ID;
 			}
 			PMD_DRV_LOG(DEBUG,
 				    "vector 0 are mapping to all Rx queues");
@@ -358,7 +361,8 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 			vec = AVF_RX_VEC_START;
 			for (i = 0; i < dev->data->nb_rx_queues; i++) {
 				vf->rxq_map[vec] |= 1 << i;
-				intr_handle->intr_vec[i] = vec++;
+				if (rte_intr_dp_is_en(intr_handle))
+					intr_handle->intr_vec[i] = vec++;
 				if (vec >= vf->nb_msix)
 					vec = AVF_RX_VEC_START;
 			}
-- 
1.9.3

[dpdk-dev] [PATCH v2 0/4] fix VF RX queue interrupt enabling

[Wenzhuo Lu]

If multiple interrupt not supported, the driver should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the polling mode.

v2:
- AVF acts as not configured RX queue interrupt if not allowed.

Wenzhuo Lu (4):
  net/i40e: fix VF RX queue interrupt enabling
  net/ixgbe: fix VF RX queue interrupt enabling
  net/e1000: fix VF RX queue interrupt enabling
  net/avf: fix VF RX queue interrupt enabling

 drivers/net/avf/avf_ethdev.c      | 6 ++++--
 drivers/net/e1000/igb_ethdev.c    | 3 ++-
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 drivers/net/ixgbe/ixgbe_ethdev.c  | 3 ++-
 4 files changed, 10 insertions(+), 5 deletions(-)

-- 
1.9.3

[dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 0cca0d3..60783f9 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1976,7 +1976,8 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 					dev->data->nb_tx_queues);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		if (rte_intr_efd_enable(intr_handle, intr_vector))
 			return -1;
-- 
1.9.3

[dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 4f4334d..91ff54c 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5033,7 +5033,8 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
 	ixgbevf_dev_rxtx_start(dev);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		/* According to datasheet, only vector 0/1/2 can be used,
 		 * now only one vector is used for Rx queue
 		 */
-- 
1.9.3

[dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/e1000/igb_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 077e094..15347df 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -3295,7 +3295,8 @@ static int eth_igbvf_link_update(struct e1000_hw *hw)
 	}
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		ret = rte_intr_efd_enable(intr_handle, intr_vector);
 		if (ret)
-- 
1.9.3

[dpdk-dev] [PATCH v2 4/4] net/avf: fix VF RX queue interrupt enabling

[Wenzhuo Lu]

As UIO doesn't support multiple interrupt, and the interrupt
is occupied by the control plane. PMD should not try to enable
RX queue interrupt. Then APP can know the RX queue interrupt
is not enabled and only choose the polling mode.

Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/avf/avf_ethdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index b36d317..2bd5170 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -292,7 +292,8 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 	uint16_t interval, i;
 	int vec;
 
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		if (rte_intr_efd_enable(intr_handle, dev->data->nb_rx_queues))
 			return -1;
 	}
@@ -308,7 +309,8 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 		}
 	}
 
-	if (!dev->data->dev_conf.intr_conf.rxq) {
+	if (!dev->data->dev_conf.intr_conf.rxq ||
+	    !rte_intr_dp_is_en(intr_handle)) {
 		/* Rx interrupt disabled, Map interrupt only for writeback */
 		vf->nb_msix = 1;
 		if (vf->vf_res->vf_cap_flags &
-- 
1.9.3

Re: [dpdk-dev] [PATCH v2 4/4] net/avf: fix VF RX queue interrupt enabling

[Ferruh Yigit]

On 1/24/2018 8:16 AM, Wenzhuo Lu wrote:
> As UIO doesn't support multiple interrupt, and the interrupt
> is occupied by the control plane. PMD should not try to enable
> RX queue interrupt. Then APP can know the RX queue interrupt
> is not enabled and only choose the polling mode.
> 
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Applied to dpdk-next-net/master, thanks.

(only this patch applied, other patches in the set are still waiting.

normally we don't split patchsets, but for this release avf is going into
next-net and reset are into Helin's tree next-net-intel. After this release avf
also will be part of next-net-intel.)

Re: [dpdk-dev] [PATCH v2 0/4] fix VF RX queue interrupt enabling

[Xing, Beilei]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, January 24, 2018 4:17 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH v2 0/4] fix VF RX queue interrupt enabling
> 
> If multiple interrupt not supported, the driver should not try to enable RX
> queue interrupt. Then APP can know the RX queue interrupt is not enabled
> and only choose the polling mode.
> 
> v2:
> - AVF acts as not configured RX queue interrupt if not allowed.
> 
> Wenzhuo Lu (4):
>   net/i40e: fix VF RX queue interrupt enabling
>   net/ixgbe: fix VF RX queue interrupt enabling
>   net/e1000: fix VF RX queue interrupt enabling
>   net/avf: fix VF RX queue interrupt enabling
> 
>  drivers/net/avf/avf_ethdev.c      | 6 ++++--
>  drivers/net/e1000/igb_ethdev.c    | 3 ++-
>  drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
> drivers/net/ixgbe/ixgbe_ethdev.c  | 3 ++-
>  4 files changed, 10 insertions(+), 5 deletions(-)
> 
> --
> 1.9.3

Acked-by: Beilei Xing <beilei.xing@intel.com>

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, January 24, 2018 4:17 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt
> enabling
> 
> When using UIO, after enabling the interrupt to get the PF message, VF RX
> queue interrupt is not working.
> It's expected, as UIO doesn't support multiple interrupt.
> So, PMD should not try to enable RX queue interrupt. Then APP can know the
> RX queue interrupt is not enabled and only choose the polling mode.
> 
> Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
> CC: stable@dpdk.org
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt enabling

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, January 24, 2018 4:17 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt
> enabling
> 
> When using UIO, after enabling the interrupt to get the PF message, VF RX
> queue interrupt is not working.
> It's expected, as UIO doesn't support multiple interrupt.
> So, PMD should not try to enable RX queue interrupt. Then APP can know the
> RX queue interrupt is not enabled and only choose the polling mode.
> 
> Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> up/down")
> CC: stable@dpdk.org
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, January 24, 2018 4:17 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt
> enabling
> 
> When using UIO, after enabling the interrupt to get the PF message, VF RX
> queue interrupt is not working.
> It's expected, as UIO doesn't support multiple interrupt.
> So, PMD should not try to enable RX queue interrupt. Then APP can know the
> RX queue interrupt is not enabled and only choose the polling mode.
> 
> Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link up/down")
> CC: stable@dpdk.org
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin
> Sent: Friday, January 26, 2018 11:32 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt
> enabling
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Wednesday, January 24, 2018 4:17 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt
> > enabling
> >
> > When using UIO, after enabling the interrupt to get the PF message, VF
> > RX queue interrupt is not working.
> > It's expected, as UIO doesn't support multiple interrupt.
> > So, PMD should not try to enable RX queue interrupt. Then APP can know
> > the RX queue interrupt is not enabled and only choose the polling mode.
> >
> > Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net-intel, with commit log changes. Thanks!

/Helin

Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt enabling

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin
> Sent: Friday, January 26, 2018 11:33 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt
> enabling
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Wednesday, January 24, 2018 4:17 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue
> > interrupt enabling
> >
> > When using UIO, after enabling the interrupt to get the PF message, VF
> > RX queue interrupt is not working.
> > It's expected, as UIO doesn't support multiple interrupt.
> > So, PMD should not try to enable RX queue interrupt. Then APP can know
> > the RX queue interrupt is not enabled and only choose the polling mode.
> >
> > Fixes: 77234603fba0 ("net/ixgbe: support VF mailbox interrupt for link
> > up/down")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net-intel, with commit log changes. Thanks!

/Helin

Re: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Helin
> Sent: Friday, January 26, 2018 11:33 PM
> To: Lu, Wenzhuo; dev@dpdk.org
> Cc: Lu, Wenzhuo; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt
> enabling
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Wednesday, January 24, 2018 4:17 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue
> > interrupt enabling
> >
> > When using UIO, after enabling the interrupt to get the PF message, VF
> > RX queue interrupt is not working.
> > It's expected, as UIO doesn't support multiple interrupt.
> > So, PMD should not try to enable RX queue interrupt. Then APP can know
> > the RX queue interrupt is not enabled and only choose the polling mode.
> >
> > Fixes: 316f4f1adc2e ("net/igb: support VF mailbox interrupt for link
> > up/down")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net-intel, with commit log changes. Thanks!

/Helin