DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wenzhuo Lu <wenzhuo.lu@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling
Date: Wed, 24 Jan 2018 16:16:50 +0800	[thread overview]
Message-ID: <1516781813-50818-2-git-send-email-wenzhuo.lu@intel.com> (raw)
In-Reply-To: <1516781813-50818-1-git-send-email-wenzhuo.lu@intel.com>

When using UIO, after enabling the interrupt to get the PF
message, VF RX queue interrupt is not working.
It's expected, as UIO doesn't support multiple interrupt.
So, PMD should not try to enable RX queue interrupt. Then
APP can know the RX queue interrupt is not enabled and only
choose the polling mode.

Fixes: ae19955e7c86 ("i40evf: support reporting PF reset")
CC: stable@dpdk.org

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 0cca0d3..60783f9 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1976,7 +1976,8 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 					dev->data->nb_tx_queues);
 
 	/* check and configure queue intr-vector mapping */
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		intr_vector = dev->data->nb_rx_queues;
 		if (rte_intr_efd_enable(intr_handle, intr_vector))
 			return -1;
-- 
1.9.3

  reply	other threads:[~2018-01-24  8:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  1:38 [dpdk-dev] [PATCH 0/4] " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 1/4] net/i40e: " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 3/4] net/e1000: " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 4/4] net/avf: " Wenzhuo Lu
2018-01-24  8:16 ` [dpdk-dev] [PATCH v2 0/4] " Wenzhuo Lu
2018-01-24  8:16   ` Wenzhuo Lu [this message]
2018-01-26 15:32     ` [dpdk-dev] [PATCH v2 1/4] net/i40e: " Zhang, Helin
2018-01-26 15:40       ` Zhang, Helin
2018-01-24  8:16   ` [dpdk-dev] [PATCH v2 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-26 15:32     ` Zhang, Helin
2018-01-26 15:40       ` Zhang, Helin
2018-01-24  8:16   ` [dpdk-dev] [PATCH v2 3/4] net/e1000: " Wenzhuo Lu
2018-01-26 15:33     ` Zhang, Helin
2018-01-26 15:41       ` Zhang, Helin
2018-01-24  8:16   ` [dpdk-dev] [PATCH v2 4/4] net/avf: " Wenzhuo Lu
2018-01-25 16:39     ` Ferruh Yigit
2018-01-26 11:06   ` [dpdk-dev] [PATCH v2 0/4] " Xing, Beilei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516781813-50818-2-git-send-email-wenzhuo.lu@intel.com \
    --to=wenzhuo.lu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).