DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wenzhuo Lu <wenzhuo.lu@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: [dpdk-dev] [PATCH v2 4/4] net/avf: fix VF RX queue interrupt enabling
Date: Wed, 24 Jan 2018 16:16:53 +0800	[thread overview]
Message-ID: <1516781813-50818-5-git-send-email-wenzhuo.lu@intel.com> (raw)
In-Reply-To: <1516781813-50818-1-git-send-email-wenzhuo.lu@intel.com>

As UIO doesn't support multiple interrupt, and the interrupt
is occupied by the control plane. PMD should not try to enable
RX queue interrupt. Then APP can know the RX queue interrupt
is not enabled and only choose the polling mode.

Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/avf/avf_ethdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index b36d317..2bd5170 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -292,7 +292,8 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 	uint16_t interval, i;
 	int vec;
 
-	if (dev->data->dev_conf.intr_conf.rxq != 0) {
+	if (rte_intr_cap_multiple(intr_handle) &&
+	    dev->data->dev_conf.intr_conf.rxq) {
 		if (rte_intr_efd_enable(intr_handle, dev->data->nb_rx_queues))
 			return -1;
 	}
@@ -308,7 +309,8 @@ static int avf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 		}
 	}
 
-	if (!dev->data->dev_conf.intr_conf.rxq) {
+	if (!dev->data->dev_conf.intr_conf.rxq ||
+	    !rte_intr_dp_is_en(intr_handle)) {
 		/* Rx interrupt disabled, Map interrupt only for writeback */
 		vf->nb_msix = 1;
 		if (vf->vf_res->vf_cap_flags &
-- 
1.9.3

  parent reply	other threads:[~2018-01-24  8:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  1:38 [dpdk-dev] [PATCH 0/4] " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 1/4] net/i40e: " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 3/4] net/e1000: " Wenzhuo Lu
2018-01-24  1:38 ` [dpdk-dev] [PATCH 4/4] net/avf: " Wenzhuo Lu
2018-01-24  8:16 ` [dpdk-dev] [PATCH v2 0/4] " Wenzhuo Lu
2018-01-24  8:16   ` [dpdk-dev] [PATCH v2 1/4] net/i40e: " Wenzhuo Lu
2018-01-26 15:32     ` Zhang, Helin
2018-01-26 15:40       ` Zhang, Helin
2018-01-24  8:16   ` [dpdk-dev] [PATCH v2 2/4] net/ixgbe: " Wenzhuo Lu
2018-01-26 15:32     ` Zhang, Helin
2018-01-26 15:40       ` Zhang, Helin
2018-01-24  8:16   ` [dpdk-dev] [PATCH v2 3/4] net/e1000: " Wenzhuo Lu
2018-01-26 15:33     ` Zhang, Helin
2018-01-26 15:41       ` Zhang, Helin
2018-01-24  8:16   ` Wenzhuo Lu [this message]
2018-01-25 16:39     ` [dpdk-dev] [PATCH v2 4/4] net/avf: " Ferruh Yigit
2018-01-26 11:06   ` [dpdk-dev] [PATCH v2 0/4] " Xing, Beilei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516781813-50818-5-git-send-email-wenzhuo.lu@intel.com \
    --to=wenzhuo.lu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).