From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B11701B483 for ; Thu, 10 Jan 2019 00:45:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4A6FB24F16; Wed, 9 Jan 2019 18:45:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Jan 2019 18:45:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=5CJeyp7YU+qgbwnZi1qMyTSgCrA6NpaMeaACUQe4L4c=; b=I6QF91BUlLyq +aIg33tylohcp+5x6+nTSjJgK/4GdwqafjOZyuODV/kq5YvOwfKnq8DUI+jZL25F TUoCUOnQ2m5/qGh6kkByBJslRBJRKWVQXhG9PQqS/lxK0yHuu3NNN9FquUMHTCCa i7IYyDEfjI+vZjXbvbXow61ngNWNYjU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=5CJeyp7YU+qgbwnZi1qMyTSgCrA6NpaMeaACUQe4L 4c=; b=ZF88TK2iFlvD50/PE8eHUsQzPVktGuhLaNKePJlnT9e8TcqJUi0bM7RWb 4TNNZ96A/GRhEgkL0Au+vs5BaZcESIzlhmbSVzfFXlmKY7ch4R/W0O5ZwDU2+wQC N8r+DVgealgFDvD/FUFX3wr2R0+dWsgWIStEy258759sM2LCAgTkvDxdc4Mk5f5H xnYbWY6SQ9vsBLI8Rp5Ib0rv2re9k/lw7M8DOyv/KTcdPQJBlDnnhjDn2N23KIiW X49R1ldQsrsU9NPeAUpUU5P1HXpAIwv3gVjCVq8c/MmGtL5sdVSgdGlueOYrCqQu nxr6hlrAVr7b9noeui8HtgB9TDefg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedvgdduvdculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 99BF81027C; Wed, 9 Jan 2019 18:45:05 -0500 (EST) From: Thomas Monjalon To: Vipin Varghese Cc: dev@dpdk.org, reshma.pattan@intel.com, john.mcnamara@intel.com, amol.patel@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com, jasvinder.singh@intel.com Date: Thu, 10 Jan 2019 00:45:04 +0100 Message-ID: <15168357.XSmGzJBqIm@xps> In-Reply-To: <20190107153829.34047-2-vipin.varghese@intel.com> References: <20181213050842.64587-1-vipin.varghese@intel.com> <20190107153829.34047-1-vipin.varghese@intel.com> <20190107153829.34047-2-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 23:45:08 -0000 Hi Vipin, The code split in this v8 looks really better, except this patch which makes no sense alone. I feel you can move these changes in next patches, where appropriate, isn't it? 07/01/2019 16:38, Vipin Varghese: > Update code base and meson build file to accomadate changes for the > new functionality. > > Signed-off-by: Vipin Varghese > Acked-by: Reshma Pattan > --- > app/proc-info/main.c | 13 +++++++++++++ > app/proc-info/meson.build | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > index c20effa4f..c7697389c 100644 > --- a/app/proc-info/main.c > +++ b/app/proc-info/main.c > @@ -29,6 +29,9 @@ > #include > #include > #include > +#include > +#include > +#include > > /* Maximum long option length for option parsing. */ > #define MAX_LONG_OPT_SZ 64 > @@ -36,6 +39,10 @@ > > #define MAX_STRING_LEN 256 > > +#define STATS_BDR_FMT "========================================" > +#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \ > + STATS_BDR_FMT, s, w, STATS_BDR_FMT) > + > /**< mask of enabled ports */ > static uint32_t enabled_port_mask; > /**< Enable stats. */ > @@ -65,6 +72,9 @@ static char *xstats_name; > static uint32_t nb_xstats_ids; > static uint64_t xstats_ids[MAX_NB_XSTATS_IDS]; > > +/* show border */ > +static char bdr_str[MAX_STRING_LEN]; > + > /**< display usage */ > static void > proc_info_usage(const char *prgname) > @@ -668,5 +678,8 @@ main(int argc, char **argv) > if (ret) > printf("Error from rte_eal_cleanup(), %d\n", ret); > > + snprintf(bdr_str, MAX_STRING_LEN, " "); > + STATS_BDR_STR(50, bdr_str); > + > return 0; > } > diff --git a/app/proc-info/meson.build b/app/proc-info/meson.build > index a52b2ee4a..866b390d6 100644 > --- a/app/proc-info/meson.build > +++ b/app/proc-info/meson.build > @@ -3,4 +3,4 @@ > > sources = files('main.c') > allow_experimental_apis = true > -deps += ['ethdev', 'metrics'] > +deps += ['ethdev', 'metrics', 'security'] >