* [dpdk-dev] [PATCH 01/18] doc/contrib: document dynamic logging format
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 9:23 ` Kovacevic, Marko
2018-01-25 9:00 ` [dpdk-dev] [PATCH 02/18] event/opdl: align dynamic log name with standard Harry van Haaren
` (17 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, marko.kovacevic
This commit adds a section to the DPDK style guide to set
the dynamic logging formatting naming scheme.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: marko.kovacevic@intel.com
---
doc/guides/contributing/coding_style.rst | 53 ++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index d8e4a0f..a859350 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -702,3 +702,56 @@ All Python code should work with Python 2.7+ and 3.2+ and be compliant with
`PEP8 (Style Guide for Python Code) <https://www.python.org/dev/peps/pep-0008/>`_.
The ``pep8`` tool can be used for testing compliance with the guidelines.
+
+
+Dynamic Logging
+---------------
+
+DPDK provides infrastructure to perform logging during runtime. This is very
+useful for enabling debug output without recompilation. To enable or disable
+logging of a particular topic, the ``--log-level`` parameter can be provided
+to EAL, which will change the log level. DPDK code can register topics,
+which allows the user to adjust the log verbosity for that specific topic.
+
+In general, the naming scheme is as follows: ``type.section.name``
+
+ * Type is the type of component, where ``lib``, ``pmd``, ``bus`` and ``user``
+ are the common options.
+ * Section refers to a specific area, for example a poll-mode-driver for an
+ ethernet device would use ``pmd.net``, while an eventdev PMD uses
+ ``pmd.event``.
+ * The name identifies the individual item that the log applies to.
+ The name section must align with
+ the directory that the PMD code resides. See examples below for clarity.
+
+Examples:
+
+ * The virtio network PMD in ``drivers/net/virtio`` uses ``pmd.net.virtio``
+ * The eventdev software poll mode driver in ``drivers/event/sw`` uses ``pmd.event.sw``
+ * The octeontx mempool driver in ``drivers/mempool/octeontx`` uses ``pmd.mempool.octeontx``
+ * The DPDK hash library in ``lib/librte_hash`` uses ``lib.hash``
+
+Specializations
+~~~~~~~~~~~~~~~
+
+In addition to the above logging topic, any PMD or library can further split
+logging output by using "specializations". A specialization could be the
+difference between initialization code, and logs of events that occur at runtime.
+
+An example could be the initialization log messages getting one
+specialization, while another specialization handles mailbox command logging.
+Each PMD, library or component can create as many specializations as required.
+
+A specialization looks like this:
+
+ * Initialization output: ``type.section.name.init``
+ * PF/VF mailbox output: ``type.section.name.mbox``
+
+A real world example is the i40e poll mode driver which exposes two
+specializations, one for initialization ``pmd.i40e.init`` and the other for
+the remaining driver logs ``pmd.i40e.driver``.
+
+Note that specializations have no formatting rules, but please follow
+a precedent if one exists. In order to see all current log topics and
+specializations, run the ``app/test`` binary, and use the ``dump_log_types``
+command.
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 02/18] event/opdl: align dynamic log name with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
2018-01-25 9:00 ` [dpdk-dev] [PATCH 01/18] doc/contrib: document dynamic logging format Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 11:15 ` Liang, Ma
2018-01-25 9:00 ` [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names " Harry van Haaren
` (16 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, liang.j.ma
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Cc: liang.j.ma@intel.com
---
drivers/event/opdl/opdl_evdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
index dcbf404..2a8a1fe 100644
--- a/drivers/event/opdl/opdl_evdev.c
+++ b/drivers/event/opdl/opdl_evdev.c
@@ -758,7 +758,7 @@ RTE_INIT(opdl_init_log);
static void
opdl_init_log(void)
{
- opdl_logtype_driver = rte_log_register("eventdev.opdl.driver");
+ opdl_logtype_driver = rte_log_register("pmd.event.opdl.driver");
if (opdl_logtype_driver >= 0)
rte_log_set_level(opdl_logtype_driver, RTE_LOG_INFO);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 02/18] event/opdl: align dynamic log name with standard
2018-01-25 9:00 ` [dpdk-dev] [PATCH 02/18] event/opdl: align dynamic log name with standard Harry van Haaren
@ 2018-01-25 11:15 ` Liang, Ma
0 siblings, 0 replies; 33+ messages in thread
From: Liang, Ma @ 2018-01-25 11:15 UTC (permalink / raw)
To: Harry van Haaren; +Cc: dev
On 25 Jan 09:00, Harry van Haaren wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
>
> Cc: liang.j.ma@intel.com
> ---
> drivers/event/opdl/opdl_evdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
> index dcbf404..2a8a1fe 100644
> --- a/drivers/event/opdl/opdl_evdev.c
> +++ b/drivers/event/opdl/opdl_evdev.c
> @@ -758,7 +758,7 @@ RTE_INIT(opdl_init_log);
> static void
> opdl_init_log(void)
> {
> - opdl_logtype_driver = rte_log_register("eventdev.opdl.driver");
> + opdl_logtype_driver = rte_log_register("pmd.event.opdl.driver");
> if (opdl_logtype_driver >= 0)
> rte_log_set_level(opdl_logtype_driver, RTE_LOG_INFO);
> }
> --
> 2.7.4
>
Thanks Harry!
Acked-by: Liang Ma <liang.j.ma@intel.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
2018-01-25 9:00 ` [dpdk-dev] [PATCH 01/18] doc/contrib: document dynamic logging format Harry van Haaren
2018-01-25 9:00 ` [dpdk-dev] [PATCH 02/18] event/opdl: align dynamic log name with standard Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 11:29 ` Jerin Jacob
2018-01-25 14:19 ` santosh
2018-01-25 9:00 ` [dpdk-dev] [PATCH 04/18] bbdev: " Harry van Haaren
` (15 subsequent siblings)
18 siblings, 2 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, santosh.shukla, jerin.jacob
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainers:
Cc: santosh.shukla@caviumnetworks.com
Cc: jerin.jacob@caviumnetworks.com
---
drivers/event/octeontx/ssovf_evdev.c | 2 +-
drivers/mempool/octeontx/octeontx_fpavf.c | 4 ++--
drivers/net/octeontx/octeontx_ethdev.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
index edac6d4..a108607 100644
--- a/drivers/event/octeontx/ssovf_evdev.c
+++ b/drivers/event/octeontx/ssovf_evdev.c
@@ -25,7 +25,7 @@ RTE_INIT(otx_ssovf_init_log);
static void
otx_ssovf_init_log(void)
{
- otx_logtype_ssovf = rte_log_register("pmd.otx.eventdev");
+ otx_logtype_ssovf = rte_log_register("pmd.event.octeontx");
if (otx_logtype_ssovf >= 0)
rte_log_set_level(otx_logtype_ssovf, RTE_LOG_NOTICE);
}
diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
index 23e2b9d..61c72c7 100644
--- a/drivers/mempool/octeontx/octeontx_fpavf.c
+++ b/drivers/mempool/octeontx/octeontx_fpavf.c
@@ -112,11 +112,11 @@ RTE_INIT(otx_pool_init_log);
static void
otx_pool_init_log(void)
{
- octeontx_logtype_fpavf = rte_log_register("pmd.otx.mempool");
+ octeontx_logtype_fpavf = rte_log_register("pmd.mempool.octeontx");
if (octeontx_logtype_fpavf >= 0)
rte_log_set_level(octeontx_logtype_fpavf, RTE_LOG_NOTICE);
- octeontx_logtype_fpavf_mbox = rte_log_register("pmd.otx.mempool.mbox");
+ octeontx_logtype_fpavf_mbox = rte_log_register("pmd.mempool.octeontx.mbox");
if (octeontx_logtype_fpavf_mbox >= 0)
rte_log_set_level(octeontx_logtype_fpavf_mbox, RTE_LOG_NOTICE);
}
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index adca343..06aa0a2 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -49,15 +49,15 @@ RTE_INIT(otx_net_init_log);
static void
otx_net_init_log(void)
{
- otx_net_logtype_mbox = rte_log_register("pmd.otx.ethdev.mbox");
+ otx_net_logtype_mbox = rte_log_register("pmd.net.octeontx.mbox");
if (otx_net_logtype_mbox >= 0)
rte_log_set_level(otx_net_logtype_mbox, RTE_LOG_NOTICE);
- otx_net_logtype_init = rte_log_register("pmd.otx.ethdev.init");
+ otx_net_logtype_init = rte_log_register("pmd.net.octeontx.init");
if (otx_net_logtype_init >= 0)
rte_log_set_level(otx_net_logtype_init, RTE_LOG_NOTICE);
- otx_net_logtype_driver = rte_log_register("pmd.otx.ethdev.driver");
+ otx_net_logtype_driver = rte_log_register("pmd.net.octeontx.driver");
if (otx_net_logtype_driver >= 0)
rte_log_set_level(otx_net_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names with standard
2018-01-25 9:00 ` [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names " Harry van Haaren
@ 2018-01-25 11:29 ` Jerin Jacob
2018-01-25 14:19 ` santosh
1 sibling, 0 replies; 33+ messages in thread
From: Jerin Jacob @ 2018-01-25 11:29 UTC (permalink / raw)
To: Harry van Haaren; +Cc: dev, santosh.shukla
-----Original Message-----
> Date: Thu, 25 Jan 2018 09:00:55 +0000
> From: Harry van Haaren <harry.van.haaren@intel.com>
> To: dev@dpdk.org
> CC: Harry van Haaren <harry.van.haaren@intel.com>,
> santosh.shukla@caviumnetworks.com, jerin.jacob@caviumnetworks.com
> Subject: [PATCH 03/18] octeontx: align dynamic log names with standard
> X-Mailer: git-send-email 2.7.4
>
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names with standard
2018-01-25 9:00 ` [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names " Harry van Haaren
2018-01-25 11:29 ` Jerin Jacob
@ 2018-01-25 14:19 ` santosh
1 sibling, 0 replies; 33+ messages in thread
From: santosh @ 2018-01-25 14:19 UTC (permalink / raw)
To: Harry van Haaren, dev; +Cc: jerin.jacob
On Thursday 25 January 2018 02:30 PM, Harry van Haaren wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 04/18] bbdev: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (2 preceding siblings ...)
2018-01-25 9:00 ` [dpdk-dev] [PATCH 03/18] octeontx: align dynamic log names " Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 9:00 ` [dpdk-dev] [PATCH 05/18] net/avf: " Harry van Haaren
` (14 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, amr.mokhtar
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: amr.mokhtar@intel.com
---
drivers/bbdev/null/bbdev_null.c | 2 +-
drivers/bbdev/turbo_sw/bbdev_turbo_software.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bbdev/null/bbdev_null.c b/drivers/bbdev/null/bbdev_null.c
index b23d766..1a66de1 100644
--- a/drivers/bbdev/null/bbdev_null.c
+++ b/drivers/bbdev/null/bbdev_null.c
@@ -340,7 +340,7 @@ RTE_INIT(null_bbdev_init_log);
static void
null_bbdev_init_log(void)
{
- bbdev_logtype = rte_log_register("pmd.bbdev.null");
+ bbdev_logtype = rte_log_register("pmd.bb.null");
if (bbdev_logtype >= 0)
rte_log_set_level(bbdev_logtype, RTE_LOG_NOTICE);
}
diff --git a/drivers/bbdev/turbo_sw/bbdev_turbo_software.c b/drivers/bbdev/turbo_sw/bbdev_turbo_software.c
index 981da6e..33f7135 100644
--- a/drivers/bbdev/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/bbdev/turbo_sw/bbdev_turbo_software.c
@@ -1200,7 +1200,7 @@ RTE_INIT(null_bbdev_init_log);
static void
null_bbdev_init_log(void)
{
- bbdev_logtype = rte_log_register("pmd.bbdev.turbo_sw");
+ bbdev_logtype = rte_log_register("pmd.bb.turbo_sw");
if (bbdev_logtype >= 0)
rte_log_set_level(bbdev_logtype, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 05/18] net/avf: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (3 preceding siblings ...)
2018-01-25 9:00 ` [dpdk-dev] [PATCH 04/18] bbdev: " Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 9:00 ` [dpdk-dev] [PATCH 06/18] net/avp: " Harry van Haaren
` (13 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, jingjing.wu, wenzhuo.lu
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: jingjing.wu@intel.com
Cc: wenzhuo.lu@intel.com
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
drivers/net/avf/avf_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index cf7bbb2..15d0407 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -1340,10 +1340,10 @@ RTE_INIT(avf_init_log);
static void
avf_init_log(void)
{
- avf_logtype_init = rte_log_register("pmd.avf.init");
+ avf_logtype_init = rte_log_register("pmd.net.avf.init");
if (avf_logtype_init >= 0)
rte_log_set_level(avf_logtype_init, RTE_LOG_NOTICE);
- avf_logtype_driver = rte_log_register("pmd.avf.driver");
+ avf_logtype_driver = rte_log_register("pmd.net.avf.driver");
if (avf_logtype_driver >= 0)
rte_log_set_level(avf_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 06/18] net/avp: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (4 preceding siblings ...)
2018-01-25 9:00 ` [dpdk-dev] [PATCH 05/18] net/avf: " Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 12:05 ` Legacy, Allain
2018-01-25 9:00 ` [dpdk-dev] [PATCH 07/18] net/e1000: " Harry van Haaren
` (12 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, allain.legacy, matt.peters
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: allain.legacy@windriver.com
Cc: matt.peters@windriver.com
---
drivers/net/avp/avp_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index e4ad7b0..dba9912 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log);
static void
avp_init_log(void)
{
- avp_logtype_driver = rte_log_register("pmd.avp.driver");
+ avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
if (avp_logtype_driver >= 0)
rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 06/18] net/avp: align dynamic log names with standard
2018-01-25 9:00 ` [dpdk-dev] [PATCH 06/18] net/avp: " Harry van Haaren
@ 2018-01-25 12:05 ` Legacy, Allain
2018-01-25 17:05 ` Van Haaren, Harry
0 siblings, 1 reply; 33+ messages in thread
From: Legacy, Allain @ 2018-01-25 12:05 UTC (permalink / raw)
To: VAN HAAREN, HARRY, dev; +Cc: VAN HAAREN, HARRY, Peters, Matt
> -----Original Message-----
> From: Harry van Haaren [mailto:harry.van.haaren@intel.com]
> Sent: Thursday, January 25, 2018 4:01 AM
> Subject: [PATCH 06/18] net/avp: align dynamic log names with standard
>
> This commit aligns the names for dynamic logging with the newly defined
> logging format.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
>
> Maintainer:
> Cc: allain.legacy@windriver.com
> Cc: matt.peters@windriver.com
> ---
> drivers/net/avp/avp_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
> index e4ad7b0..dba9912 100644
> --- a/drivers/net/avp/avp_ethdev.c
> +++ b/drivers/net/avp/avp_ethdev.c
> @@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log); static void
> avp_init_log(void)
> {
> - avp_logtype_driver = rte_log_register("pmd.avp.driver");
> + avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
> if (avp_logtype_driver >= 0)
> rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE); }
> --
> 2.7.4
Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 06/18] net/avp: align dynamic log names with standard
2018-01-25 12:05 ` Legacy, Allain
@ 2018-01-25 17:05 ` Van Haaren, Harry
2018-01-25 17:46 ` Legacy, Allain
0 siblings, 1 reply; 33+ messages in thread
From: Van Haaren, Harry @ 2018-01-25 17:05 UTC (permalink / raw)
To: Legacy, Allain (Wind River), dev; +Cc: Peters, Matt (Wind River)
> From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> Sent: Thursday, January 25, 2018 12:06 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Peters, Matt (Wind
> River) <matt.peters@windriver.com>
> Subject: RE: [PATCH 06/18] net/avp: align dynamic log names with standard
>
> > -----Original Message-----
> > From: Harry van Haaren [mailto:harry.van.haaren@intel.com]
> > Sent: Thursday, January 25, 2018 4:01 AM
> > Subject: [PATCH 06/18] net/avp: align dynamic log names with standard
> >
> > This commit aligns the names for dynamic logging with the newly defined
> > logging format.
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> >
> > ---
> >
> > Maintainer:
> > Cc: allain.legacy@windriver.com
> > Cc: matt.peters@windriver.com
> > ---
> > drivers/net/avp/avp_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
> > index e4ad7b0..dba9912 100644
> > --- a/drivers/net/avp/avp_ethdev.c
> > +++ b/drivers/net/avp/avp_ethdev.c
> > @@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log); static void
> > avp_init_log(void)
> > {
> > - avp_logtype_driver = rte_log_register("pmd.avp.driver");
> > + avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
> > if (avp_logtype_driver >= 0)
> > rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE); }
> > --
> > 2.7.4
>
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Hi Allain,
I presume you meant "Acked-by" above, not "Signed off by"?
If so, please Ack :)
Thanks, -Harry
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 06/18] net/avp: align dynamic log names with standard
2018-01-25 17:05 ` Van Haaren, Harry
@ 2018-01-25 17:46 ` Legacy, Allain
0 siblings, 0 replies; 33+ messages in thread
From: Legacy, Allain @ 2018-01-25 17:46 UTC (permalink / raw)
To: VAN HAAREN, HARRY, dev; +Cc: Peters, Matt
> -----Original Message-----
> From: Van Haaren, Harry [mailto:harry.van.haaren@intel.com]
> Sent: Thursday, January 25, 2018 12:06 PM
> Subject: RE: [PATCH 06/18] net/avp: align dynamic log names with standard
>
> > From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> > Sent: Thursday, January 25, 2018 12:06 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Peters, Matt (Wind
> > River) <matt.peters@windriver.com>
> > Subject: RE: [PATCH 06/18] net/avp: align dynamic log names with
> > standard
> >
> > > -----Original Message-----
> > > From: Harry van Haaren [mailto:harry.van.haaren@intel.com]
> > > Sent: Thursday, January 25, 2018 4:01 AM
> > > Subject: [PATCH 06/18] net/avp: align dynamic log names with
> > > standard
> > >
> > > This commit aligns the names for dynamic logging with the newly
> > > defined logging format.
> > >
> > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> > >
> > > ---
> > >
> > > Maintainer:
> > > Cc: allain.legacy@windriver.com
> > > Cc: matt.peters@windriver.com
> > > ---
> > > drivers/net/avp/avp_ethdev.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/avp/avp_ethdev.c
> > > b/drivers/net/avp/avp_ethdev.c index e4ad7b0..dba9912 100644
> > > --- a/drivers/net/avp/avp_ethdev.c
> > > +++ b/drivers/net/avp/avp_ethdev.c
> > > @@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log); static void
> > > avp_init_log(void)
> > > {
> > > - avp_logtype_driver = rte_log_register("pmd.avp.driver");
> > > + avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
> > > if (avp_logtype_driver >= 0)
> > > rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE); }
> > > --
> > > 2.7.4
> >
> > Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
>
>
> Hi Allain,
>
> I presume you meant "Acked-by" above, not "Signed off by"?
> If so, please Ack :)
>
> Thanks, -Harry
Yes, sorry!
Acked-by: Allain Legacy <allain.legacy@windriver.com>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 07/18] net/e1000: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (5 preceding siblings ...)
2018-01-25 9:00 ` [dpdk-dev] [PATCH 06/18] net/avp: " Harry van Haaren
@ 2018-01-25 9:00 ` Harry van Haaren
2018-01-25 9:01 ` [dpdk-dev] [PATCH 08/18] net/ena: " Harry van Haaren
` (11 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:00 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, wenzhuo.lu
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: wenzhuo.lu@intel.com
---
drivers/net/e1000/em_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 07ee25f..242375f 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1868,10 +1868,10 @@ RTE_INIT(e1000_init_log);
static void
e1000_init_log(void)
{
- e1000_logtype_init = rte_log_register("pmd.e1000.init");
+ e1000_logtype_init = rte_log_register("pmd.net.e1000.init");
if (e1000_logtype_init >= 0)
rte_log_set_level(e1000_logtype_init, RTE_LOG_NOTICE);
- e1000_logtype_driver = rte_log_register("pmd.e1000.driver");
+ e1000_logtype_driver = rte_log_register("pmd.net.e1000.driver");
if (e1000_logtype_driver >= 0)
rte_log_set_level(e1000_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 08/18] net/ena: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (6 preceding siblings ...)
2018-01-25 9:00 ` [dpdk-dev] [PATCH 07/18] net/e1000: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 9:01 ` [dpdk-dev] [PATCH 09/18] net/enic: " Harry van Haaren
` (10 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, mw, mk, gtzalik, evgenys
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: mw@semihalf.com
Cc: mk@semihalf.com
Cc: gtzalik@amazon.com
Cc: evgenys@amazon.com
---
drivers/net/ena/ena_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 83e0ae2..be80594 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1898,10 +1898,10 @@ RTE_INIT(ena_init_log);
static void
ena_init_log(void)
{
- ena_logtype_init = rte_log_register("pmd.ena.init");
+ ena_logtype_init = rte_log_register("pmd.net.ena.init");
if (ena_logtype_init >= 0)
rte_log_set_level(ena_logtype_init, RTE_LOG_NOTICE);
- ena_logtype_driver = rte_log_register("pmd.ena.driver");
+ ena_logtype_driver = rte_log_register("pmd.net.ena.driver");
if (ena_logtype_driver >= 0)
rte_log_set_level(ena_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 09/18] net/enic: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (7 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 08/18] net/ena: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 16:30 ` Hyong Youb Kim
2018-01-25 9:01 ` [dpdk-dev] [PATCH 10/18] net/fm10k: " Harry van Haaren
` (9 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, johndale, hyonkim
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: johndale@cisco.com
Cc: hyonkim@cisco.com
---
drivers/net/enic/enic_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index e1ff9dc..1c8de4b 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -43,10 +43,10 @@ RTE_INIT(enicpmd_init_log);
static void
enicpmd_init_log(void)
{
- enicpmd_logtype_init = rte_log_register("pmd.enic.init");
+ enicpmd_logtype_init = rte_log_register("pmd.net.enic.init");
if (enicpmd_logtype_init >= 0)
rte_log_set_level(enicpmd_logtype_init, RTE_LOG_NOTICE);
- enicpmd_logtype_flow = rte_log_register("pmd.enic.flow");
+ enicpmd_logtype_flow = rte_log_register("pmd.net.enic.flow");
if (enicpmd_logtype_flow >= 0)
rte_log_set_level(enicpmd_logtype_flow, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 10/18] net/fm10k: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (8 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 09/18] net/enic: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 9:01 ` [dpdk-dev] [PATCH 11/18] net/i40e: " Harry van Haaren
` (8 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, qi.z.zhang, xiao.w.wang
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: qi.z.zhang@intel.com
Cc: xiao.w.wang@intel.com
---
drivers/net/fm10k/fm10k_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 340f604..9423761 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -3241,10 +3241,10 @@ RTE_INIT(fm10k_init_log);
static void
fm10k_init_log(void)
{
- fm10k_logtype_init = rte_log_register("pmd.fm10k.init");
+ fm10k_logtype_init = rte_log_register("pmd.net.fm10k.init");
if (fm10k_logtype_init >= 0)
rte_log_set_level(fm10k_logtype_init, RTE_LOG_NOTICE);
- fm10k_logtype_driver = rte_log_register("pmd.fm10k.driver");
+ fm10k_logtype_driver = rte_log_register("pmd.net.fm10k.driver");
if (fm10k_logtype_driver >= 0)
rte_log_set_level(fm10k_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 11/18] net/i40e: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (9 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 10/18] net/fm10k: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 9:01 ` [dpdk-dev] [PATCH 12/18] net/ixgbe: " Harry van Haaren
` (7 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, beilei.xing, qi.z.zhang
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: beilei.xing@intel.com
Cc: qi.z.zhang@intel.com
---
drivers/net/i40e/i40e_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index c4df65d..2abfae5 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -11693,10 +11693,10 @@ RTE_INIT(i40e_init_log);
static void
i40e_init_log(void)
{
- i40e_logtype_init = rte_log_register("pmd.i40e.init");
+ i40e_logtype_init = rte_log_register("pmd.net.i40e.init");
if (i40e_logtype_init >= 0)
rte_log_set_level(i40e_logtype_init, RTE_LOG_NOTICE);
- i40e_logtype_driver = rte_log_register("pmd.i40e.driver");
+ i40e_logtype_driver = rte_log_register("pmd.net.i40e.driver");
if (i40e_logtype_driver >= 0)
rte_log_set_level(i40e_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 12/18] net/ixgbe: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (10 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 11/18] net/i40e: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 9:01 ` [dpdk-dev] [PATCH 13/18] net/liquidio: " Harry van Haaren
` (6 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, wenzhuo.lu, konstantin.ananyev
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: wenzhuo.lu@intel.com
Cc: konstantin.ananyev@intel.com
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 5821768..f016328 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -8442,10 +8442,10 @@ RTE_INIT(ixgbe_init_log);
static void
ixgbe_init_log(void)
{
- ixgbe_logtype_init = rte_log_register("pmd.ixgbe.init");
+ ixgbe_logtype_init = rte_log_register("pmd.net.ixgbe.init");
if (ixgbe_logtype_init >= 0)
rte_log_set_level(ixgbe_logtype_init, RTE_LOG_NOTICE);
- ixgbe_logtype_driver = rte_log_register("pmd.ixgbe.driver");
+ ixgbe_logtype_driver = rte_log_register("pmd.net.ixgbe.driver");
if (ixgbe_logtype_driver >= 0)
rte_log_set_level(ixgbe_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 13/18] net/liquidio: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (11 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 12/18] net/ixgbe: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-27 5:21 ` Shijith Thotton
2018-01-25 9:01 ` [dpdk-dev] [PATCH 14/18] net/nfp: " Harry van Haaren
` (5 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, shijith.thotton, ssrinivasan
This commit aligns the names for dynamic logging with
the newly defined logging format.
Note that the "lio" term has been replaced with "liquidio",
as the naming scheme defines that a PMD name should be the
same as the directory that it lives in: drivers/net/liquidio
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: shijith.thotton@cavium.com
Cc: ssrinivasan@cavium.com
---
drivers/net/liquidio/lio_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 843d023..e1a20cd 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -2189,10 +2189,10 @@ RTE_INIT(lio_init_log);
static void
lio_init_log(void)
{
- lio_logtype_init = rte_log_register("pmd.lio.init");
+ lio_logtype_init = rte_log_register("pmd.net.liquidio.init");
if (lio_logtype_init >= 0)
rte_log_set_level(lio_logtype_init, RTE_LOG_NOTICE);
- lio_logtype_driver = rte_log_register("pmd.lio.driver");
+ lio_logtype_driver = rte_log_register("pmd.net.liquidio.driver");
if (lio_logtype_driver >= 0)
rte_log_set_level(lio_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 13/18] net/liquidio: align dynamic log names with standard
2018-01-25 9:01 ` [dpdk-dev] [PATCH 13/18] net/liquidio: " Harry van Haaren
@ 2018-01-27 5:21 ` Shijith Thotton
0 siblings, 0 replies; 33+ messages in thread
From: Shijith Thotton @ 2018-01-27 5:21 UTC (permalink / raw)
To: Harry van Haaren; +Cc: dev, shijith.thotton, ssrinivasan
On Thu, Jan 25, 2018 at 09:01:05AM +0000, Harry van Haaren wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Note that the "lio" term has been replaced with "liquidio",
> as the naming scheme defines that a PMD name should be the
> same as the directory that it lives in: drivers/net/liquidio
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
>
> ---
>
> Maintainer:
> Cc: shijith.thotton@cavium.com
> Cc: ssrinivasan@cavium.com
> ---
> drivers/net/liquidio/lio_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 843d023..e1a20cd 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -2189,10 +2189,10 @@ RTE_INIT(lio_init_log);
> static void
> lio_init_log(void)
> {
> - lio_logtype_init = rte_log_register("pmd.lio.init");
> + lio_logtype_init = rte_log_register("pmd.net.liquidio.init");
> if (lio_logtype_init >= 0)
> rte_log_set_level(lio_logtype_init, RTE_LOG_NOTICE);
> - lio_logtype_driver = rte_log_register("pmd.lio.driver");
> + lio_logtype_driver = rte_log_register("pmd.net.liquidio.driver");
> if (lio_logtype_driver >= 0)
> rte_log_set_level(lio_logtype_driver, RTE_LOG_NOTICE);
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 14/18] net/nfp: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (12 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 13/18] net/liquidio: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-26 11:00 ` Alejandro Lucero
2018-01-25 9:01 ` [dpdk-dev] [PATCH 15/18] net/qede: " Harry van Haaren
` (4 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, alejandro.lucero
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: alejandro.lucero@netronome.com
---
drivers/net/nfp/nfp_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 0044699..e5bfde6 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -3165,10 +3165,10 @@ RTE_INIT(nfp_init_log);
static void
nfp_init_log(void)
{
- nfp_logtype_init = rte_log_register("pmd.nfp.init");
+ nfp_logtype_init = rte_log_register("pmd.net.nfp.init");
if (nfp_logtype_init >= 0)
rte_log_set_level(nfp_logtype_init, RTE_LOG_NOTICE);
- nfp_logtype_driver = rte_log_register("pmd.nfp.driver");
+ nfp_logtype_driver = rte_log_register("pmd.net.nfp.driver");
if (nfp_logtype_driver >= 0)
rte_log_set_level(nfp_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 14/18] net/nfp: align dynamic log names with standard
2018-01-25 9:01 ` [dpdk-dev] [PATCH 14/18] net/nfp: " Harry van Haaren
@ 2018-01-26 11:00 ` Alejandro Lucero
0 siblings, 0 replies; 33+ messages in thread
From: Alejandro Lucero @ 2018-01-26 11:00 UTC (permalink / raw)
To: Harry van Haaren; +Cc: dev
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
On Thu, Jan 25, 2018 at 9:01 AM, Harry van Haaren <
harry.van.haaren@intel.com> wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
>
> Maintainer:
> Cc: alejandro.lucero@netronome.com
> ---
> drivers/net/nfp/nfp_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 0044699..e5bfde6 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -3165,10 +3165,10 @@ RTE_INIT(nfp_init_log);
> static void
> nfp_init_log(void)
> {
> - nfp_logtype_init = rte_log_register("pmd.nfp.init");
> + nfp_logtype_init = rte_log_register("pmd.net.nfp.init");
> if (nfp_logtype_init >= 0)
> rte_log_set_level(nfp_logtype_init, RTE_LOG_NOTICE);
> - nfp_logtype_driver = rte_log_register("pmd.nfp.driver");
> + nfp_logtype_driver = rte_log_register("pmd.net.nfp.driver");
> if (nfp_logtype_driver >= 0)
> rte_log_set_level(nfp_logtype_driver, RTE_LOG_NOTICE);
> }
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 15/18] net/qede: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (13 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 14/18] net/nfp: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 9:01 ` [dpdk-dev] [PATCH 16/18] net/thunderx: " Harry van Haaren
` (3 subsequent siblings)
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, rasesh.mody, harish.patil, shahed.shaikh
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: rasesh.mody@cavium.com
Cc: harish.patil@cavium.com
Cc: shahed.shaikh@cavium.com
---
drivers/net/qede/qede_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 8d82661..2f99011 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -3203,10 +3203,10 @@ RTE_INIT(qede_init_log);
static void
qede_init_log(void)
{
- qede_logtype_init = rte_log_register("pmd.qede.init");
+ qede_logtype_init = rte_log_register("pmd.net.qede.init");
if (qede_logtype_init >= 0)
rte_log_set_level(qede_logtype_init, RTE_LOG_NOTICE);
- qede_logtype_driver = rte_log_register("pmd.qede.driver");
+ qede_logtype_driver = rte_log_register("pmd.net.qede.driver");
if (qede_logtype_driver >= 0)
rte_log_set_level(qede_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* [dpdk-dev] [PATCH 16/18] net/thunderx: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (14 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 15/18] net/qede: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 11:27 ` Jerin Jacob
2018-01-25 9:01 ` [dpdk-dev] [PATCH 17/18] net/virtio: " Harry van Haaren
` (2 subsequent siblings)
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, jerin.jacob, maciej.czekaj
This commit aligns the names for dynamic logging with
the newly defined logging format.
Note that the "nicvf" term has been replaced with "thunderx",
as the naming scheme defines that a PMD name should be the
same as the directory that it lives in: drivers/net/thunderx
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: jerin.jacob@caviumnetworks.com
Cc: maciej.czekaj@caviumnetworks.com
---
drivers/net/thunderx/nicvf_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index d34938c..a65361f 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -56,15 +56,15 @@ RTE_INIT(nicvf_init_log);
static void
nicvf_init_log(void)
{
- nicvf_logtype_mbox = rte_log_register("pmd.nicvf.mbox");
+ nicvf_logtype_mbox = rte_log_register("pmd.net.thunderx.mbox");
if (nicvf_logtype_mbox >= 0)
rte_log_set_level(nicvf_logtype_mbox, RTE_LOG_NOTICE);
- nicvf_logtype_init = rte_log_register("pmd.nicvf.init");
+ nicvf_logtype_init = rte_log_register("pmd.net.thunderx.init");
if (nicvf_logtype_init >= 0)
rte_log_set_level(nicvf_logtype_init, RTE_LOG_NOTICE);
- nicvf_logtype_driver = rte_log_register("pmd.nicvf.driver");
+ nicvf_logtype_driver = rte_log_register("pmd.net.thunderx.driver");
if (nicvf_logtype_driver >= 0)
rte_log_set_level(nicvf_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 16/18] net/thunderx: align dynamic log names with standard
2018-01-25 9:01 ` [dpdk-dev] [PATCH 16/18] net/thunderx: " Harry van Haaren
@ 2018-01-25 11:27 ` Jerin Jacob
0 siblings, 0 replies; 33+ messages in thread
From: Jerin Jacob @ 2018-01-25 11:27 UTC (permalink / raw)
To: Harry van Haaren; +Cc: dev, maciej.czekaj
-----Original Message-----
> Date: Thu, 25 Jan 2018 09:01:08 +0000
> From: Harry van Haaren <harry.van.haaren@intel.com>
> To: dev@dpdk.org
> CC: Harry van Haaren <harry.van.haaren@intel.com>,
> jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com
> Subject: [PATCH 16/18] net/thunderx: align dynamic log names with standard
> X-Mailer: git-send-email 2.7.4
>
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Note that the "nicvf" term has been replaced with "thunderx",
> as the naming scheme defines that a PMD name should be the
> same as the directory that it lives in: drivers/net/thunderx
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> ---
>
> Maintainer:
> Cc: jerin.jacob@caviumnetworks.com
> Cc: maciej.czekaj@caviumnetworks.com
> ---
> drivers/net/thunderx/nicvf_ethdev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
> index d34938c..a65361f 100644
> --- a/drivers/net/thunderx/nicvf_ethdev.c
> +++ b/drivers/net/thunderx/nicvf_ethdev.c
> @@ -56,15 +56,15 @@ RTE_INIT(nicvf_init_log);
> static void
> nicvf_init_log(void)
> {
> - nicvf_logtype_mbox = rte_log_register("pmd.nicvf.mbox");
> + nicvf_logtype_mbox = rte_log_register("pmd.net.thunderx.mbox");
> if (nicvf_logtype_mbox >= 0)
> rte_log_set_level(nicvf_logtype_mbox, RTE_LOG_NOTICE);
>
> - nicvf_logtype_init = rte_log_register("pmd.nicvf.init");
> + nicvf_logtype_init = rte_log_register("pmd.net.thunderx.init");
> if (nicvf_logtype_init >= 0)
> rte_log_set_level(nicvf_logtype_init, RTE_LOG_NOTICE);
>
> - nicvf_logtype_driver = rte_log_register("pmd.nicvf.driver");
> + nicvf_logtype_driver = rte_log_register("pmd.net.thunderx.driver");
> if (nicvf_logtype_driver >= 0)
> rte_log_set_level(nicvf_logtype_driver, RTE_LOG_NOTICE);
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 17/18] net/virtio: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (15 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 16/18] net/thunderx: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-25 11:25 ` Maxime Coquelin
2018-01-25 9:01 ` [dpdk-dev] [PATCH 18/18] net/vmxnet3: " Harry van Haaren
2018-01-26 10:14 ` [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Bruce Richardson
18 siblings, 1 reply; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, yliu, maxime.coquelin, tiwei.bie
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: yliu@fridaylinux.org
Cc: maxime.coquelin@redhat.com
Cc: tiwei.bie@intel.com
---
drivers/net/virtio/virtio_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 65cb71f..4d20f5e 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -2160,10 +2160,10 @@ RTE_INIT(virtio_init_log);
static void
virtio_init_log(void)
{
- virtio_logtype_init = rte_log_register("pmd.virtio.init");
+ virtio_logtype_init = rte_log_register("pmd.net.virtio.init");
if (virtio_logtype_init >= 0)
rte_log_set_level(virtio_logtype_init, RTE_LOG_NOTICE);
- virtio_logtype_driver = rte_log_register("pmd.virtio.driver");
+ virtio_logtype_driver = rte_log_register("pmd.net.virtio.driver");
if (virtio_logtype_driver >= 0)
rte_log_set_level(virtio_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 17/18] net/virtio: align dynamic log names with standard
2018-01-25 9:01 ` [dpdk-dev] [PATCH 17/18] net/virtio: " Harry van Haaren
@ 2018-01-25 11:25 ` Maxime Coquelin
0 siblings, 0 replies; 33+ messages in thread
From: Maxime Coquelin @ 2018-01-25 11:25 UTC (permalink / raw)
To: Harry van Haaren, dev; +Cc: yliu, tiwei.bie
On 01/25/2018 10:01 AM, Harry van Haaren wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
>
> Maintainer:
> Cc: yliu@fridaylinux.org
> Cc: maxime.coquelin@redhat.com
> Cc: tiwei.bie@intel.com
> ---
> drivers/net/virtio/virtio_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 65cb71f..4d20f5e 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -2160,10 +2160,10 @@ RTE_INIT(virtio_init_log);
> static void
> virtio_init_log(void)
> {
> - virtio_logtype_init = rte_log_register("pmd.virtio.init");
> + virtio_logtype_init = rte_log_register("pmd.net.virtio.init");
> if (virtio_logtype_init >= 0)
> rte_log_set_level(virtio_logtype_init, RTE_LOG_NOTICE);
> - virtio_logtype_driver = rte_log_register("pmd.virtio.driver");
> + virtio_logtype_driver = rte_log_register("pmd.net.virtio.driver");
> if (virtio_logtype_driver >= 0)
> rte_log_set_level(virtio_logtype_driver, RTE_LOG_NOTICE);
> }
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 33+ messages in thread
* [dpdk-dev] [PATCH 18/18] net/vmxnet3: align dynamic log names with standard
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (16 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 17/18] net/virtio: " Harry van Haaren
@ 2018-01-25 9:01 ` Harry van Haaren
2018-01-26 10:14 ` [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Bruce Richardson
18 siblings, 0 replies; 33+ messages in thread
From: Harry van Haaren @ 2018-01-25 9:01 UTC (permalink / raw)
To: dev; +Cc: Harry van Haaren, skhare
This commit aligns the names for dynamic logging with
the newly defined logging format.
Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
---
Maintainer:
Cc: skhare@vmware.com
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index a2fb93c..4e68aae 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1352,10 +1352,10 @@ RTE_INIT(vmxnet3_init_log);
static void
vmxnet3_init_log(void)
{
- vmxnet3_logtype_init = rte_log_register("pmd.vmxnet3.init");
+ vmxnet3_logtype_init = rte_log_register("pmd.net.vmxnet3.init");
if (vmxnet3_logtype_init >= 0)
rte_log_set_level(vmxnet3_logtype_init, RTE_LOG_NOTICE);
- vmxnet3_logtype_driver = rte_log_register("pmd.vmxnet3.driver");
+ vmxnet3_logtype_driver = rte_log_register("pmd.net.vmxnet3.driver");
if (vmxnet3_logtype_driver >= 0)
rte_log_set_level(vmxnet3_logtype_driver, RTE_LOG_NOTICE);
}
--
2.7.4
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme
2018-01-25 9:00 [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Harry van Haaren
` (17 preceding siblings ...)
2018-01-25 9:01 ` [dpdk-dev] [PATCH 18/18] net/vmxnet3: " Harry van Haaren
@ 2018-01-26 10:14 ` Bruce Richardson
2018-01-31 8:28 ` Thomas Monjalon
18 siblings, 1 reply; 33+ messages in thread
From: Bruce Richardson @ 2018-01-26 10:14 UTC (permalink / raw)
To: Harry van Haaren
Cc: dev, ferruh.yigit, liang.j.ma, santosh.shukla, jerin.jacob,
alejandro.lucero, allain.legacy, amr.mokhtar, beilei.xing,
evgenys, gtzalik, harish.patil, hyonkim, jingjing.wu, johndale,
konstantin.ananyev, maciej.czekaj, matt.peters, maxime.coquelin,
mk, mw, qi.z.zhang, rasesh.mody, shahed.shaikh, shijith.thotton,
skhare, ssrinivasan, tiwei.bie, wenzhuo.lu, xiao.w.wang, yliu
On Thu, Jan 25, 2018 at 09:00:52AM +0000, Harry van Haaren wrote:
> This patchset adds and documents a defined naming scheme
> for logging. As the user selects logging topics of
> interest, it is important for usability that the topics
> are consistently named.
>
> The first patch of this patchset documents the new naming
> format, please review for clarity.
>
> The other 17 patches bring the existing dynamic logging
> in line with the newly documented naming scheme.
>
> Sorry for the wide email, maintainers just review own patches :)
>
> Regards, -Harry
>
I think standardizing is a great idea so:
Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 33+ messages in thread* Re: [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme
2018-01-26 10:14 ` [dpdk-dev] [PATCH 00/18] dynamic logging naming scheme Bruce Richardson
@ 2018-01-31 8:28 ` Thomas Monjalon
0 siblings, 0 replies; 33+ messages in thread
From: Thomas Monjalon @ 2018-01-31 8:28 UTC (permalink / raw)
To: Harry van Haaren
Cc: dev, Bruce Richardson, ferruh.yigit, liang.j.ma, santosh.shukla,
jerin.jacob, alejandro.lucero, allain.legacy, amr.mokhtar,
beilei.xing, evgenys, gtzalik, harish.patil, hyonkim,
jingjing.wu, johndale, konstantin.ananyev, maciej.czekaj,
matt.peters, maxime.coquelin, mk, mw, qi.z.zhang, rasesh.mody,
shahed.shaikh, shijith.thotton, skhare, ssrinivasan, tiwei.bie,
wenzhuo.lu, xiao.w.wang, yliu
26/01/2018 11:14, Bruce Richardson:
> On Thu, Jan 25, 2018 at 09:00:52AM +0000, Harry van Haaren wrote:
> > This patchset adds and documents a defined naming scheme
> > for logging. As the user selects logging topics of
> > interest, it is important for usability that the topics
> > are consistently named.
> >
> > The first patch of this patchset documents the new naming
> > format, please review for clarity.
> >
> > The other 17 patches bring the existing dynamic logging
> > in line with the newly documented naming scheme.
> >
> > Sorry for the wide email, maintainers just review own patches :)
> >
> > Regards, -Harry
> >
> I think standardizing is a great idea so:
>
> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 33+ messages in thread