From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0048.outbound.protection.outlook.com [104.47.38.48]) by dpdk.org (Postfix) with ESMTP id E1E9C1B1EE for ; Sat, 27 Jan 2018 22:16:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mwmXLFAnLFJxuc5HLodTFZqiL4PfHvy6Fnm6xb59iIo=; b=fOLzOyy6Sy63ZLxBJKOyDVCF3OWR37QB2bz7ULJkvhFwxNXg46v6SDgSqVRttmF6uMW8zOsTJnYiNvoC7BQOHOQt6jTDh059NvcfHoSoN7I3/4FAsBYk21CvDLaNsW3BiH8Ph6jES5BC5hPVHTdotVC+bJv9I2FWMmfWlVa+SKs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3669.namprd07.prod.outlook.com (2603:10b6:4:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Sat, 27 Jan 2018 21:16:33 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Shahed Shaikh , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Sat, 27 Jan 2018 13:15:34 -0800 Message-Id: <1517087735-16191-11-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1517087735-16191-1-git-send-email-rasesh.mody@cavium.com> References: <1517087735-16191-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BN6PR16CA0001.namprd16.prod.outlook.com (2603:10b6:404:f5::11) To DM5PR0701MB3669.namprd07.prod.outlook.com (2603:10b6:4:7e::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 534aebca-cc1b-409c-3ec5-08d565cb3e45 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DM5PR0701MB3669; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3669; 3:OSfcFSWx3oLejN2BElRO3oiVpumuF3lI7M+IU23yezafZmh8H2/S1Uva3+SQjk02b9dxzjEt5T3womWMV1FCt6gxis0fqNE2GDxSQkAaX78/RpKT38a8VSTgnqUR3mJIirTVTkrUN/+i0yi9nhEeTVoFbkAes+Ioc/C/urBbGbT5oOlks0tupBSmQHsL2igqvuH21+cUJsy1cWdLKg3Ewjf6y2Kw8zcrAFL9NfBP+ddUJNMsLEmoYJE8UcW40h+H; 25:TKYwWUAlp9vzRB+lObGoiRbO66LAALKXCD1zdpratxRVBfkhwPVpuV2YgSMYLXbEuiXe5PiJWPBbGk/uHz89pmdXopC26MOiAxNB48oqQo0p+je8XaMbwjcMchiuXn/SbMbMEiHQQfBjxoDXVp/jSkjb5YysaRCM7BZFUM+3WoBNIpkPawJjRa1jIcXDkyOgm0d/FG0qAZQutJ8wP016uyl9suIX/nWKULqvOVce3cKWbQ/pnbBr8l+nEFI/Ms5Bm9oNUd+lrgbIVbXEpwkifydb1o+uRRkXPX5JaO+cut91fmDalG8DnJLaOrYk3iQl3HxxemCXgOSCwi39rwuAdA==; 31:s6BYtgQ9BecKsQGSWgoimI61x/9I9gf6nW89z2kHJPA7vQO2ElW3jyhsmwh9cGXTZpKIJ76QuDZjuwNPPK+36AxAV+pNWdadZuO58U/e/jXMceILf8atASyMibFuPacagFVvGookPnoPi+dr43uGPia8N3xy3iN0pEfV8vUTlkB4FuL5wNwCj+SOIZz9zo6+vf8wdvHnHu/GSagIbo60J4NeVK9pCwDa7WqALmgvDws= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3669: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3669; 20:QiCYHdcOePbSqrex2jFh6M6aUBzMYiYyPVatC6E+C74YAqzCOzZCL3R5UfFg5N4d7EpuHR3pKLK1/20FJQRCfLFJfFYurpc66jaY3RPMVcw4MElWNxCkMKu78Y8o/CHPiQdd2Yp6kH7rv3Lwx8dR19YYKfW3hB0qYtM8MSXmbGQMLoRtUgPYeu0ttRx7xHw2ZBWEPnb/fKvvzTlen8b2VaNpIRd3r4ZAjIK/WG6M4Nfk+cQPq6h+keCx47cH5XB3jvpA/adAfwqBpQh7D7d1gl2/Bxz+3bOGjNUs5JvCAmFC2bQHqpYqUGpHrLXR5rKeWHu+OAQNhsjYr8HZg/gq9+QeB9UZOPoFmfIemBSyYN4qF5KLgnbdulrreHGobWMBjd6F41DdcWOWuRHD3AdCetW0ozc6Xf0P2P/vQyPj8f+x+vywcEGVRngfM7clyyDvbh8V9rIKShy4E8foF/IfuZrpnWr2MSrh1TgpDTc5r/RsQJO8loxWiAdD/5Sfe3cZ; 4:G83IwsvD3Tqkh2fKEItp/O1KRWTsxe77f/dCeIFBfu9n6Vg8gIWyS182RXHw5MI0o/XgC0dgV2bJx9+IBE+vXd0fK8NI0m+lOoyqNepLEzxTBFj1fZiNQmjh2jxeNkMfHpf0PBte5hauobzz6f5gwQ1WnCnH+hP5wS1Csqp+8wn9FvhbvZCJd7XqlDH89ilp5olOR9PYHMHABTJ7c3LJdnUF4TBzDcw66Qlp2sIWhkqkhQodGcz0r6jLJOWTdkSAEoX+6bGsI30McgnVWSMVwQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231092)(2400081)(944501161)(93006095)(93001095)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR0701MB3669; BCL:0; PCL:0; RULEID:; SRVR:DM5PR0701MB3669; X-Forefront-PRVS: 056544FBEE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(376002)(366004)(346002)(39380400002)(199004)(189003)(107886003)(50226002)(386003)(68736007)(4326008)(50466002)(6916009)(5660300001)(2361001)(106356001)(478600001)(48376002)(4720700003)(2351001)(16586007)(21086003)(305945005)(59450400001)(72206003)(51416003)(7696005)(52116002)(7736002)(316002)(76176011)(2950100002)(53936002)(69596002)(97736004)(66066001)(16526019)(2906002)(36756003)(81166006)(26005)(86362001)(25786009)(47776003)(81156014)(8936002)(8676002)(3846002)(55016002)(105586002)(6116002)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3669; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3669; 23:j31UvQL9pMH68fDQLKcoFm8a4NHKYhTfRzLkqlb?= =?us-ascii?Q?VPEXgtoWSZhdwz4gy44jhw8oRRs/ZrSMOyEEdo+UiIn/iKysZPIThUIyaFmU?= =?us-ascii?Q?hv0RzNdZ/Ufqr+w1WKE/wQ0qyacL3WAaTljeWbcpbaXR4nsu7Jzr8+22NwqH?= =?us-ascii?Q?fgi4uUEyebUXbeA4+xvyZuNa5R/8RGlAOC+UeY379g7hI7NDwXvlTkc0cm6N?= =?us-ascii?Q?NX9OsHhfO7CyvNjn8GuVIGAlLBxvvMzZNARpQSupIXXUjIzAdY2Kdl+kh2VA?= =?us-ascii?Q?Rv5aWLon/xFD63hwF7Kmav9oJWXDgXislD7CdNLWMhEgsDSRKCZdGQuobdEf?= =?us-ascii?Q?5jLBw5jTiyK6B9XAHUTboR9CWFryEUmqePmLMJ2Vqafk1S+qRbI7A9gED3FF?= =?us-ascii?Q?G0onDNI9pLmqZ2gB9ubYAaSQ/Pn2YUV67RuovMt3nTiAZ6sC32YaxjqjLvwN?= =?us-ascii?Q?X+ez7BbySfHFRmBflQlHwq+hSKWhbVr0MTDfNe6HtLOJG14BFNHA/rdos5mV?= =?us-ascii?Q?H9d2UJ4ZmzMkhJAetKA3WbF+VSbuFDfZd811K7Bqo0jj3A6Wo95TsVKvMQ5j?= =?us-ascii?Q?ALM4reyRGivaxzD+HNOZaodzFVSLMEPulkJjEf9Qhfz6SpDsR/CrQ/S7JTYN?= =?us-ascii?Q?akJulPrX/eYh0seAUTAUnYiwyR3qjpY+nxaOBLiYSgyw+PXosvaXf3MSpl+z?= =?us-ascii?Q?c4izD4cMVjJJ0sC4h+VD24kwiaqXXOx8nH0sP7/9ovs6GOSaD+rXhPqhwglN?= =?us-ascii?Q?q2gqN3VDht6cAD6dAiwWafYv33RwU0HZaJzSlPhjFpeJewaNtMCCkuVaLsni?= =?us-ascii?Q?4SMogl31ZSkZXDMaTEr1orqsGjayXNMzkOiYwWkSw9Re5yiDcVlm4N2XCyKc?= =?us-ascii?Q?RbCWoXkUqXh++gqLPo5D0pHekqex1dpfjNgP6WItr+YdlV8KaGmPQeJmgSBY?= =?us-ascii?Q?6Nk7H4W+m/VvrauOYfUdfkm2/DyGhAyZQzWYHbV6ccFFYOVzzgCP97KoCrpO?= =?us-ascii?Q?iNXP1XjCPSIZ4zb/gKogwzN3TM2pJF3GzMV2dfijlv+HdAMgIsqnL84Hx1Ot?= =?us-ascii?Q?PiouCjk0S2J7qmoDaQN8knTfbluLFuv0nnFZkMmS+KVGj+j3aW2rT43hueL1?= =?us-ascii?Q?BElGc0kS7XvCGYXulaT57bkAzNXBgBrD2NSU+c1VyLNMLgWLFUjcc5Pr9b7e?= =?us-ascii?Q?4aj/U2QUZxQuA4HnFt0vcRfLySB/BmE1bFwmlCcFYwtOkSePU6BgiUNz/nhP?= =?us-ascii?Q?Nnu0jXII3QrKhSGs8g6Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3669; 6:/HrXpQG9YIgLx22mAlqoQ9c2Lwk9utIJ9QuLRJJp2JQ0cA9kvpKsyjs35wm0Zn/ERpGbB22UvuBb+lIfETiyV8rUROFlaSeM717Guw0clVa3svR3ox6NwKBAnsV+2+LWVOtV0SKt8Padd4tYpfI5UDhCZFpCD8xgSybk3995adu96jPgpib20Ths10oaCwQvtmmuJqCIjCzpShfkrTPt3dtwEOpzZ3N9X/OwyH5pOO/JjusmKpozq6JYDA6it8mdWvWV3xLW/AOfcyo3XFYRQcZLNN5p9tozBgV6rELongb9grvfE3A31F49puE40W5PV9ndAikvf7ZwI3Cdnx6ipNGNOKSwypfwWVewkyIjvj4=; 5:23wqcKXCia1kpvZ7VLJ8bm18RYR3yO7/6brroGZ81uSOgUaXjTSjHJR4QevbwXAtnHeHnqGXlxugsEkjhT2LFZ5l2t71GSenYniS1K2XDHTwm+5jadLUaRam/EmuxyinHx4ZxZGgWvBUOMdp91wtvKPss+b+CN+WXdHZ5wWAhEU=; 24:BFkPXqqbgn9K2QEnvCs11b6DhP60+qGNDnYkRjLWEV1mQjfxKhGIR26pAZSEg/7FzAV3VeRyVZQNtSEkwdU/Nzfwaxq8Bh/6Q03O+G7ph3U=; 7:hBjZQVCcT4umgRryFEDwMt9Ty3t3yuoXW7O2z/BMMoeIcscQD+zjcHt7PupWWM5sHky7Pm4P1LZGYlFolAEWS+J69x6FfLzgSVsEJcPaTf5cbYbPXXTgVGWfOuDoPWf6BGMtR19wiKcWUPP3ptcWjEz/c57UWyh58aD4egWxJL8rGVDrWyuDuaf/HmRTuOwfEg5/I4Jk5k1Q8/RtUtG0WzVORNrJ7I9tuF/n8ssHVPYSpKwXco5v2gDm/6R7250k SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2018 21:16:33.3878 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 534aebca-cc1b-409c-3ec5-08d565cb3e45 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3669 Subject: [dpdk-dev] [PATCH 10/11] net/qede: add check for null return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 21:16:35 -0000 From: Shahed Shaikh Test the return value of ecore_ptt_acquire for NULL. Fixes: d378cefab84e ("net/qede: add support for GENEVE tunneling offload") Coverity issue: 257049 Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index cab5059..c3cea6d 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -681,7 +681,16 @@ static void qede_set_ucast_cmn_params(struct ecore_filter_ucast *ucast) for_each_hwfn(edev, i) { p_hwfn = &edev->hwfns[i]; - p_ptt = IS_PF(edev) ? ecore_ptt_acquire(p_hwfn) : NULL; + if (IS_PF(edev)) { + p_ptt = ecore_ptt_acquire(p_hwfn); + if (!p_ptt) { + DP_ERR(p_hwfn, "Can't acquire PTT\n"); + return -EAGAIN; + } + } else { + p_ptt = NULL; + } + rc = ecore_sp_pf_update_tunn_cfg(p_hwfn, p_ptt, tunn_info, ECORE_SPQ_MODE_CB, NULL); if (IS_PF(edev)) -- 1.7.10.3