From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0064.outbound.protection.outlook.com [104.47.38.64]) by dpdk.org (Postfix) with ESMTP id 0EF301B1B6 for ; Sat, 27 Jan 2018 22:16:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sf5jSb9+oq/xfWCU6gmpgCZJvh+YxwyAz+lzrmYVzgc=; b=omuTvk2/1Ote1cxEdsJXVOqUB4EW4hp49x5Cy1dpBKiiITS6BKFjc3WJqP8j+yglaJbITC9ydZ+YhKUshN/91JxiLMNx8cjgQikJl2CleLYX2jlNW1oZnyhWFby8V1idGTlYkqniihultpNj/rOeJtN9fGcdvr8lC1a+htX595E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3669.namprd07.prod.outlook.com (2603:10b6:4:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Sat, 27 Jan 2018 21:16:28 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Sat, 27 Jan 2018 13:15:29 -0800 Message-Id: <1517087735-16191-6-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1517087735-16191-1-git-send-email-rasesh.mody@cavium.com> References: <1517087735-16191-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BN6PR16CA0001.namprd16.prod.outlook.com (2603:10b6:404:f5::11) To DM5PR0701MB3669.namprd07.prod.outlook.com (2603:10b6:4:7e::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73188ad4-1040-47fb-af01-08d565cb3b2d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DM5PR0701MB3669; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3669; 3:PUKFcvQPsWFbJunOe/gEQt8T7WtMv5/iLSz4LqKM0nHRQPTvdAnG/aMrd6Etz/KbySRStZZL2TxKZv+zbtZilSnXwfBCwvL8smyzdlKivbC0BZ0ww7pTYiHHV8mKGKuVij8Kh/H7pZhNkmmhwIam7uaNOmgE0J/SreJ0/Uzbm6tGdl4K4TiTeduKjsPPXRbf+cPLmxesJisJwYFXB2zsSlg85Jffb71oRVtSbywOwVBJldrSEEVCLxjv34qjrSA6; 25:p9ifiSgCUy0aABqbwgywfjII/qSJzXiY64qOfTZnKq4adktH428jMJ+JJgEimNapISTyXRwHFrOgvtBTMAwLZCCGJ3NMTokdArrwiNt+vxBYbes65JnUhOk+JdJdR6Gx8CYyccOuJfNlPjzrBQP6ag7qiqcHmhYGmSgdAJl0h8LcjUVK1TQajOyPI8HDUktXJmnRdgl9LO2LLaVbHfEgB4yG2+j55vc9gnAsMuxfKINzyUtretKrjPfbfhQDJ2LFxSrsJUgdDO9WOIqjKqgYUdIepxALt10FjBhYx1LASGH0Fuzvfa+v0aphmzCkAONlPFXBzvQ3A8obQzdvtUI2/Q==; 31:iN8W/Iv/KKYySTbOCpHDN4J9dHxikmDx9L4R3rNhAh/+a8IZHNaDBSAX3Q3Pb2Zj9MlTVvCMfoFArUPnOzKhStperTV8qrleFoXHGaiWf7NNCEoRuBbW1E8jxKZNsFekeowLIHMMuoS7uO/m4diLfLuZAS+l6DZyzYoq1pnL98daV5X3GYYYpOJIjM5GMXEhKfrrle5PD0QQxirewPXR129c77JjqhwQpYdKEllJuS8= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3669: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3669; 20:cRZnEvVoxdRZSLXrV1dsX7HHukUHypf0WsmDkDkO7AVmmZLXTvtEWoFZ95Vu932GByRwDJpbReEFHUeFj/hVvpGJJF5GlJ7nZUGGFDi2qqOlfRu63KDRK/61JknCrQEqcxRziiHGTJcK3YecpVRGPvVZbV3G8grQKJB6ZFFP/GsOTSCRUtFak+gqWgiPRDnCrjcXlACd8mLhoKvh7xe4VBwj+41e7bcdqTxUT64ZkaqnFC9n60dOkGljHeVdD4JmYaCqaeuH7fC1DP2ckQd3fX0x6KxB7ggp/uiOwPWrAWl0ZyhBYkKJ6xlpNXNPkhCxewMEhAXBs+y0LSNB7/EfqKyRycElCAWmqVqEBSjrHl0OoHP+ZWsSaC8iSgC7XLm6p18mmwIjZmr2Pl+tvBdhUHIOXmdArlp2BgjGqviSec3g1EZ11oY7bkXnziYMn7RWYUv7w52glIt0bnZR0AFgNGKHzqbfnkk8DpA4R5/wipY9GAx0HGMgyO34618cX3/S; 4:XnAl0MnosJ1XdC/Ypy1bBGlLaQJ0lrQoaVLBwUL95WJPA13pF7hyKwmFGsGBhmLlNmp9JNaH3L/+q2ZrxW93aCK2A1UKpMzA5gUK/2ne5iygXqYd9JhSwHrFNXgO/GCVtivJCZPxXEzF7terNFgvNbgGymR6x468dr2NawdVsuaHgCkywEWV+nK/o/H4F1fsSVaCQfFdWZAle209Ziu+XFkjWHIfAwTDV+HnFPRHsYQ17oZqVmFUEwu19Q+DkWKxowWr/Ry056T2ygf0ZPc34Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231092)(2400081)(944501161)(93006095)(93001095)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR0701MB3669; BCL:0; PCL:0; RULEID:; SRVR:DM5PR0701MB3669; X-Forefront-PRVS: 056544FBEE X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(376002)(366004)(346002)(39380400002)(199004)(189003)(107886003)(50226002)(386003)(68736007)(4326008)(50466002)(6916009)(5660300001)(2361001)(106356001)(478600001)(48376002)(4720700003)(2351001)(16586007)(21086003)(305945005)(72206003)(51416003)(7696005)(52116002)(7736002)(316002)(76176011)(2950100002)(53936002)(69596002)(97736004)(66066001)(16526019)(2906002)(36756003)(81166006)(26005)(86362001)(575784001)(25786009)(47776003)(81156014)(8936002)(8676002)(3846002)(55016002)(105586002)(6116002)(186003)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3669; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3669; 23:pzFMGsrk6unJi66PRcDqNID674pD303lfgEQ2L0?= =?us-ascii?Q?HFp0dLrm5jUcAt8Pckre/WRx+XVt4KTpAvHP5UBsDvHHn+o8Q0edIN2MfZR5?= =?us-ascii?Q?pcecD3G7WumUrR7POqhxmO4qb8rnCHPLs6XKuDvEC6dIJM33+M1S3l+vibl4?= =?us-ascii?Q?kXfKy4ph4m4fuG+kf3j0pqanDfvBQ/hg8nDqduGXfPQoAt+0qaBhBGOZHQ6W?= =?us-ascii?Q?3DZLf8nd0XqzVLvgZFuNSG+3rgwtHup412ewjToJ6WiVnDzTXWDPeA5fesFd?= =?us-ascii?Q?xlyxnbOOrC5JZaIRGGW4YltJKBqfrwn4P722b1TL8hUqe4/h/lSkx5VoEi1/?= =?us-ascii?Q?H6UvSlvuDvBUmpHM1KcvwNaNX6V21vAZBNEaXnc6ThQuJjThMqSmMhqzbSCr?= =?us-ascii?Q?6CgZm7SLkYfZzVwgkrZkRMm9uJQU3G7kcoWooJDaHEpZi0FzLXxPFHiL/gMj?= =?us-ascii?Q?vylANIllR2xTABA7pmD2gQ9R5o+k4tMdnKuLwzlYCOcz4iF8hostufQqV0B5?= =?us-ascii?Q?xgHp5Dd7rFb3i4n3ZmCIN+m1iNEcGWjZFlDeaCjvP5v79khIygiSvsJyirRb?= =?us-ascii?Q?hJi3Dm6TAfYqNgnfiIpHcPNUdPXBr904OHbiAqWD1/SDL54J+OR5umiNM9q+?= =?us-ascii?Q?MV3VJMlwova2RX4+xI8YgdC8ziNwwFn5URdO3wE0OoyWnkPdXurC1zQP4xcd?= =?us-ascii?Q?0MV3QjIk1VT8+QDjdgb179yqNuewzJrDV9DxGoAPDnt/q6G693umn1tid1Oc?= =?us-ascii?Q?CDO0qmr6CP+jjhWfjwajm9dXwPtKZVkgTdjHf/61nfFPNE3SBWdQySlobfV/?= =?us-ascii?Q?Xq8EZMWq++AwtMQIosRnlfkNIJwhVn2yXreAW9Z1v7kgV8teZE+LZYhTzUpT?= =?us-ascii?Q?Sb5mA0GPtm9UmMy888SMDJGrUQ9G2fLkfttxbS5nj02jLy8JWzot3wX19kbN?= =?us-ascii?Q?MIFP2f+7w+IJGsCnmhJya1tvMTkqHE5UGOOORiAW+Tfc9qGiZBPkBVWHKNGz?= =?us-ascii?Q?ygmSQOXM7dY1Qv737ILqT+l5Rd5RJ85kcYm+EhmcCG5gAzIsLXU0i4w83BJy?= =?us-ascii?Q?aa9Zxl94d40SWkmOjCYHvKobGU7H6RW/Zc7Aw2mbjweIhsy0fj2SZqp16WoZ?= =?us-ascii?Q?2HyPVVrmeQ5QvA1L4NmxN83kEXaB50DH7/4ghdgzoXQdQr464pDrkyb7IrMU?= =?us-ascii?Q?wte7YHBgkKTeuf8nRk3sPDXnjuVWOSub8R6RX8i5lkqlK9s75TEeJizAHTPS?= =?us-ascii?Q?cJ4DtMsrbTY1NUtvm+kNRYUbGQkpMJIvxAsg1Htkx?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3669; 6:burLFa13yT8St6kCOb1+N7cxpUKkI9iy53ckDABX4bDelORkK4OdGVhC0Kq8idqPYYdHStxxJy8AAL3SZnDULw4z4Pm/nq8HHZK+SfLv1CKtA88TQXsbsY+vJF/JcSL9jwU7U0YoQU4qFcioYkwigJ1m1rfu3azSn/s26tjk3cxtJt8KypX72SdG6QBh8AndGieDEPdTSnhRAvGeEp2CNujZ4KtrK6IYaEFMslk/OhwemUCWL7/cybFS08QHGEwoElq0PkkY4xXUOlksxRMsi3dn+W/w4phiK+MJZbCjRMO4L7+UtDX3y0blhjFQGj9zzTE9xMs35oovvu0eOldk/+RYGIBTz2p1XfGNZF6XP9M=; 5:mNOHxSsIWQrFR6Mwx2AWryTiYgbGEVWgGwEmYt/Zh8Osdezby/BZtLkXzOuVg/NUu62YWtAFWK+QoAUpgZOPfuxKpXqts/X19W7BtWBSeFyiXdeBjgeNSTAxkrZs0wDm0sgati4pk5MgCWRtqhP9JwkU3vq1DA52BegV4BzlnWA=; 24:7juM9IXlBXvaAdywQL4gYUk2b0M0/wRnwkvcjdP3KeXJ+IrrWl5AxwwBr3kC7ZAzgs2lo/2GUrI3zdSh2AwLYiUhOeHYnJ/ECxvoMqbAVm4=; 7:VyGYHtgYEE2Sfe67hddFhaDuxBlw1YEwcdBbfvHbD1KwE3xHl7TxH8jAYhyvNso2W/Lu7af0dPV1Rhp3RxkkONPYWVH/dCvFLjUZJ3MFbFhstkV93kY09NJTGZ81q+ELfE0djpuU31ushaLqj5UxjY9WXgtbARZg7nc8TBCw2xIQwduxGfwyRNITPNLICmKru3Z9Z4dIQedQSyq45rRTVOW8xkci3BS0/H9tK9ZbUZk/zaNE4kOyphx/C8ja15F0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2018 21:16:28.2003 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73188ad4-1040-47fb-af01-08d565cb3b2d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3669 Subject: [dpdk-dev] [PATCH 05/11] net/qede: remove DEBUG INFO config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 21:16:30 -0000 With dynamic logging, we no longer need DEBUG INFO config option. Signed-off-by: Rasesh Mody --- config/common_base | 1 - doc/guides/nics/qede.rst | 10 +--------- drivers/net/qede/qede_ethdev.c | 8 -------- drivers/net/qede/qede_logs.h | 4 ---- 4 files changed, 1 insertion(+), 22 deletions(-) diff --git a/config/common_base b/config/common_base index 170a389..d851161 100644 --- a/config/common_base +++ b/config/common_base @@ -317,7 +317,6 @@ CONFIG_RTE_LIBRTE_NFP_DEBUG_RX=n # QLogic 10G/25G/40G/50G/100G PMD # CONFIG_RTE_LIBRTE_QEDE_PMD=y -CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n #Provides abs path/name of the firmware file. diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index b958a5b..43b0f3f 100644 --- a/doc/guides/nics/qede.rst +++ b/doc/guides/nics/qede.rst @@ -87,14 +87,6 @@ enabling debugging options may affect system performance. Toggle compilation of QEDE PMD driver. -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO`` (default **n**) - - Toggle display of generic debugging messages. - -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER`` (default **n**) - - Toggle display of ecore related messages. - - ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**) Toggle display of transmit fast path run-time messages. @@ -199,7 +191,7 @@ This section provides instructions to configure SR-IOV with Linux OS. #. Running testpmd - (Enable QEDE_DEBUG_INFO=y to view informational messages): + (Supply ``--log-level="pmd.qede.driver",7`` to view informational messages): Refer to the document :ref:`compiling and testing a PMD for a NIC ` to run diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 8a69d20..323e8ed 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -357,7 +357,6 @@ static void qede_interrupt_action(struct ecore_hwfn *p_hwfn) qdev->ops = qed_ops; } -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO static void qede_print_adapter_info(struct qede_dev *qdev) { struct ecore_dev *edev = &qdev->edev; @@ -387,7 +386,6 @@ static void qede_print_adapter_info(struct qede_dev *qdev) DP_INFO(edev, " Firmware file : %s\n", fw_file); DP_INFO(edev, "*********************************\n"); } -#endif static int qede_start_vport(struct qede_dev *qdev, uint16_t mtu) @@ -1149,9 +1147,7 @@ static void qede_prandom_bytes(uint32_t *buff) int qede_config_rss(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); -#endif uint32_t def_rss_key[ECORE_RSS_KEY_SIZE]; struct rte_eth_rss_reta_entry64 reta_conf[2]; struct rte_eth_rss_conf rss_conf; @@ -1295,9 +1291,7 @@ static int qede_args_check(const char *key, const char *val, void *opaque) int ret = 0; struct rte_eth_dev *eth_dev = opaque; struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); -#endif errno = 0; tmp = strtoul(val, NULL, 0); @@ -3027,9 +3021,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops; if (do_once) { -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO qede_print_adapter_info(adapter); -#endif do_once = false; } diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index b7ecf1c..159315e 100644 --- a/drivers/net/qede/qede_logs.h +++ b/drivers/net/qede/qede_logs.h @@ -34,16 +34,12 @@ ##__VA_ARGS__); \ } while (0) -#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO #define DP_INFO(p_dev, fmt, ...) \ rte_log(RTE_LOG_INFO, qede_logtype_driver, \ "[%s:%d(%s)]" fmt, \ __func__, __LINE__, \ (p_dev)->name ? (p_dev)->name : "", \ ##__VA_ARGS__) -#else -#define DP_INFO(p_dev, fmt, ...) do { } while (0) -#endif #define DP_VERBOSE(p_dev, module, fmt, ...) \ do { \ -- 1.7.10.3