From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20073.outbound.protection.outlook.com [40.107.2.73]) by dpdk.org (Postfix) with ESMTP id C27591B2AA; Sun, 28 Jan 2018 10:43:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=U0QUoA3g4D5QnINx0QRcXoDaMPWmIK2tkhzuGri+d2M=; b=u5pvwVrAeYste9vMu3Ei5rv4ykbkGX/PqdOdyhrBTEjUo9D7ZBVGh85zzlQTM3lEchVtHBUfGfkXHa96vB5RrR91Zov85ftrvYZPP6DFzh+PHHADLmzwNIcC+hJ8FvZiGKqjeZiC0SwYxcxpGx5lSS/l28vUSqtRDUSd8yIst+w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR05MB3207.eurprd05.prod.outlook.com (2603:10a6:6:1a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Sun, 28 Jan 2018 09:43:53 +0000 From: Moti Haimovsky To: adrienm@mellanox.com, shahafs@mellanox.com Cc: dev@dpdk.org, Moti Haimovsky , stable@dpdk.org Date: Sun, 28 Jan 2018 11:43:37 +0200 Message-Id: <1517132617-194973-1-git-send-email-motih@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: AM5PR0701CA0002.eurprd07.prod.outlook.com (2603:10a6:203:51::12) To DB6PR05MB3207.eurprd05.prod.outlook.com (2603:10a6:6:1a::33) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8670d55c-4fa4-4fdb-4e8e-08d56633a550 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3207; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3207; 3:UKHmTCtbVRkhjU7wEbRjueQ8SL98r8H3ocEnv17yzSo6eR1ZlFCPbU8j9xoxXlLKHJdtd7m+4mV9KEzKZj4v4bIA8UY9tHJMsUpjjMqWQbW+U/7azxPHGGBQmnmESgDGiTFEg50rWImEOcuPtxHKFmrsWxfXdEF93vstqRkvcwQ/gVEpEFzizoWriyavTeoUl+Gvdho1rs1Xlz+oAFGo6W+dnvTROLsOzuR96U21Gf3o7c6Duj4j36/0DU/RUMnp; 25:l1l8Gr33fbFPwhmN1rxGZOlPED584q18tZ7wJOvYRQcbdfl58Yko5KLav8rLQKAYwqcocK0+3Xj93DK774Lf5OXV+q69ks2rw3MEcReLikRDdINb1CgWk3g45tmVszAR+A7LsqI5gGZvjlLD257/s7xojM1lG7rWGqbvCb91056yTPLMHL+QWULnSTya+Q9EYZddX5wvgJYZa5+PyhxmdndYBGbKdMOjMxPZhSvDuaFSclSTV4WdeeZ/9qH3JjG/p39GnzMvIAZoCcf8YdDEc1vqIVf1odOYv2SoK4u2uNWkezWj6A2uKtMh+Fkf4Ajp5t3cQVCveZawI8CDvqQeJg==; 31:WnecMr8Ov6tApc5LjaZpNgibQe4WNflpnHNMcjCvP0n1XM/l0qbrN6+giCY2K6RRZf8GNWhQF79acxyxdE7RSO40gU7eLqos6OBFlkh76hTH33bAnZvKjifyWg63S1zl2yV+3YHa5H7nq63YJi8/MEmF/lGSQpwAsn1BsIbJRG9BdEA8eqAyry6KeoqaDGlQHOKE9pEKSl8y5G8WCm9B3wHihgS8s72hAvCdYZ8cvuw= X-MS-TrafficTypeDiagnostic: DB6PR05MB3207: X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3207; 20:c0WfVs9U3Y2vnks0z5YAAD/Gt1DcjfcQxVCiFdXc5mhaBHcNRDzeKusouvUXqVHKa4fWZEEE7K94FPnSopgEFCdDmsWflm9Oius5IR78r/FuKF6NEomhKivZMdYNpluaTVI0UGH0xHlH+jcs7VrXuTi3+RBuZMXH28OEPWY4O7BZS4cYqAuVsFBb6h4JgRg9osfpxqhzUT4PXwAhlWuVwG5PqTiFc7RwHFJC8JCA3bzFT1hj4jk7RSOzZValsc6qsLNV4TGJXhfd1+nQ8dDLfabr5wt9a8Ey0fnkecETOg0JmRy9AfzsaD2HC3iwL4k/gVUnGWB9HdeH2WSCinmT5ClFoeP04sieO6n3g8npUxPFZimruGZ/DLQLphjEGH21cJuwIBXgP2gWvNVjz/+Z+jeUgo3FmRbCRz6vl0ceXi7pKPzthtF5Brkk0F09waaktiKRFOmkOmS0brYthZGuwdLA9ZdqZpeYrZzJAiRp7RCEScW5U7r4869TpmnmQBvv; 4:gv1XqLS9oiM7aRmMv1miEOcq1Fky2XNnknfUcnMmWAqLFhpB2EQnfn1CECoeztmOcQ/xjvmjJJecv2ugpsXUvy/tGMqlmAL0EsJQxBA3yxqG2AOy++MtAv4yrTLMjg/3BMOdhw/+UWvuLR8JOFVTIz5+OTLTrIieZWa/cNLUggem9Tb4QQHlh0RYINMm+rlK1i97xIWyY3wAuhKCnSxmSk7tUYLBzzbkosWm654OGlsTOiKln1sQ2UOnNJ5B5Hfi3yIeZe7rMNjrRzPGf0GLCw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:DB6PR05MB3207; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3207; X-Forefront-PRVS: 05669A7924 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(39380400002)(366004)(376002)(346002)(189003)(199004)(43544003)(7696005)(51416003)(105586002)(2906002)(66066001)(81166006)(81156014)(7736002)(86362001)(25786009)(450100002)(478600001)(305945005)(4326008)(8676002)(316002)(16586007)(36756003)(16526019)(85306007)(47776003)(8936002)(50226002)(33026002)(68736007)(26005)(386003)(59450400001)(21086003)(48376002)(5660300001)(69596002)(4720700003)(50466002)(6116002)(3846002)(6666003)(6636002)(97736004)(55016002)(106356001)(52116002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3207; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3207; 23:jvozeruU6ocVz7xxyNd/DEo/Fi1xzMxAIobTE97gx?= =?us-ascii?Q?XoLIkIg+23RyqcRXl1/LbgOh8mxnWL02eTbTZDxQlWfvZkX9N8OiPN/OEyOL?= =?us-ascii?Q?2UwGw52c4R/zPVPiULA7kypuVbXSRDc7YGSPsYA1WKybpxBJe2bKhmGEZdTP?= =?us-ascii?Q?43kPdF1HDni/hgnErdgKDlOvKL8gQTfcPZ8dNQHnnclUnua1F5UCMCpq9W7w?= =?us-ascii?Q?E/GVYZlI00w1XOfgXKXNNuUT7W9wwr/tPTRkQkKBzX6DlwqucIYcfCbI6gVa?= =?us-ascii?Q?sIsuFAUlBQKo5HRyWEXwdOoR5TCTAFkwnP8PvotRO3ed2Wj/oe6nTFOwfXh7?= =?us-ascii?Q?I/+taldla0VZCoVzjlNk7VZcFeCPR+IYWCfd6rgzMC5UVJclDAtyF6R5cLVP?= =?us-ascii?Q?crYu8SKF/zSK5Pz+VZlu5pkE0k9F+VBEP0lU5JPl5b+B9tCmIwuOtKK0DZ+F?= =?us-ascii?Q?fZMQPS8ucZ2N3uKjzNo3GZXngES1KXZBb6je9MuBEtuuhlIrb4A7mdR2R9s2?= =?us-ascii?Q?JtAQZ9lgTTX6G1myKQVW8T/Vj2EtW1FS2uQnd1rCuKw2Pl4yuWS3/N2kzgR/?= =?us-ascii?Q?o8kGGPDCuxTS8ffzPI1aRk+rtmlcKm3cvTOUBTktWsHAYTb3Wxa8fB4HN5GX?= =?us-ascii?Q?shDLOHtxMS82eG1AZNVc5dFzFY2jkFFwNPoBbyJqfQKmNY9793eAtul6D3t8?= =?us-ascii?Q?y+Hx/lGVvDCwSiPYeSTeZO/+6c6sKaLt7WaUA9dFIptSmvI7ulyKmcQSEoRq?= =?us-ascii?Q?BNxnLoHCnLb1b65LTHS5VtJCoalnUiZUj7aiQ4CPRL5aUaucWBaoEbqoX/GL?= =?us-ascii?Q?8ZR2m4/XAIKJZuyJIhBGjsYranj25t/eXqVv+2lSeuffxQ8Sm1mgg2O/OXOz?= =?us-ascii?Q?xBhXOnLOYb+UbD/cSN2Ap6B4Kht1XvKPSiznQeg72Gv7yllU3DX6khncCvMn?= =?us-ascii?Q?uNxbc5d3WvM2RMdzNbgInPHQS55cCllvKx4vlKgvupgH0nUhmDnayLO6PkHY?= =?us-ascii?Q?6w41TIHOQuJxn4Za/yKSjNJ77QhpsE2082J6U+Z9MKd9wwfw07NzKfXfj9T5?= =?us-ascii?Q?tSp+1nMZHMZq7y67HtbNuOa7sOjOkN6qkTX9gRtS9kfUXYAE4OGqVzl2JvE7?= =?us-ascii?Q?wA2LTBsJSuRVHPXl8wKHtN4NLKKmdxxpFrkBC8oy8oxXKQfrOCibJxBqq320?= =?us-ascii?Q?khMAkAHdnOxjxDMBknuuBvWUkXd1hlco3Jm?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3207; 6:qE8OeqXINXsFxYAyd6d7w8vsES4VvxWRP7pA0qOAqt/OJhTIveLZ22WhnO5taTI7kROdjRZ65a1qFMf35CBbNcx5Ilcs+x9lEpa/ymF8l8OXn2NL694qi2luUM0VV2GoSnrp6rUA99QHLEBVDFuk8SLCuw+U6ep6GWiTa3t7P2oPVLjcioJvttE4y2e4l2YWb0HY4IWRR/0bhoTHZxXQ/ThlRzLT6rw3TTnnXZTBzTUvcTHJqqp1syr5LwF+jYd+1z4C9bZXDupOpHek2NY4Cu3YzY1JP/Y8jF9Hk/4KKADbrSp4Zh1C2dADYJH0jdPGSR40P3Yv5gs1c5jQ7L7N3OvbJ9T+KcRZFNkf1eBSEwQ=; 5:pg8/69stAV0oJmAXfGNuRAl0R6uryeGQCW/JFkWR6CkED2S81OWS419sNuplw/LDLBxzsFwomrdbYLWIKpo4aPeFdYbhUsgaxq2mUEC5KqfDwmnlUDUEhxNjS1h3kdxUX5vTxKZgHCYiQAx2lzMsc4Na+V4dHDcXYMLMItRjaNU=; 24:q4v+WNNTIfsOfAXjvwB0s0/JDDXdQ+sB/S8mTAU+TfmhlY8LenfDL4KHCGP+x99gmz6uZvu9rGuCdpKpwsi44Mfy8ZxtBDhMB0dCzoo7UpE=; 7:TwOESDMR1tMi+5Xd5RgfRacllyQTLXRlpmErmHhqxvpeKLbDJxiPbnrhqTXzgUq5obDsCZb02Y/FZRXRdwS47iL0f7v9SzTpPbxv+xIqpUwm1Ah0uPOz8trXQyjOIxe9TeLxlDvZ5rBJSWnL8vUzC89v2Vw6yp3zETUH+JxlE0n7pZLC8N+0ExjESK0Iuwv1E1R9Rs7QsPtFjrpFYAj7rLUNjWED29ibGnzdAvJF150HYrcIpiMQUdzzcnsapfWy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2018 09:43:53.6755 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8670d55c-4fa4-4fdb-4e8e-08d56633a550 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3207 Subject: [dpdk-dev] [PATCH v2] net/mlx4: fix no bcast rcv in promisc and allmulti X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jan 2018 09:43:56 -0000 This patch fixes the issue of mlx4 not receiving broadcast packets when configured to work promiscuous or allmulticast modes. Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support") Cc: stable@dpdk.org Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_flow.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index fb84060..2c67105 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -1223,9 +1223,12 @@ struct mlx4_drop { * * Various flow rules are created depending on the mode the device is in: * - * 1. Promiscuous: port MAC + catch-all (VLAN filtering is ignored). - * 2. All multicast: port MAC/VLAN + catch-all multicast. - * 3. Otherwise: port MAC/VLAN + broadcast MAC/VLAN. + * 1. Promiscuous: + * port MAC + broadcast + catch-all (VLAN filtering is ignored). + * 2. All multicast: + * port MAC/VLAN + broadcast + catch-all multicast. + * 3. Otherwise: + * port MAC/VLAN + broadcast MAC/VLAN. * * About MAC flow rules: * @@ -1305,9 +1308,6 @@ struct mlx4_drop { !priv->dev->data->promiscuous ? &vlan_spec.tci : NULL; - int broadcast = - !priv->dev->data->promiscuous && - !priv->dev->data->all_multicast; uint16_t vlan = 0; struct rte_flow *flow; unsigned int i; @@ -1341,7 +1341,7 @@ struct mlx4_drop { rule_vlan = NULL; } } - for (i = 0; i != RTE_DIM(priv->mac) + broadcast; ++i) { + for (i = 0; i != RTE_DIM(priv->mac) + 1; ++i) { const struct ether_addr *mac; /* Broadcasts are handled by an extra iteration. */ @@ -1405,7 +1405,7 @@ struct mlx4_drop { goto next_vlan; } /* Take care of promiscuous and all multicast flow rules. */ - if (!broadcast) { + if (priv->dev->data->promiscuous || priv->dev->data->all_multicast) { for (flow = LIST_FIRST(&priv->flows); flow && flow->internal; flow = LIST_NEXT(flow, next)) { -- 1.8.3.1