DPDK patches and discussions
 help / color / mirror / Atom feed
From: Harry van Haaren <harry.van.haaren@intel.com>
To: dev@dpdk.org
Cc: Harry van Haaren <harry.van.haaren@intel.com>,
	thomas@monjalon.net, vipin.varghese@intel.com
Subject: [dpdk-dev] [PATCH v2 3/4] app/pdump: call eal finalize before exit
Date: Mon, 29 Jan 2018 10:45:50 +0000	[thread overview]
Message-ID: <1517222751-110376-3-git-send-email-harry.van.haaren@intel.com> (raw)
In-Reply-To: <1517222751-110376-1-git-send-email-harry.van.haaren@intel.com>

This patch adds a call to the newly introduced finalize()
function just before quitting the pdump app.

Adding this function call before quitting from a secondary processes
is important, as otherwise it will leak hugepage memory. For a secondary
process that is run multiple times, this could cause hugepage memory
to become depleted and stop a secondary process from starting.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

---

Cc: thomas@monjalon.net
Cc: vipin.varghese@intel.com
---
 app/pdump/main.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 0f70c75..6c58cda 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -882,5 +882,10 @@ main(int argc, char **argv)
 	/* dump debug stats */
 	print_pdump_stats();
 
+	ret = rte_eal_finalize();
+	if (ret)
+		printf("Error from rte_eal_finalize(), %d\n", ret);
+
+
 	return 0;
 }
-- 
2.7.4

  parent reply	other threads:[~2018-01-29 10:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-27 18:31 [dpdk-dev] [PATCH 1/4] service: move finalize to internal Harry van Haaren
2018-01-27 18:31 ` [dpdk-dev] [PATCH 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-27 18:31 ` [dpdk-dev] [PATCH 3/4] app/pdump: call eal finalize before exit Harry van Haaren
2018-01-27 18:31 ` [dpdk-dev] [PATCH 4/4] app/proc_info: " Harry van Haaren
2018-01-29 10:45 ` [dpdk-dev] [PATCH v2 1/4] service: move finalize to internal Harry van Haaren
2018-01-29 10:45   ` [dpdk-dev] [PATCH v2 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 10:55     ` Thomas Monjalon
2018-01-29 11:10       ` Van Haaren, Harry
2018-01-29 11:55         ` Thomas Monjalon
2018-01-29 12:04           ` Bruce Richardson
2018-01-29 12:12           ` Van Haaren, Harry
2018-01-29 10:45   ` Harry van Haaren [this message]
2018-01-29 10:45   ` [dpdk-dev] [PATCH v2 4/4] app/proc_info: call eal finalize before exit Harry van Haaren
2018-01-29 12:08   ` [dpdk-dev] [PATCH v3 1/4] service: move finalize to internal Harry van Haaren
2018-01-29 12:08     ` [dpdk-dev] [PATCH v3 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 15:07       ` Varghese, Vipin
2018-01-29 12:08     ` [dpdk-dev] [PATCH v3 3/4] app/pdump: call eal cleanup before exit Harry van Haaren
2018-01-29 15:09       ` Varghese, Vipin
2018-01-29 12:08     ` [dpdk-dev] [PATCH v3 4/4] app/proc_info: " Harry van Haaren
2018-01-29 15:09       ` Varghese, Vipin
2018-01-29 15:05     ` [dpdk-dev] [PATCH v3 1/4] service: move finalize to internal Varghese, Vipin
2018-01-29 16:00     ` [dpdk-dev] [PATCH v4 " Harry van Haaren
2018-01-29 16:00       ` [dpdk-dev] [PATCH v4 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 16:00       ` [dpdk-dev] [PATCH v4 3/4] app/pdump: call eal cleanup before exit Harry van Haaren
2018-01-29 16:00       ` [dpdk-dev] [PATCH v4 4/4] app/proc_info: " Harry van Haaren
2018-01-29 16:37       ` [dpdk-dev] [PATCH v5 1/4] service: move finalize to internal Harry van Haaren
2018-01-29 16:37         ` [dpdk-dev] [PATCH v5 2/4] eal: add function to release internal resources Harry van Haaren
2018-01-29 18:20           ` Thomas Monjalon
2018-01-29 16:37         ` [dpdk-dev] [PATCH v5 3/4] app/pdump: call eal cleanup before exit Harry van Haaren
2018-01-29 16:37         ` [dpdk-dev] [PATCH v5 4/4] app/proc_info: " Harry van Haaren
2018-01-29 18:28         ` [dpdk-dev] [PATCH v5 1/4] service: move finalize to internal Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517222751-110376-3-git-send-email-harry.van.haaren@intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).