Re: [dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD

[Thomas Monjalon <thomas.monjalon@6wind.com>]

> > This series includes:
> >    - Fix the "issue" introduced in 01fa1d6215fa7cd6b5303ac9296381b75b9226de:
> >      files in librte_pmd_ixgbe/ixgbe/ are shared with FreeBSD and AFAIU should not
> >      be changed unless the change is pushed into the FreeBSD tree first.
> >    - Remove unused rsc_en field in ixgbe_rx_queue struct.
> >      Thanks to Shiweixian <shiweixian@huawei.com> for pointing this out.
> >    - Kill the non-vector scattered Rx callback and use an appropriate LRO callback
> >      instead. This is possible because work against HW in both LRO and scattered RX
> >      cases is the same. Note that this patch touches the ixgbevf PMD as well.
> >    - Use LRO bulk callback when scattered (non-LRO) Rx is requested and parameters
> >      allow bulk allocation.
> > 
> > Note that this series is meant to cleanup the PF PMD and is a follow up series for my
> > previous patches. Although VF PMD is slightly modified here too this series doesn't mean
> > to fix/add new functionality to it. VF PMD should be patched in the similar way I've
> > patched PF PMD in my previous series in order to fix the same issues that were fixed in
> > the PF PMD and in order to enable LRO and scattered Rx with bulk allocations.
> > 
> > New in v2:
> >    - Rename RSC-specific structures to "Scattered Rx" derivatives.
> >    - Always allocate Scattered Rx ring.
> > 
> > Vlad Zolotarov (5):
> >   ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter
> >   ixgbe: ixgbe_rx_queue: remove unused rsc_en field
> >   ixgbe: Rename yy_rsc_xx -> yy_sc/scattered_rx_xx
> >   ixgbe: Kill ixgbe_recv_scattered_pkts()
> >   ixgbe: Add support for scattered Rx with bulk allocation.
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Thanks a lot for doing it.

Applied, thanks