From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id EB1CC12A8 for ; Thu, 7 May 2015 19:25:44 +0200 (CEST) Received: by wgyo15 with SMTP id o15so50542500wgy.2 for ; Thu, 07 May 2015 10:25:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=9qZPDb5A5Onx6pK1WLSvFrbzQYMuQthi9CyK6LmJJn0=; b=XvF5KF06ACUv1HErxQwf45HkVjpCW2s742y+MRs+iDkgfYVbDWgeiLtt1jvXjM3rhe eHTWCRsgZZR4CyM+Zco49/4afsa7kJbUZ7DARw1sqOGtdmWbhxniK6lzfzAwJBxD0Psn +06lJ0RjgQ87k334KEMsuNe00UXTNQkLsu494JGwaE+VRlnyJKCPQcAYqQz7/7WMZxaw DVQO23BGiO8h09UbVbS97p4hRvz3ytRPBofuykAtH6KZ+cvHkjEH37IZXEDsEohFoyjT jUAdXoEJCDhtfsPpoGI8MxNUKLxlmq4Oc6V6Ewy10IVAIcM1uLVKyP8vQSJZZmBoXPWW qnZA== X-Gm-Message-State: ALoCoQm2KEHE3hD94MfA0/jO3iR7QdFGaR8OfoKK5WfvNxEAlf2pRmVhijHj8lJDUVK7H02ovbHp X-Received: by 10.180.101.65 with SMTP id fe1mr8583371wib.22.1431019544813; Thu, 07 May 2015 10:25:44 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id o6sm8409549wiz.24.2015.05.07.10.25.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 10:25:43 -0700 (PDT) From: Thomas Monjalon To: Vlad Zolotarov Date: Thu, 07 May 2015 19:25:02 +0200 Message-ID: <1517243.9KvEt0E09c@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/3.19.3-3-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725821422676@irsmsx105.ger.corp.intel.com> References: <1430296697-32650-1-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB97725821422676@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2015 17:25:45 -0000 > > This series includes: > > - Fix the "issue" introduced in 01fa1d6215fa7cd6b5303ac9296381b75b9226de: > > files in librte_pmd_ixgbe/ixgbe/ are shared with FreeBSD and AFAIU should not > > be changed unless the change is pushed into the FreeBSD tree first. > > - Remove unused rsc_en field in ixgbe_rx_queue struct. > > Thanks to Shiweixian for pointing this out. > > - Kill the non-vector scattered Rx callback and use an appropriate LRO callback > > instead. This is possible because work against HW in both LRO and scattered RX > > cases is the same. Note that this patch touches the ixgbevf PMD as well. > > - Use LRO bulk callback when scattered (non-LRO) Rx is requested and parameters > > allow bulk allocation. > > > > Note that this series is meant to cleanup the PF PMD and is a follow up series for my > > previous patches. Although VF PMD is slightly modified here too this series doesn't mean > > to fix/add new functionality to it. VF PMD should be patched in the similar way I've > > patched PF PMD in my previous series in order to fix the same issues that were fixed in > > the PF PMD and in order to enable LRO and scattered Rx with bulk allocations. > > > > New in v2: > > - Rename RSC-specific structures to "Scattered Rx" derivatives. > > - Always allocate Scattered Rx ring. > > > > Vlad Zolotarov (5): > > ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter > > ixgbe: ixgbe_rx_queue: remove unused rsc_en field > > ixgbe: Rename yy_rsc_xx -> yy_sc/scattered_rx_xx > > ixgbe: Kill ixgbe_recv_scattered_pkts() > > ixgbe: Add support for scattered Rx with bulk allocation. > > Acked-by: Konstantin Ananyev > Thanks a lot for doing it. Applied, thanks