From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AA1B51B824 for ; Mon, 29 Jan 2018 17:37:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 08:37:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,431,1511856000"; d="scan'208";a="15245395" Received: from silpixa00398672.ir.intel.com ([10.237.223.111]) by fmsmga002.fm.intel.com with ESMTP; 29 Jan 2018 08:37:37 -0800 From: Harry van Haaren To: dev@dpdk.org Cc: Harry van Haaren , thomas@monjalon.net, vipin.varghese@intel.com Date: Mon, 29 Jan 2018 16:37:31 +0000 Message-Id: <1517243852-34142-3-git-send-email-harry.van.haaren@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517243852-34142-1-git-send-email-harry.van.haaren@intel.com> References: <1517241642-161397-1-git-send-email-harry.van.haaren@intel.com> <1517243852-34142-1-git-send-email-harry.van.haaren@intel.com> Subject: [dpdk-dev] [PATCH v5 3/4] app/pdump: call eal cleanup before exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 16:37:40 -0000 This patch adds a call to the newly introduced cleanup() function just before quitting the pdump app. Adding this function call before quitting from a secondary processes is important, as otherwise it will leak hugepage memory. For a secondary process that is run multiple times, this could cause hugepage memory to become depleted and stop a secondary process from starting. Signed-off-by: Harry van Haaren Acked-by: Vipin Varghese --- v4: - Include Ack v3: - Rework to new cleanup() function name (Thomas) Cc: thomas@monjalon.net Cc: vipin.varghese@intel.com --- app/pdump/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 0f70c75..50772cb 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -882,5 +882,10 @@ main(int argc, char **argv) /* dump debug stats */ print_pdump_stats(); + ret = rte_eal_cleanup(); + if (ret) + printf("Error from rte_eal_cleanup(), %d\n", ret); + + return 0; } -- 2.7.4