* [dpdk-dev] [PATCH] net/avf: fix unchecked return value issue
@ 2018-01-30 5:56 Jingjing Wu
0 siblings, 0 replies; 3+ messages in thread
From: Jingjing Wu @ 2018-01-30 5:56 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: jingjing.wu, dev
This patch fixes the coverity CHECKED_RETURN issue.
Coverity issue: 257045
Fixes: 48de41ca11f0 ("net/avf: enable link status update")
Reported-by: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/avf/avf_ethdev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index cf7bbb2..511715f 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -609,9 +609,10 @@ avf_dev_link_update(struct rte_eth_dev *dev,
new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds &
ETH_LINK_SPEED_FIXED);
- rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,
- *(uint64_t *)&dev->data->dev_link,
- *(uint64_t *)&new_link);
+ if(rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,
+ *(uint64_t *)&dev->data->dev_link,
+ *(uint64_t *)&new_link) == 0)
+ return -1;
return 0;
}
--
2.4.11
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/avf: fix unchecked return value issue
2018-01-30 9:10 Jingjing Wu
@ 2018-01-31 19:20 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-31 19:20 UTC (permalink / raw)
To: Jingjing Wu, wenzhuo.lu; +Cc: dev
On 1/30/2018 9:10 AM, Jingjing Wu wrote:
> This patch fixes the coverity CHECKED_RETURN issue.
>
> Coverity issue: 257045
> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
>
> Reported-by: John McNamara <john.mcnamara@intel.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH] net/avf: fix unchecked return value issue
@ 2018-01-30 9:10 Jingjing Wu
2018-01-31 19:20 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2018-01-30 9:10 UTC (permalink / raw)
To: wenzhuo.lu; +Cc: jingjing.wu, dev
This patch fixes the coverity CHECKED_RETURN issue.
Coverity issue: 257045
Fixes: 48de41ca11f0 ("net/avf: enable link status update")
Reported-by: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/avf/avf_ethdev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index cf7bbb2..3009f5d 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -609,9 +609,10 @@ avf_dev_link_update(struct rte_eth_dev *dev,
new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds &
ETH_LINK_SPEED_FIXED);
- rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,
- *(uint64_t *)&dev->data->dev_link,
- *(uint64_t *)&new_link);
+ if (rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link,
+ *(uint64_t *)&dev->data->dev_link,
+ *(uint64_t *)&new_link) == 0)
+ return -1;
return 0;
}
--
2.4.11
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-31 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30 5:56 [dpdk-dev] [PATCH] net/avf: fix unchecked return value issue Jingjing Wu
2018-01-30 9:10 Jingjing Wu
2018-01-31 19:20 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).