* [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit
@ 2018-01-31 8:48 longtb5
2018-02-06 18:03 ` Singh, Jasvinder
0 siblings, 1 reply; 3+ messages in thread
From: longtb5 @ 2018-01-31 8:48 UTC (permalink / raw)
To: cristian.dumitrescu; +Cc: dev, longtb5
The timer_period option specified by users via config file
should have unit of 1 millisecond. However timer_period is
internally converted to unit of 10 millisecond.
Fixes: 4e14069328fc ("examples/ip_pipeline: measure CPU utilization")
Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
---
examples/ip_pipeline/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c
index 55d246f..bb07efa 100644
--- a/examples/ip_pipeline/init.c
+++ b/examples/ip_pipeline/init.c
@@ -1704,7 +1704,7 @@ app_init_pipelines(struct app_params *app)
data->ptype = ptype;
data->timer_period = (rte_get_tsc_hz() *
- params->timer_period) / 100;
+ params->timer_period) / 1000;
}
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit
2018-01-31 8:48 [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit longtb5
@ 2018-02-06 18:03 ` Singh, Jasvinder
2018-02-06 18:45 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Singh, Jasvinder @ 2018-02-06 18:03 UTC (permalink / raw)
To: longtb5, Dumitrescu, Cristian; +Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> longtb5@viettel.com.vn
> Sent: Wednesday, January 31, 2018 8:48 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; longtb5 <longtb5@viettel.com.vn>
> Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit
>
> The timer_period option specified by users via config file should have unit of
> 1 millisecond. However timer_period is internally converted to unit of 10
> millisecond.
>
> Fixes: 4e14069328fc ("examples/ip_pipeline: measure CPU utilization")
>
> Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
> ---
> examples/ip_pipeline/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c index
> 55d246f..bb07efa 100644
> --- a/examples/ip_pipeline/init.c
> +++ b/examples/ip_pipeline/init.c
> @@ -1704,7 +1704,7 @@ app_init_pipelines(struct app_params *app)
> data->ptype = ptype;
>
> data->timer_period = (rte_get_tsc_hz() *
> - params->timer_period) / 100;
> + params->timer_period) / 1000;
> }
> }
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit
2018-02-06 18:03 ` Singh, Jasvinder
@ 2018-02-06 18:45 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-02-06 18:45 UTC (permalink / raw)
To: longtb5; +Cc: dev, Singh, Jasvinder, Dumitrescu, Cristian, stable
> > The timer_period option specified by users via config file should have unit of
> > 1 millisecond. However timer_period is internally converted to unit of 10
> > millisecond.
> >
> > Fixes: 4e14069328fc ("examples/ip_pipeline: measure CPU utilization")
Cc: stable@dpdk.org
> > Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
>
> Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-06 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 8:48 [dpdk-dev] [PATCH] examples/ip_pipeline: fix timer_period unit longtb5
2018-02-06 18:03 ` Singh, Jasvinder
2018-02-06 18:45 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).