DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default
@ 2018-01-23  8:11 Moti Haimovsky
  2018-01-25  1:11 ` Lu, Wenzhuo
  2018-01-29 11:33 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
  0 siblings, 2 replies; 21+ messages in thread
From: Moti Haimovsky @ 2018-01-23  8:11 UTC (permalink / raw)
  To: wenzhuo.lu, thomas; +Cc: dev, Moti Haimovsky

Removed the hardcoded preconfigured Rx offload configuration from
testpmd.
Testers who wish to use these offloads will now have to explicitly
write them in the command-line when running testpmd.

Motivation:
Some PMDs such at the mlx4 may not implement all the offloads.
After the offload API rework assuming no offload is enabled by default,
  commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
  commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying
to enable a not supported offload is clearly an error which will cause
configuration failing.

Considering that testpmd is an application to test the PMD, it should
not fail on a configuration which was not explicitly requested.
The behavior of this test application is then turned to an opt-in
model.

Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
 app/test-pmd/testpmd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5dc8cca..a082352 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = {
  */
 struct rte_eth_rxmode rx_mode = {
 	.max_rx_pkt_len = ETHER_MAX_LEN, /**< Default maximum frame length. */
-	.offloads = (DEV_RX_OFFLOAD_VLAN_FILTER |
-		     DEV_RX_OFFLOAD_VLAN_STRIP |
-		     DEV_RX_OFFLOAD_CRC_STRIP),
+	.offloads = 0,
 	.ignore_offload_bitfield = 1,
 };
 
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2018-01-31 21:10 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23  8:11 [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default Moti Haimovsky
2018-01-25  1:11 ` Lu, Wenzhuo
2018-01-25  9:04   ` Thomas Monjalon
2018-01-25 16:01     ` Stephen Hemminger
2018-01-26  7:31       ` Lu, Wenzhuo
2018-01-26  7:49         ` Thomas Monjalon
2018-01-26  7:30     ` Lu, Wenzhuo
2018-01-26  7:48       ` Thomas Monjalon
2018-01-26  8:06         ` Lu, Wenzhuo
2018-01-26  8:35           ` Thomas Monjalon
2018-01-27 18:14             ` Shahaf Shuler
2018-01-29 11:33 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
2018-01-29 11:52   ` Thomas Monjalon
2018-01-30  8:44   ` [dpdk-dev] [PATCH v3] " Moti Haimovsky
2018-01-30  9:00     ` [dpdk-dev] [PATCH v4] " Moti Haimovsky
2018-01-31  3:16       ` Lu, Wenzhuo
2018-01-31 11:55       ` [dpdk-dev] [PATCH v5] " Moti Haimovsky
2018-01-31 16:59         ` [dpdk-dev] [PATCH v6] app/testpmd: no Rx or Tx " Moti Haimovsky
2018-01-31 17:19           ` Thomas Monjalon
2018-01-31 17:32           ` [dpdk-dev] [PATCH v7] app/testpmd: removed preconf Rx VLAN offloads Moti Haimovsky
2018-01-31 21:09             ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).