From: Amr Mokhtar <amr.mokhtar@intel.com>
To: dev@dpdk.org
Cc: Amr Mokhtar <amr.mokhtar@intel.com>
Subject: [dpdk-dev] [PATCH] examples/bbdev: fix memory leak
Date: Wed, 31 Jan 2018 14:30:29 +0000 [thread overview]
Message-ID: <1517409029-131237-1-git-send-email-amr.mokhtar@intel.com> (raw)
xstats and xstats_names buffers were allocated for
the purpose of printing eth_xstats, but were not
freed before exit.
A fix is added to free before exit points.
Coverity issue: 257013
Fixes: 1ffee690eaa1 ("examples/bbdev: add sample app")
Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
---
examples/bbdev_app/main.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c
index 2e5bd8c..ef0ca25 100644
--- a/examples/bbdev_app/main.c
+++ b/examples/bbdev_app/main.c
@@ -585,21 +585,28 @@ print_stats(struct stats_lcore_params *stats_lcore)
"Failed to calloc memory for xstats");
ret = rte_eth_xstats_get(port_id, xstats, len);
- if (ret < 0 || ret > len)
+ if (ret < 0 || ret > len) {
+ free(xstats);
rte_exit(EXIT_FAILURE,
"rte_eth_xstats_get(%u) len%i failed: %d",
port_id, len, ret);
+ }
xstats_names = calloc(len, sizeof(*xstats_names));
- if (xstats_names == NULL)
+ if (xstats_names == NULL) {
+ free(xstats);
rte_exit(EXIT_FAILURE,
"Failed to calloc memory for xstats_names");
+ }
ret = rte_eth_xstats_get_names(port_id, xstats_names, len);
- if (ret < 0 || ret > len)
+ if (ret < 0 || ret > len) {
+ free(xstats);
+ free(xstats_names);
rte_exit(EXIT_FAILURE,
"rte_eth_xstats_get_names(%u) len%i failed: %d",
port_id, len, ret);
+ }
for (i = 0; i < len; i++) {
if (xstats[i].value > 0)
@@ -630,6 +637,9 @@ print_stats(struct stats_lcore_params *stats_lcore)
continue;
print_lcore_stats(stats_lcore->lconf[l_id].lcore_stats, l_id);
}
+
+ free(xstats);
+ free(xstats_names);
}
static int
--
2.7.4
next reply other threads:[~2018-01-31 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 14:30 Amr Mokhtar [this message]
2018-01-31 17:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517409029-131237-1-git-send-email-amr.mokhtar@intel.com \
--to=amr.mokhtar@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).