From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Nikhil Jagtap <nikhil.jagtap@gmail.com>
Cc: dev@dpdk.org, "Dumitrescu,
Cristian" <cristian.dumitrescu@intel.com>,
"Ramia, Kannan Babu" <kannan.babu.ramia@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] meter: fix excess token bucket update in srtcm implementation
Date: Wed, 21 Sep 2016 23:19:04 +0200 [thread overview]
Message-ID: <1517417.ujR0TQTeQH@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A85CB4@IRSMSX108.ger.corp.intel.com>
> > As per srTCM RFC 2697, we should be updating the E bucket only after the
> > C bucket overflows. This patch fixes the current DPDK implementation,
> > where we are updating both the buckets simultaneously at the same rate
> > (CIR) which results in token accumulation rate of (2*CIR).
> >
> > Signed-off-by: Nikhil Jagtap <nikhil.jagtap@gmail.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-09-21 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 6:15 [dpdk-dev] [PATCH] " Nikhil Jagtap
2016-09-19 15:51 ` Dumitrescu, Cristian
2016-09-20 4:40 ` Nikhil Jagtap
2016-09-21 5:57 ` [dpdk-dev] [PATCH v2] " Nikhil Jagtap
2016-09-21 8:57 ` Dumitrescu, Cristian
2016-09-21 21:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517417.ujR0TQTeQH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=kannan.babu.ramia@intel.com \
--cc=nikhil.jagtap@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).