* Re: [dpdk-dev] [PATCH] net/null: add set MAC address dev op
2018-01-29 14:20 [dpdk-dev] [PATCH] net/null: add set MAC address dev op Radu Nicolau
@ 2018-01-31 19:18 ` Ferruh Yigit
2018-02-01 10:42 ` [dpdk-dev] [PATCH 1/3] " Radu Nicolau
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2018-01-31 19:18 UTC (permalink / raw)
To: Radu Nicolau, dev; +Cc: mtetsuyah, declan.doherty
On 1/29/2018 2:20 PM, Radu Nicolau wrote:
> Needed if used with net/bonding
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> drivers/net/null/rte_eth_null.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index 7cd5c71..511e2b7 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -456,6 +456,12 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev,
> return 0;
> }
>
> +static void
> +eth_mac_address_set(struct rte_eth_dev *dev, struct ether_addr *addr)
> +{
> + memcpy(dev->data->mac_addrs, addr, sizeof(struct ether_addr));
This copy already done in ethdev layer, an empty function will do the work.
> +}
> +
> static const struct eth_dev_ops ops = {
> .dev_start = eth_dev_start,
> .dev_stop = eth_dev_stop,
> @@ -466,6 +472,7 @@ static const struct eth_dev_ops ops = {
> .rx_queue_release = eth_queue_release,
> .tx_queue_release = eth_queue_release,
> .link_update = eth_link_update,
> + .mac_addr_set = eth_mac_address_set,
> .stats_get = eth_stats_get,
> .stats_reset = eth_stats_reset,
> .reta_update = eth_rss_reta_update,
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH 1/3] net/null: add set MAC address dev op
2018-01-29 14:20 [dpdk-dev] [PATCH] net/null: add set MAC address dev op Radu Nicolau
2018-01-31 19:18 ` Ferruh Yigit
@ 2018-02-01 10:42 ` Radu Nicolau
2018-02-01 10:45 ` Radu Nicolau
2018-02-01 10:47 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
3 siblings, 0 replies; 7+ messages in thread
From: Radu Nicolau @ 2018-02-01 10:42 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, declan.doherty, mtetsuyah, Radu Nicolau
Needed if used with net/bonding
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: remove redundant memcpy
drivers/net/null/rte_eth_null.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 9385ffd..d003b28 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -461,6 +461,12 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev,
return 0;
}
+static void
+eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
+ __rte_unused struct ether_addr *addr)
+{
+}
+
static const struct eth_dev_ops ops = {
.dev_start = eth_dev_start,
.dev_stop = eth_dev_stop,
@@ -472,6 +478,7 @@ static const struct eth_dev_ops ops = {
.tx_queue_release = eth_queue_release,
.mtu_set = eth_mtu_set,
.link_update = eth_link_update,
+ .mac_addr_set = eth_mac_address_set,
.stats_get = eth_stats_get,
.stats_reset = eth_stats_reset,
.reta_update = eth_rss_reta_update,
--
2.7.5
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH 1/3] net/null: add set MAC address dev op
2018-01-29 14:20 [dpdk-dev] [PATCH] net/null: add set MAC address dev op Radu Nicolau
2018-01-31 19:18 ` Ferruh Yigit
2018-02-01 10:42 ` [dpdk-dev] [PATCH 1/3] " Radu Nicolau
@ 2018-02-01 10:45 ` Radu Nicolau
2018-02-01 10:47 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
3 siblings, 0 replies; 7+ messages in thread
From: Radu Nicolau @ 2018-02-01 10:45 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, declan.doherty, mtetsuyah, Radu Nicolau
Needed if used with net/bonding
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: remove redundant memcpy
drivers/net/null/rte_eth_null.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 9385ffd..d003b28 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -461,6 +461,12 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev,
return 0;
}
+static void
+eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
+ __rte_unused struct ether_addr *addr)
+{
+}
+
static const struct eth_dev_ops ops = {
.dev_start = eth_dev_start,
.dev_stop = eth_dev_stop,
@@ -472,6 +478,7 @@ static const struct eth_dev_ops ops = {
.tx_queue_release = eth_queue_release,
.mtu_set = eth_mtu_set,
.link_update = eth_link_update,
+ .mac_addr_set = eth_mac_address_set,
.stats_get = eth_stats_get,
.stats_reset = eth_stats_reset,
.reta_update = eth_rss_reta_update,
--
2.7.5
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v2] net/null: add set MAC address dev op
2018-01-29 14:20 [dpdk-dev] [PATCH] net/null: add set MAC address dev op Radu Nicolau
` (2 preceding siblings ...)
2018-02-01 10:45 ` Radu Nicolau
@ 2018-02-01 10:47 ` Radu Nicolau
2018-02-05 14:40 ` Ferruh Yigit
3 siblings, 1 reply; 7+ messages in thread
From: Radu Nicolau @ 2018-02-01 10:47 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, declan.doherty, mtetsuyah, Radu Nicolau
Needed if used with net/bonding
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2: remove redundant memcpy
drivers/net/null/rte_eth_null.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 9385ffd..d003b28 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -461,6 +461,12 @@ eth_rss_hash_conf_get(struct rte_eth_dev *dev,
return 0;
}
+static void
+eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
+ __rte_unused struct ether_addr *addr)
+{
+}
+
static const struct eth_dev_ops ops = {
.dev_start = eth_dev_start,
.dev_stop = eth_dev_stop,
@@ -472,6 +478,7 @@ static const struct eth_dev_ops ops = {
.tx_queue_release = eth_queue_release,
.mtu_set = eth_mtu_set,
.link_update = eth_link_update,
+ .mac_addr_set = eth_mac_address_set,
.stats_get = eth_stats_get,
.stats_reset = eth_stats_reset,
.reta_update = eth_rss_reta_update,
--
2.7.5
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/null: add set MAC address dev op
2018-02-01 10:47 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
@ 2018-02-05 14:40 ` Ferruh Yigit
2018-02-05 14:46 ` Ferruh Yigit
0 siblings, 1 reply; 7+ messages in thread
From: Ferruh Yigit @ 2018-02-05 14:40 UTC (permalink / raw)
To: Radu Nicolau, dev; +Cc: declan.doherty, mtetsuyah
On 2/1/2018 10:47 AM, Radu Nicolau wrote:
> Needed if used with net/bonding
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/null: add set MAC address dev op
2018-02-05 14:40 ` Ferruh Yigit
@ 2018-02-05 14:46 ` Ferruh Yigit
0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2018-02-05 14:46 UTC (permalink / raw)
To: Radu Nicolau, dev; +Cc: declan.doherty, mtetsuyah
On 2/5/2018 2:40 PM, Ferruh Yigit wrote:
> On 2/1/2018 10:47 AM, Radu Nicolau wrote:
>> Needed if used with net/bonding
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread