DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: olivier.matz@6wind.com, thomas@monjalon.net,
	pbhagavatula@caviumnetworks.com
Cc: nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com,
	santosh.shukla@caviumnetworks.com, dev@dpdk.org,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: [dpdk-dev] [PATCH FIX-OPTION-2 2/2] mbuf: fix user mempool ops get to use only named memzone
Date: Fri,  2 Feb 2018 13:33:02 +0530	[thread overview]
Message-ID: <1517558582-27108-3-git-send-email-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com>

The eal default mempool ops API can also return the compile
time default mempool ops name, which can break the best mempool
ops name logic.

Fixes: a3acc3144a76 ("mbuf: add pool ops selection functions")

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 lib/librte_mbuf/rte_mbuf_pool_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_mbuf/rte_mbuf_pool_ops.c b/lib/librte_mbuf/rte_mbuf_pool_ops.c
index 385fc43..a636c28 100644
--- a/lib/librte_mbuf/rte_mbuf_pool_ops.c
+++ b/lib/librte_mbuf/rte_mbuf_pool_ops.c
@@ -74,7 +74,7 @@ rte_mbuf_user_mempool_ops(void)
 
 	mz = rte_memzone_lookup("mbuf_user_pool_ops");
 	if (mz == NULL)
-		return rte_eal_mbuf_default_mempool_ops();
+		return NULL;
 	return mz->addr;
 }
 
-- 
2.7.4

  parent reply	other threads:[~2018-02-02  8:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 19:47 [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Hemant Agrawal
2018-02-01 19:47 ` [dpdk-dev] [PATCH 2/2] test: use the best mempool ops API to get mbuf pool Hemant Agrawal
2018-02-01 19:56 ` [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Hemant Agrawal
2018-02-01 20:40   ` Pavan Nikhilesh
2018-02-02  5:43     ` Hemant Agrawal
2018-02-02  8:03 ` [dpdk-dev] [PATCH FIX-OPTION-2 1/2] eal: use named memzone to store user mempool ops name Hemant Agrawal
2018-02-02  8:03   ` [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Hemant Agrawal
2018-02-02 13:40     ` Olivier Matz
2018-02-02 13:47       ` Hemant Agrawal
2018-02-06  0:05       ` Thomas Monjalon
     [not found]     ` <BY1PR0701MB1895B37B913A223180EED6D3EAFF0@BY1PR0701MB1895.namprd07.prod.outlook.com>
2018-02-04  6:34       ` [dpdk-dev] Fw: " santosh
2018-02-04 10:27         ` [dpdk-dev] " Hemant Agrawal
2018-02-02  8:03   ` Hemant Agrawal [this message]
2018-02-02  8:03 ` [dpdk-dev] [PATCH] doc: remove eal API for default mempool ops name Hemant Agrawal
2018-02-02  8:31   ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2018-02-02 14:01     ` Olivier Matz
2018-02-13 11:28       ` Ferruh Yigit
2018-02-14 14:58         ` Thomas Monjalon
2018-02-03 13:28     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517558582-27108-3-git-send-email-hemant.agrawal@nxp.com \
    --to=hemant.agrawal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nipun.gupta@nxp.com \
    --cc=olivier.matz@6wind.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).