From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 4A2C0C4A8
 for <dev@dpdk.org>; Thu, 30 Jul 2015 00:34:19 +0200 (CEST)
Received: by wibxm9 with SMTP id xm9so220479539wib.0
 for <dev@dpdk.org>; Wed, 29 Jul 2015 15:34:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=JrgrnVy4F+xdCSewVvjamU4bqYLr2b6ULlAuS5ZptVA=;
 b=BG0ttC9dL0vI6T6yxhgvbU0LIhJmWdHAitMj940wCE+7OyOIIcCo9iHmciz9bksNVm
 XRgYdYJE3j8wNBLUjA7y/fFrAivPwSFZScKidzW8TljFIYjbOnrkYxeQgIw9eMTXqRgp
 2yoQzm31s3IgJfSXClJX0nb6vqLKCQCe9g9qxS1bxEmAtDIfzbYrvNku7aeXMlqvnKNx
 ENsHbDjgwV+FX+05dmrmLcCMvdq8g8EQLEMBKQMSfc8SxGnqXjA+HKTCIF8X6/8OvSPI
 9T7UgOb0WIJuySjPN5CvRVElwhCnA2lZje7dADG/ptfYDLjLVYC3/tao19yanuSq1Kj5
 05rA==
X-Gm-Message-State: ALoCoQmt3Q6Rerv+CyD/pcn6DXLJihX5jyL7Qqq2U1sJX+yvVen5fSWRJjjQx9jf35UfFp1TEWIi
X-Received: by 10.194.97.196 with SMTP id ec4mr81433276wjb.3.1438209259150;
 Wed, 29 Jul 2015 15:34:19 -0700 (PDT)
Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.
 [82.235.116.147])
 by smtp.gmail.com with ESMTPSA id jz4sm40744763wjb.16.2015.07.29.15.34.17
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 29 Jul 2015 15:34:18 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Date: Thu, 30 Jul 2015 00:33:03 +0200
Message-ID: <1517577.ZUUS3DXQqZ@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1438131297-22750-1-git-send-email-jingjing.wu@intel.com>
References: <1438074060-13809-1-git-send-email-jingjing.wu@intel.com>
 <1438131297-22750-1-git-send-email-jingjing.wu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues on
	vf port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2015 22:34:19 -0000

> This patch fixes the issue:
> Testpmd crashed with Segmentation fault when setup tx queues on vf
> Steps for reproduce:
>   - create one vf device from i40e driver
>   - bind vf device to igb_uio and start testpmd
> 
> With debugging tools, we saw the struct i40e_vf is cleared after
> memcpy(&dev->data->dev_conf, dev_conf, sizeof(dev->data->dev_conf)) in
> rte_eth_dev_configure, which should not happen, and the pointer to
> i40e_vf isn't in the range of i40e_adapter.
> 
> The root cause is the dev_private_size in i40e virtual function driver struct
> rte_i40evf_pmd was set incorrectly.
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

Applied, thanks

Does it mean that Tx with i40evf never worked before?