From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0045.outbound.protection.outlook.com [104.47.0.45]) by dpdk.org (Postfix) with ESMTP id E29F91B3E8; Mon, 5 Feb 2018 17:02:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mj7p5fMD68lfl9UktknwMu8gvtG7JKjT5/mBGunWO0k=; b=u98raMZBz1IvQqRGYUN9WBvvyEAk+A6X6vWYPp4rhx2Yl8blf1WXKdw/iT5x5qk8Se8wjU12dUOmE0ehYI5fM/UwaG08+xRSNK9iVEC1prIxq9xqepIpKNMn12u+15WJMxImi2vu5zPTASCY9YzWnJjBuOQqMJ1zPGyv+lxX3Yg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3879.eurprd05.prod.outlook.com (2603:10a6:209:b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 16:02:15 +0000 From: Ophir Munk To: dev@dpdk.org, Gaetan Rivet Cc: Thomas Monjalon , Olga Shern , Ophir Munk , stable@dpdk.org Date: Mon, 5 Feb 2018 16:02:06 +0000 Message-Id: <1517846526-751-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0802CA0032.eurprd08.prod.outlook.com (2603:10a6:800:a9::18) To AM6PR0502MB3879.eurprd05.prod.outlook.com (2603:10a6:209:b::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 67579f14-0471-4541-0167-08d56cb1d43f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3879; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3879; 3:G6CyvnNXqprhFtjeqg6Vgi7xg6PejwyzryFeytyVeFoipEi1fCGGBiGZikQn6hYN7vDEOAriwd6hlL8Igg56/Bqf3CARpAodDzRHqtniGNJX4Vu2/F1mFghbnhw6azoADM5wggPYrPc9lQtEXGI+CrF8CvPvkBopGeb8T0tIDCTw6zAGcdZxTiS8QNCfRs9ONerX4XAzfVZQPnIY8J0LlIdRzKE1BUgArzXMzZ6REUfJ2LrVpdehAYjQKsLAg9gI; 25:pvM+JmhOzvCGxoPzawJQKaRm9+lERR0R6yozn7O5cwSfp8aMndyX2wCrO358dTtLnTFvrOlOI1lqR2SWmo5wDSjjL0amSK+JUAEfJFEHzSbDDF9VKdkH+MZ6sKr8QO7/Sr7/sPTfCgjEiozILSgl/F40OwRkOehiVZNiFqeu4165BFn4to3EgTJsg6wrYc+bm+uZ5479+rNvvCIp1VWsBKNzmqipP9a5RQEe61tIu5rS700LorfnXdhEAKYmnvCTwvBmFJFo9+4vz0BXMPcl2XCw5E+HrD9BBVL+4IUgPw9SCAX6qMmr0SolS/ZHDiA6eUJCu+4daBCneccBPjZUKA==; 31:u5ohplbctxazu266zZ4RrXd8QLk+kTHS1ijo0Gju+4lHf11ni5fCcgw1I8N22e5Ia7QqPM+dSAgqv5VBLKBJ06ZLoxB4B3ij4+wypYy516goZTaamI9KotwwyGDkRPFsHyD4+ZqKZJPSW/ttpPXiOh8115zezAI4y7HDihfV4o4nakJIkYq29g8ALKWz4wXXdPcWDDuvE/I+/PY1OXrVGKnkp5O99x60RBdtW4Xp6bk= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3879: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3879; 20:jwXVWmQIj8Cqa1EHay15Shqjz7N/sXj18i7EdyNaoB+5r9rnqE6XeHRCad3AfyAKAns+cIu0hGiyD6v/0ee5wW8zoOGyhKuxVdvESohEP2TQgKO8QPHRxHNLeh+R8Td/QRwq8rNBqIbWih2PPvBf/H9FNG8RtKj6fmvb3fwlobJoitqdjVJFS1grWcn3364CaEQz8wwGQrQB2ISH1t6CEc3XcAC+39nCJ85rN/svtELzNeU46iokdfLhIshh7ItuTMArvQe8TsMv/fqMQ/+dGKap3870SGpXgXokDJ3fzUcRmXqaYthf9qRQJItvlLDfgrbU7ICKKAGQ4TBZv9WSh1TzQa1IT03YyoSDimZsaytTWHyvzfOAwKY0D/sWUtH7pXeEGYGP2PSWcHdJ5BmM+LkxEXcaBzgGZEBiBZqwYe/7KLfdZwW/GcCM5c5U+Daq/UnDGmUk1IkdsLtv6TbsQ96ZynhDiXCeCIZJQfwcnqPoyEjO7G5ye3cF9lmWr9ET; 4:aMLqUUQ8uRTop/xB2vKm3dPou/7NYd7my0iahNebq1/TpxxkVWIUnwKsRkVr+fhHTRPLrFTn89Q2uAhD9yMOC7Bw8F+d/k5oTvJSgSQOuBmqDwjHozYNElWbgk2T0AeLwmXGt3Dbq/MhY65pTO/WOdtG+vJ86+TVgHbpyaztnatFnb/cZ5NVBBKPNTbo0Jwyi17ENKlX/DL8AGUneQS2TRJh60EmTwxHdDrXKhuNJbTA2X73u+7BsvTL7xhA/sC6no99N4kuTkyku4qKL1G5XA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231101)(2400082)(944501161)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM6PR0502MB3879; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0502MB3879; X-Forefront-PRVS: 0574D4712B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(39380400002)(39860400002)(366004)(189003)(199004)(8676002)(54906003)(86362001)(105586002)(106356001)(316002)(33026002)(81166006)(50226002)(8936002)(81156014)(16586007)(50466002)(48376002)(21086003)(36756003)(4720700003)(53936002)(47776003)(6916009)(6666003)(68736007)(26005)(3846002)(6116002)(55016002)(5660300001)(59450400001)(66066001)(16526019)(186003)(69596002)(305945005)(25786009)(4326008)(7736002)(386003)(7696005)(51416003)(478600001)(2906002)(52116002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3879; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3879; 23:b/alu0D9NLHgMFPQeEs/gg477rAOwcX9lZi58UI?= =?us-ascii?Q?6Ds0J/X5r4LkJaXXs1jLUAokQuabWQr7yjIyXcg2iWxPAqOmwR7gOdmpBu8E?= =?us-ascii?Q?EOtQoUO2zXS+4SxlAKDwOZPcMeblC/gVPXsF/Nw97iSarvWbbwAlyzMpQ6+4?= =?us-ascii?Q?+4xfh8MmoiWJWqyygfGdNIzMaLCZ3grkittG59IiwDEZpGkdYBB4ZqGrOlCE?= =?us-ascii?Q?e4aCY9nRDgm8AiKJ8T3cKRRaxhn6YBIkKkQqWvjz5LRDQj7zgHvZ57zhuNef?= =?us-ascii?Q?pA0guMOi82mZ2G4jQvCxZdoqwFxDKWqdXuYdRU8W9fgT25zlezl28/IX2CY9?= =?us-ascii?Q?cBRkO57wNwqgzW/+1Jq3skK7APid4XzH88gsG3KvFo5KlC88rkHx3246yHxO?= =?us-ascii?Q?S9hF7MiGXFmZad/S4HANbjENe2KmU6wbyPO42JPVbjpObsN4vc0MdwIGTeAq?= =?us-ascii?Q?v8O8DY+Ku1MM0wS+e9Bsn0uP734Dw4djXPfOqf7YMuM01rutZ2C9Bef85LmM?= =?us-ascii?Q?uaIwRHWlpucgJoFPC3kOmUsFfp5GbnDaeCkC+AGWg4VLLQY3ZvXp8OmZwnT7?= =?us-ascii?Q?ynxxnmp+Tn2sCax3qVYB4/4b54jnUoP9nlW7igBhDwMV7kGYL2OhphHRtBYk?= =?us-ascii?Q?03FIxnmBb66pCbYNz8hd+SRYHpVaiYb3c17kPd0xh/Qe+v+ySBvuwZfxV3Xx?= =?us-ascii?Q?ceAv7RBvIBWG4RUqIqOr0uuUxizu/ESNy7JrtAKu228YBWHnjU6DVzeu6O3I?= =?us-ascii?Q?BScFXYoqLItFmaOHaxhf1d1EyuMqtijJFVLYpoas3iua5AiwZYQZGZeajLkk?= =?us-ascii?Q?kuBEUPt30tWmDAouS0RuaxJbv1O4Za4NZWA25xYGGdKzxX1VUsq/rxsU3Sqs?= =?us-ascii?Q?rBa3+zcMUtWen+56Xl2wbnvwtvPxNAuqAvsPyHRcGqQgGm/DhK5MlIxCS0z7?= =?us-ascii?Q?gyYCcvZyb/H/1lODMSzGQLcxcn8/ghHGC11Fp+vphZlvK4evylNCM3qR3cp3?= =?us-ascii?Q?VvW/fi+mpeiNQA4B78/h8A7QG4YaGbqFjehVYGlwLQfSU8DC1XK1XsvBwytk?= =?us-ascii?Q?7u1iFawig4V69V871dyWLZHC2vSuHYEIJE66q5OmVIFcMkmp5KylQmu8DWtC?= =?us-ascii?Q?IegMO1k2VqU55pEqKhFHoi58gKNOBlGVkFh6PsK0YHdli92qzTXMOA1wVQvS?= =?us-ascii?Q?gpv6elA0WwiiZ9pQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3879; 6:EZ+LxymoTgYVlcP1y3qb98a0tdc6sKmB9Jc8q6/oaV5AnXK0oNZEIQtz+9FbRPa36SuLc9KiyMyg7h/3aN8b5j/T+1+LKbDeLp0KK0TlPzRGUndTbs740ZYNCAeYOOn1Jh6YqTsVU5VsA8sEJIb5M1n6rq5xjogUBRemtKieHeVbL/jNgTGn4mlW4T4i0H50sNfhHtN9sUPfVgzvgXHrhSpkYprs21+hU8v7naaj8THccSSJHOlYksgx4GS65jCLGlEmfc/Brm0Mo2rO1qgDPHf07j6PXYCXR88N3PYbgmtZheTiVNsaM+85ZmuQzXf41WDh8QpcMytwT8Q5kQYlao8RaRNQNFN+tA9+hhULIxo=; 5:ylNVBCnAfM35x1HyWmVsbBYQjkSN7FL8y75/ZZqJBkdFrW9NJ1epvVL5I9EG+B4qc5OjYUX0u5aKLydSoO56PpkMkfkTsx7lNPoqCQGGgZK/Wf0Cwp/UZGWLv85b/8hXTsIH7nSLB0LMqZo+eK8oe+bfdouJaeT2vSDiEHBWu+U=; 24:71cP6CDmS0UZRFI0kQxnChEVOiZHsYHUIVSmkG5ucZ4VNEtq7yYOt9gCE/DrWgOMxDS2FMUq0v1ZxpJRcSbqHcuVE4KCNQosyqHgeQYVWU0=; 7:1A9V0KHisgyRD2MpmcZapMa5P/Z/pRJYxvmPYiyn4+j6Il8Mo3nyTDlWl9TOHOij4jaJEc8lzqdkiy2oDK36/2wXHo1sE4hLy/t8bxaxxZcxVuZNM/PqTjvkGsdE5uqoX/TtK1CDmdLORXfDXEQw3TAbAUOP+D9npqwuiHa58juKQBlF6XT+czhi/GvgbxDTcfNk8/36Z31FFPk+Gh5Pd++CytaYd/11lpo8D64r3M8H0AI5vn3cyQBTnVk7hTO1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 16:02:15.8078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67579f14-0471-4541-0167-08d56cb1d43f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3879 Subject: [dpdk-dev] [PATCH v1] net/failsafe: fix default Tx offloads capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 16:02:19 -0000 Failsafe reported Tx offloads capabilities are the AND result of its default capabilities and those of its sub-devices. In the corrupted code failsafe default Tx capabilities were set to 0. As a result when running testpmd with "--tx-offloads=0x8000" parameter (request for multi segments offload) - an error was returned: PMD: net_failsafe: Some Tx offloads are not supported, requested 0x8000 supported 0x0 To fix this, failsafe default Tx offload capabilities are set to DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM, Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/failsafe/failsafe_ops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index e7bb801..7a67e16 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -77,7 +77,11 @@ static struct rte_eth_dev_info default_infos = { DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_TIMESTAMP | DEV_RX_OFFLOAD_SECURITY, - .tx_offload_capa = 0x0, + .tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | + DEV_TX_OFFLOAD_IPV4_CKSUM | + DEV_TX_OFFLOAD_UDP_CKSUM | + DEV_TX_OFFLOAD_TCP_CKSUM, .flow_type_rss_offloads = 0x0, }; -- 2.7.4