[dpdk-dev] [PATCH] doc: update the usage for shared library

[dpdk-dev] [PATCH] doc: update the usage for shared library

[Vipin Varghese]

Add note information to intimate about use of option '-d' for shared
library in DPDK application.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 doc/guides/nics/build_and_test.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/nics/build_and_test.rst b/doc/guides/nics/build_and_test.rst
index 62ac52c..9a96343 100644
--- a/doc/guides/nics/build_and_test.rst
+++ b/doc/guides/nics/build_and_test.rst
@@ -151,3 +151,8 @@ This section demonstrates how to setup and run ``testpmd`` in Linux.
 
    Refer to the :ref:`testpmd runtime functions <testpmd_runtime>` for a list
    of available commands.
+
+   .. note::
+
+   When dpdk-testpmd is built with shared library, use option ``-d`` to
+   load the dynamic PMD for ``rte_eal_init``.
-- 
1.9.1

Re: [dpdk-dev] [PATCH] doc: update the usage for shared library

[Mcnamara, John]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, February 5, 2018 2:17 PM
> To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>
> Subject: [PATCH] doc: update the usage for shared library
> 
> Add note information to intimate about use of option '-d' for shared
> ...
> +
> +   .. note::
> +
> +   When dpdk-testpmd is built with shared library, use option ``-d`` to
> +   load the dynamic PMD for ``rte_eal_init``.

I think the text of the note needs to be indented at least 3 spaces.

Also, the app name is testpmd, not dpdk-testpmd, right? That is what is in
the previous section of the doc.

Also, quote the application name like this: ``testpmd``.


John

[dpdk-dev] [PATCH v2] doc: update the usage for shared library

[Vipin Varghese]

Add note information to intimate about use of option '-d' for shared
library in DPDK application.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---

V2 Changes:
 - updated the space - John
 - updated testpmd to dpdk-testpmd - John
---
 doc/guides/nics/build_and_test.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/nics/build_and_test.rst b/doc/guides/nics/build_and_test.rst
index 62ac52c..9c4e7b2 100644
--- a/doc/guides/nics/build_and_test.rst
+++ b/doc/guides/nics/build_and_test.rst
@@ -151,3 +151,8 @@ This section demonstrates how to setup and run ``testpmd`` in Linux.
 
    Refer to the :ref:`testpmd runtime functions <testpmd_runtime>` for a list
    of available commands.
+
+   .. note::
+
+      When ``dpdk-testpmd`` is built with shared library, use option ``-d`` to
+      load the dynamic PMD for ``rte_eal_init``.
-- 
1.9.1

Re: [dpdk-dev] [PATCH v2] doc: update the usage for shared library

[Mcnamara, John]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, February 6, 2018 2:09 PM
> To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Cc: stable@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>;
> Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH v2] doc: update the usage for shared library
> 
> Add note information to intimate about use of option '-d' for shared
> library in DPDK application.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> 
> V2 Changes:
>  - updated the space - John
>  - updated testpmd to dpdk-testpmd - John

Hi,

It should be the other way around. dpdk-testpmd should be changed to
testpmd:


> +
> +      When ``dpdk-testpmd`` is built with shared library, use option ``-
> d`` to
> +      load the dynamic PMD for ``rte_eal_init``.

[dpdk-dev] [PATCH v3] doc: update the usage for shared library

[Vipin Varghese]

Add note information to intimate about use of option '-d' for shared
library in DPDK application.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---

V3 Changes:
 - updated from 'dpdk-testpmd' to 'testpmd' - John

V2 Changes:
 - updated the space - John
 - updated testpmd to dpdk-testpmd - John
---
 doc/guides/nics/build_and_test.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/nics/build_and_test.rst b/doc/guides/nics/build_and_test.rst
index 62ac52c..d9a78ee 100644
--- a/doc/guides/nics/build_and_test.rst
+++ b/doc/guides/nics/build_and_test.rst
@@ -151,3 +151,7 @@ This section demonstrates how to setup and run ``testpmd`` in Linux.
 
    Refer to the :ref:`testpmd runtime functions <testpmd_runtime>` for a list
    of available commands.
+
+   .. note::
+      When ``testpmd`` is built with shared library, use option ``-d`` to load
+      the dynamic PMD for ``rte_eal_init``.
-- 
1.9.1

Re: [dpdk-dev] [PATCH v3] doc: update the usage for shared library

[Mcnamara, John]

> -----Original Message-----
> From: Varghese, Vipin
> Sent: Thursday, February 8, 2018 6:20 PM
> To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Cc: Kovacevic, Marko <marko.kovacevic@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>
> Subject: [PATCH v3] doc: update the usage for shared library
> 
> Add note information to intimate about use of option '-d' for shared
> library in DPDK application.
> 

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v3] doc: update the usage for shared library

[Thomas Monjalon]

> > Add note information to intimate about use of option '-d' for shared
> > library in DPDK application.
> > 
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks