From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 81C93B62 for ; Wed, 6 Apr 2016 15:45:02 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id u206so46388596wme.1 for ; Wed, 06 Apr 2016 06:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=x2uA/4W/7IWiV1E0IfKI4qrUM1CP7rv85assz4YmpNw=; b=ryM0wQHf3D/hBQamUmuRDfap1UdS3bEnAPX0hohd05ZTaSfD4WidFMEBj/8+BydZbd 84U4Kjllc8tjg4HeDCnomokstg8ZLgE8AKSEfWZWSHwH6x9PwnPTPXUKLXAqTWAsql1C 8Ru0IoggG2jSlQg5PBgxBZsY2EgqdpogosPo8gXBnUHVfPhHpJTkaw2jUM5VbdUqaTgQ ASI+d9Xvl1qE04j2j32179cFV9WM9AoqkMltQyFngNSLLqe2k5g84kXMPzCIBWbEtgEh Ep0kp73esXMrAfn2Tz7Imi4GPDvPvMU8ecO7w8sgJ9fsQ9ETmMQJnYjWwGBGbfGnghof Y74A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=x2uA/4W/7IWiV1E0IfKI4qrUM1CP7rv85assz4YmpNw=; b=EBHXdzXagNL17OFmpLo++cx9/PpMdK0NbwyHW5oqaUvtnHE6URy9y8PIyJXQ7LGj5A 8jkSlCg80rYwxD/t5AhERZM5lWw30GPTBcDxmF81Zw/HinB+rXe2z8Ms6Etereezmfuq jPwsYdMf25CFOr1aMV306Meht9MRe3ecdDndfOf8OItqgBROTRB4Q+EGVw0CIFKEYZTL t3Ou20CJjRTX6u7RMCMP+3IYurJ9VvfO0nCf+BoBnRS+za2a96EJUGaCttvbqvcMt1y1 qg4jQqZr/g5ekuLsrULY4i7ygvAGgAHZevT78CP3zIMQ61x0mKNdDI6v+6EQrBj4YC2N KNbw== X-Gm-Message-State: AD7BkJL/pzVDftL/LIiZLnkGrAVY+bdmD1gOaR2xogl6vzBtFWYAKXMHv/ZgNLmhMVpYUPdM X-Received: by 10.28.51.15 with SMTP id z15mr24907540wmz.32.1459950302351; Wed, 06 Apr 2016 06:45:02 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i206sm24967454wmf.1.2016.04.06.06.45.01 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 06:45:01 -0700 (PDT) From: Thomas Monjalon To: "Tao, Zhe" Cc: dev@dpdk.org, "Ananyev, Konstantin" , "Wu, Jingjing" Date: Wed, 06 Apr 2016 15:43:23 +0200 Message-ID: <1518554.AZ5xZbn1fs@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B2EAD0@irsmsx105.ger.corp.intel.com> References: <1459426558-23423-1-git-send-email-zhe.tao@intel.com> <1459930592-8196-1-git-send-email-zhe.tao@intel.com> <2601191342CEEE43887BDE71AB97725836B2EAD0@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] i40e: fix TSO issue for tx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 13:45:02 -0000 > > We will not get what we want, the ipv6 packets sent out from IXIA can be > > received by i40e, but cannot forward to another port. > > The root cause is when HW doing the TSO offload for packets, it does not only > > depends on the context descriptor to define the MSS and TSO payload size, it > > also need to know whether this packets is ipv4 or ipv6, we use > > i40e_txd_enable_checksum to generate the related fields for data descriptor. > > But PMD will not call i40e_txd_enable_checksum if only the TSO offload flag is > > set. The reason why ipv4 works fine for TSO in testpmd csum mode is csum engine > > will set the ip csum flag when the packet is ipv4 and TSO is enabled but > > will not set the flag for ipv6 and this flag will cause the > > i40e_txd_enable_checksum to be invoked. For both the cases the TSO flag will be > > set, so we need to use TSO flag to trigger the i40e_txd_enable_checksum. > > The right logic here is we enable csum offload for both ipv4 and ipv6 when TSO > > flag is set. > > > > Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets) > > > > Signed-off-by: Zhe Tao > > Acked-by: Konstantin Ananyev Applied, thanks