DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matan Azrad <matan@mellanox.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation
Date: Wed, 14 Feb 2018 14:47:26 +0000	[thread overview]
Message-ID: <1518619646-23990-1-git-send-email-matan@mellanox.com> (raw)
In-Reply-To: <1518562772-29823-1-git-send-email-matan@mellanox.com>

Fail-safe dev_start() operation can be called by both the application
and the hot-plug alarm mechanism.

The installation of Rx interrupt are triggered from dev_start() in any
time it is called while actually the Rx interrupt should be installed
only by the application calls.

So, each plug-in event causes reinstallation which causes memory leak
and spoils the fail-safe Rx interrupt mechanism.

Trigger the Rx interrupt installation only when it does not exist.

Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode")

Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/failsafe/failsafe_intr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/failsafe/failsafe_intr.c b/drivers/net/failsafe/failsafe_intr.c
index f6ff04d..6b7f9c1 100644
--- a/drivers/net/failsafe/failsafe_intr.c
+++ b/drivers/net/failsafe/failsafe_intr.c
@@ -523,7 +523,7 @@ void failsafe_rx_intr_uninstall_subdevice(struct sub_device *sdev)
 	const struct rte_intr_conf *const intr_conf =
 			&priv->dev->data->dev_conf.intr_conf;
 
-	if (intr_conf->rxq == 0)
+	if (intr_conf->rxq == 0 || dev->intr_handle != NULL)
 		return 0;
 	if (fs_rx_intr_vec_install(priv) < 0)
 		return -rte_errno;
-- 
1.9.5

  parent reply	other threads:[~2018-02-14 14:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 22:59 [dpdk-dev] [PATCH] " Matan Azrad
2018-02-14 13:52 ` Gaëtan Rivet
2018-02-14 13:59   ` Matan Azrad
2018-02-14 14:47 ` Matan Azrad [this message]
2018-02-14 15:00   ` [dpdk-dev] [PATCH v2] " Gaëtan Rivet
2018-02-14 15:01     ` Gaëtan Rivet
2018-02-14 15:11       ` Matan Azrad
2018-02-14 15:12       ` Gaëtan Rivet
2018-02-14 15:28     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518619646-23990-1-git-send-email-matan@mellanox.com \
    --to=matan@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).