DPDK patches and discussions
 help / color / mirror / Atom feed
From: Konrad Jankowski <konrad.jankowski@intel.com>
To: wei.dai@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com,
	jingjing.wu@intel.com, dev@dpdk.org
Cc: Konrad Jankowski <konrad.jankowski@intel.com>
Subject: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler
Date: Wed, 14 Feb 2018 13:32:31 -0500	[thread overview]
Message-ID: <1518633151-29118-1-git-send-email-konrad.jankowski@intel.com> (raw)

Commit 66b8304f removed the rte_intr_enable() call from
i40evf_dev_interrupt_handler() as a "bonus". On one of my systems this causes
the AdminQ messages to stop beeing delivered to the VF. This results in
unability to initialize and use the port. With this patch it works again.

System in question:
Wind River OVP6 running kernel 3.10.58-ovp-rt58-WR6.0.0.13_preempt-rt

Signed-off-by: Konrad Jankowski <konrad.jankowski@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index fd003fe..b927a35 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -1404,6 +1404,7 @@ i40evf_dev_interrupt_handler(void *param)
 
 done:
 	i40evf_enable_irq0(hw);
+	rte_intr_enable(dev->intr_handle);
 }
 
 static int
-- 
2.5.5

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

             reply	other threads:[~2018-02-14 18:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 18:32 Konrad Jankowski [this message]
2018-03-28  3:36 ` Zhang, Qi Z
2018-04-04 17:12   ` Jankowski, Konrad
2018-04-06 15:47     ` Zhang, Helin
2018-04-06 15:52     ` Zhang, Helin
2018-04-10 13:26     ` Zhang, Qi Z
2018-04-10 14:06       ` Jankowski, Konrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518633151-29118-1-git-send-email-konrad.jankowski@intel.com \
    --to=konrad.jankowski@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=wei.dai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).