From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id AAE9443FFC;
Thu, 16 May 2024 19:15:08 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3B592402ED;
Thu, 16 May 2024 19:15:08 +0200 (CEST)
Received: from wfhigh7-smtp.messagingengine.com
(wfhigh7-smtp.messagingengine.com [64.147.123.158])
by mails.dpdk.org (Postfix) with ESMTP id BA291402EC;
Thu, 16 May 2024 19:15:06 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailfhigh.west.internal (Postfix) with ESMTP id 966891800147;
Thu, 16 May 2024 13:15:05 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute4.internal (MEProxy); Thu, 16 May 2024 13:15:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm3; t=1715879705;
x=1715966105; bh=vFLkIBApvIjpqHZlVczUOs25tXTveHIkN4noy4kUVjY=; b=
ePkNLWgBbo3TloBYSR4y6CogH6pYo5Ga/H8drzFp741D+mMJ84ABDtlzofBkMXOf
/0OL1PC36Rwlsz2IBNMzf1tXLLVimuvJ3p0RzurH4gszdzwMmedZNiDQ4gwkRNHe
GTHPPW1l3/lQfNol7nyNqbj437PE6sBZcfN0/iJQIk1kt8mngqz3rWc4uelvCwpd
5Oo3YOsBVAzgA4tjCErR8IC4qH/BIv9Xg7MvW9cm0UeTHINlSCHEnuUIm0+3Zj3i
vo+aCwJNsWFK1czT1pGEompYwNhxjkoAEyFeyltNXWYhROFW27GaMrHrY49/RBUm
wUvfkNK1OOjUXh2xBHHEhw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715879705; x=
1715966105; bh=vFLkIBApvIjpqHZlVczUOs25tXTveHIkN4noy4kUVjY=; b=Y
kkVjukWiGp6Etr31G/Rv0VzcnC9iboAzVwfAVdhX3ErnOj8DOkuqsf34JOxm8xvQ
zxNvwUUzLySIRq3C/6fo00WPBwesHj42XpE27INzaA9njnuzv/2KyBB+wLUCOmOg
IVmUeMveMoVbR4unFdWnxQoWGSwGyXFiCijuPXdu79UQCHkTi+AdIV0RG1+sA5q7
9nU9r2gEdvcsilm1qobmBxOoKWAgUOLvK4/44QLW0ErnoOG+rFY8lMHT5BoxS//M
TQRhSt2kYlRiBTlYbSjpBf/SUPmF/IaPucJo3Erh8nCg7op84Yl5TDJJ1JdWQrPe
h85A+J5wEWAZJ8Vn3vPcQ==
X-ME-Sender: <xms:GD9GZgGqTHfQPgMU8Rb-mkSOl6o-cva69Md7tYuJkX9M9dcNwqtCeA>
<xme:GD9GZpVkQ4tPATSS0Rv4mylTUCFP-u1Drk7NGj8im8xo9U4-YyWja2OMDLDj_WNLA
-cZNZRIIP88YINgAA>
X-ME-Received: <xmr:GD9GZqIJzL48BEItbs1811m1Kidc2DjYPE9n3FuaAMXF0IGWoDVU60GunzafeA4sL3UoHFhyUiwvE4l6cp3yyIgJSg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdehuddguddtkecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho
mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne
cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv
ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:GD9GZiESwy-BEK9psdOcB411UKeWdQhfHDtwVZxrDvGfFlzyHwKM7Q>
<xmx:GD9GZmUiCCloaE-tEBVK5n82bMxbTRvGig43r2xzqBTwntv73qqdsA>
<xmx:GD9GZlP_X5MhudrwasnMaQCUUpoeGP815FA5KSouiobRbMgbQGewEQ>
<xmx:GD9GZt3ZZcwvVh_14xbpUzF8xnSz_ctlIt98pUEBdTfqoBCfQmZDTQ>
<xmx:GT9GZkznU7BM7CkP3tIWCN-wWtLH8f0Igzt5jOeepxcY3JbYZTboIn5x>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
16 May 2024 13:15:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Subject: Re: [PATCH] eal: fix missing type in dtor macro expansion
Date: Thu, 16 May 2024 19:15:02 +0200
Message-ID: <15187287.tv2OnDr8pf@thomas>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3AB@smartserver.smartshare.dk>
References: <1713285204-5933-1-git-send-email-roretzla@linux.microsoft.com>
<98CBD80474FA8B44BF855DF32C47DC35E9F3AB@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
16/04/2024 20:16, Morten Br=C3=B8rup:
> > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> > Sent: Tuesday, 16 April 2024 18.33
> >=20
> > RTE_FINI expansion failed to specify void * type for storage of
> > destructor function pointer resulting it defaulting to type ``int``.
> >=20
> > Update the macro to specify ``void *`` as the type so the correct size
> > is allocated in the segment.
> >=20
> > Fixes: 64eff943ca82 ("eal: implement constructors for MSVC")
> > Cc: roretzla@linux.microsoft.com
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>=20
> Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>
Applied, thanks.