From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id B9FA7B630 for ; Wed, 18 Feb 2015 01:31:42 +0100 (CET) Received: by wevm14 with SMTP id m14so1660868wev.8 for ; Tue, 17 Feb 2015 16:31:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=8deHT6eMSI5F/BqiwIcIE6DiD2SGQuMct30rR8LgrkQ=; b=VD2VMBpxTkEKsz3UeTMfp3EXVEFHD+6B6MsKT9J13KkuVkxzTMpQdKwEO7SYYjUNIA oI6SYUKe+mw5HYdkpSdyVsqEaFzS2i47MUOdEMpoxEb5l3GNeEDZBDgw59AJBS6xoP3V 0cYy5/hK4cNgRPn0lzTL92E61YVrMNCS1iX0qUXx8o9tCiJ2HiPe7qWHNWuNCfqbV8DR x6CiMUNndbk7N+SKFor7IXfN02QHgnonevbqCAWMEPue5GD+uQxI7Ha8jHB3M5Zg66Ya vR2IASDuxeYC59dXsCL4EbU2AeyiGr9xkiIVF6AuPJVi+EuZkYwbsT4A7ShxOoN1BgkA 0ddA== X-Gm-Message-State: ALoCoQm2gHPWfBsTQ5+GlN5NYet/keV48haJRazdU/XSXnPwN3dGbufq7US2WRK6MZ82A3GaQBj+ X-Received: by 10.194.172.35 with SMTP id az3mr3414737wjc.43.1424219502567; Tue, 17 Feb 2015 16:31:42 -0800 (PST) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id df8sm22518962wib.2.2015.02.17.16.31.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2015 16:31:41 -0800 (PST) From: Thomas Monjalon To: Tetsuya Mukawa Date: Wed, 18 Feb 2015 01:31:09 +0100 Message-ID: <1518995.cYPUuEs3Fv@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54E2DC38.7000907@igel.co.jp> References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <2372286.XQlcQsOEBg@xps13> <54E2DC38.7000907@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Neil Horman Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 00:31:43 -0000 2015-02-17 15:14, Tetsuya Mukawa: > On 2015/02/17 9:36, Thomas Monjalon wrote: > > 2015-02-16 13:14, Tetsuya Mukawa: > > Is uint8_t sill a good size for hotpluggable virtual device ids? > > I am not sure it's enough, but uint8_t is widely used in "rte_ethdev.c" > as port id. > If someone reports it doesn't enough, I guess it will be the time to > write a patch to change all uint_8 in one patch. It's a big ABI breakage. So if we feel it's going to be required, it's better to do it now in 2.0 release I think. Any opinion?