DPDK patches and discussions
 help / color / mirror / Atom feed
From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
To: dev@dpdk.org
Cc: jerin.jacob@caviumnetworks.com,
	Santosh Shukla <santosh.shukla@caviumnetworks.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference
Date: Tue, 20 Feb 2018 22:44:15 +0530	[thread overview]
Message-ID: <1519146856-10748-1-git-send-email-santosh.shukla@caviumnetworks.com> (raw)

Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
Coverity issue: 195040

Cc: stable@dpdk.org
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
 drivers/net/octeontx/octeontx_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index b739c0b..0d8937c 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -1149,7 +1149,7 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
 	return data->port_id;
 
 err:
-	if (port)
+	if (nic)
 		octeontx_port_close(nic);
 
 	if (eth_dev != NULL) {
-- 
2.7.4

             reply	other threads:[~2018-02-20 17:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:14 Santosh Shukla [this message]
2018-02-20 17:14 ` [dpdk-dev] [PATCH v1 2/2] net/octeontx: fix for uninitialized scalar var Santosh Shukla
2018-03-06 17:51 ` [dpdk-dev] [PATCH v1 1/2] net/octeontx: fix null pointer dereference Ferruh Yigit
2018-03-07  8:20   ` Pavan Nikhilesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519146856-10748-1-git-send-email-santosh.shukla@caviumnetworks.com \
    --to=santosh.shukla@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).