DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	jianfeng.tan@intel.com
Subject: [dpdk-dev] [PATCH 2/2] app/tesetpmd: disable memory locking for bsdapp
Date: Thu,  3 May 2018 13:38:20 +0100	[thread overview]
Message-ID: <151ad7a96d31c881c28379b66c740cf96f5d2635.1525350577.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <c8408589f17e938b87bee35d7fab69b7c5634885.1525350577.git.anatoly.burakov@intel.com>
In-Reply-To: <c8408589f17e938b87bee35d7fab69b7c5634885.1525350577.git.anatoly.burakov@intel.com>

If mlockall() is called while allocated VA space is bigger than
amount of available RAM, FreeBSD kernel will deadlock and need
a hard reboot. We do allocate big amounts of memory because of
how new memory subsystem works, so calling mlockall() will cause
a deadlock. So, disable mlockall() by default on FreeBSD.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 app/test-pmd/testpmd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 77490be..38b8b7a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2615,6 +2615,13 @@ main(int argc, char** argv)
 	latencystats_enabled = 0;
 #endif
 
+	/* on FreeBSD, mlockall() is disabled by default */
+#ifdef RTE_EXEC_ENV_BSDAPP
+	do_mlockall = 0;
+#else
+	do_mlockall = 1;
+#endif
+
 	argc -= diag;
 	argv += diag;
 	if (argc > 1)
-- 
2.7.4

  reply	other threads:[~2018-05-03 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 12:38 [dpdk-dev] [PATCH 1/2] app/testpmd: make locking memory configurable Anatoly Burakov
2018-05-03 12:38 ` Anatoly Burakov [this message]
2018-05-10 14:33   ` [dpdk-dev] [PATCH 2/2] app/tesetpmd: disable memory locking for bsdapp Ananyev, Konstantin
2018-05-14  1:55     ` Thomas Monjalon
2018-05-10  9:40 ` [dpdk-dev] [PATCH 1/2] app/testpmd: make locking memory configurable Remy Horton
2018-05-10 14:36 ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151ad7a96d31c881c28379b66c740cf96f5d2635.1525350577.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).