DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4.
@ 2017-05-31 15:40 Lee Roberts
  2017-05-31 16:43 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Lee Roberts @ 2017-05-31 15:40 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, Lee Roberts

Fix kni compilation under RHEL 7.4.

Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
---
 lib/librte_eal/linuxapp/kni/compat.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h
index d96275a..6a1587b 100644
--- a/lib/librte_eal/linuxapp/kni/compat.h
+++ b/lib/librte_eal/linuxapp/kni/compat.h
@@ -53,7 +53,9 @@
 #define HAVE_SK_ALLOC_KERN_PARAM
 #endif
 
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0) || \
+	(defined(RHEL_RELEASE_CODE) && \
+	 RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4))
 #define HAVE_TRANS_START_HELPER
 #endif
 
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4.
  2017-05-31 15:40 [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4 Lee Roberts
@ 2017-05-31 16:43 ` Ferruh Yigit
  2017-06-05 13:46   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-31 16:43 UTC (permalink / raw)
  To: Lee Roberts; +Cc: dev

On 5/31/2017 4:40 PM, Lee Roberts wrote:
> Fix kni compilation under RHEL 7.4.
> 
> Signed-off-by: Lee Roberts <lee.roberts@hpe.com>

Not tested on RHEL 7.4, but patch looks good to me except following
nit-picking:
- There should not be "." at the end of the patch title
- It can be good to add Linux commit that is the reason of the change to
the commit log:
Linux: 9b36627acecd ("net: remove dev->trans_start")

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4.
  2017-05-31 16:43 ` Ferruh Yigit
@ 2017-06-05 13:46   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-06-05 13:46 UTC (permalink / raw)
  To: Lee Roberts; +Cc: dev, Ferruh Yigit

31/05/2017 18:43, Ferruh Yigit:
> On 5/31/2017 4:40 PM, Lee Roberts wrote:
> > Fix kni compilation under RHEL 7.4.
> > 
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> 
> Not tested on RHEL 7.4, but patch looks good to me except following
> nit-picking:
> - There should not be "." at the end of the patch title
> - It can be good to add Linux commit that is the reason of the change to
> the commit log:
> Linux: 9b36627acecd ("net: remove dev->trans_start")
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-05 13:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 15:40 [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4 Lee Roberts
2017-05-31 16:43 ` Ferruh Yigit
2017-06-05 13:46   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).