DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/null: Support bulk alloc and free.
@ 2018-02-03  3:11 Mallesh Koujalagi
  2018-03-05 15:24 ` Ferruh Yigit
  2018-03-08 23:40 ` [dpdk-dev] [PATCH v2] net/null: support bulk allocation Mallesh Koujalagi
  0 siblings, 2 replies; 8+ messages in thread
From: Mallesh Koujalagi @ 2018-02-03  3:11 UTC (permalink / raw)
  To: dev; +Cc: mtetsuyah, ferruh.yigit, malleshx.koujalagi

After bulk allocation and freeing of multiple mbufs increase more than ~2%
throughput on single core.

Signed-off-by: Mallesh Koujalagi <malleshx.koujalagi@intel.com>
---
 drivers/net/null/rte_eth_null.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 9385ffd..247ede0 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -130,10 +130,11 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 		return 0;
 
 	packet_size = h->internals->packet_size;
+
+	if (rte_pktmbuf_alloc_bulk(h->mb_pool, bufs, nb_bufs) != 0)
+		return 0;
+
 	for (i = 0; i < nb_bufs; i++) {
-		bufs[i] = rte_pktmbuf_alloc(h->mb_pool);
-		if (!bufs[i])
-			break;
 		rte_memcpy(rte_pktmbuf_mtod(bufs[i], void *), h->dummy_packet,
 					packet_size);
 		bufs[i]->data_len = (uint16_t)packet_size;
@@ -149,18 +150,15 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 static uint16_t
 eth_null_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
 {
-	int i;
 	struct null_queue *h = q;
 
 	if ((q == NULL) || (bufs == NULL))
 		return 0;
 
-	for (i = 0; i < nb_bufs; i++)
-		rte_pktmbuf_free(bufs[i]);
+	rte_mempool_put_bulk(bufs[0]->pool, (void **)bufs, nb_bufs);
+	rte_atomic64_add(&h->tx_pkts, nb_bufs);
 
-	rte_atomic64_add(&(h->tx_pkts), i);
-
-	return i;
+	return nb_bufs;
 }
 
 static uint16_t
-- 
2.7.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-03-16 14:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-03  3:11 [dpdk-dev] [PATCH] net/null: Support bulk alloc and free Mallesh Koujalagi
2018-03-05 15:24 ` Ferruh Yigit
2018-03-05 15:36   ` Ananyev, Konstantin
2018-03-07 10:57     ` Ferruh Yigit
2018-03-08 21:29       ` Koujalagi, MalleshX
2018-03-08 23:40 ` [dpdk-dev] [PATCH v2] net/null: support bulk allocation Mallesh Koujalagi
2018-03-09 11:09   ` Ferruh Yigit
2018-03-16 14:08     ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).