From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <hemant.agrawal@nxp.com>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
(mail-eopbgr40074.outbound.protection.outlook.com [40.107.4.74])
by dpdk.org (Postfix) with ESMTP id 0EA475B18;
Wed, 14 Mar 2018 08:58:02 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=HG05S5rud76hN9Lqj6jOwy+CWuWGVr6E5IdIz2NmlKM=;
b=dqYHiEoMtDeEK8vEpIxDAjERtI8TVeCLUTBomnLTQkXdO6pUWchoZXB3RUbzn9fc0NYiP2lMf94blmSJymMqcpnuwHXOri4Jic7ndRabzBuXzx9lMoCp6o5jaDrjxo/4bru5kIIMFknWLto2HQyfy0vnOB0HnY8prkyiaLgUBGo=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=hemant.agrawal@nxp.com;
Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by
AM2PR04MB0754.eurprd04.prod.outlook.com (2a01:111:e400:8411::14) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Wed, 14
Mar 2018 07:58:00 +0000
From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: dev@dpdk.org,
bruce.richardson@intel.com
Cc: thomas@monjalon.net,
stable@dpdk.org
Date: Wed, 14 Mar 2018 13:25:58 +0530
Message-Id: <1521014166-3201-3-git-send-email-hemant.agrawal@nxp.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1521014166-3201-1-git-send-email-hemant.agrawal@nxp.com>
References: <1519889597-5805-1-git-send-email-hemant.agrawal@nxp.com>
<1521014166-3201-1-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [14.142.187.166]
X-ClientProxiedBy: BM1PR0101CA0008.INDPRD01.PROD.OUTLOOK.COM
(2603:1096:b00:18::18) To AM2PR04MB0754.eurprd04.prod.outlook.com
(2a01:111:e400:8411::14)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 1f998048-c4be-477b-264c-08d589814f5b
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);
SRVR:AM2PR04MB0754;
X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754;
3:xFUh24qYY4qHKx7sTAenThoqA2MwkJHBo1LBaVebj6lDu+bHWcSgoDwv5h0bUIy1NYKWLvkNKI5+Hxe9zaVG1Cpyu6e7TUm/j56I74e8Te+hBKF+yWxAVktU3yKLMZpjJDuTCHwVLujCepBxhPsgrPKBTVTU2ByvVObkoW6AfqLoJHEil6Mpm2xB7DlxCO2uJH95x+ch9fnXvmmVD9hy0gfbwFJZWn931vCvsMlsZ6pbPzopME19QuWV9dIeccZF;
25:urjzrsVozsPTu88m6O7PAgPl4PLHYf3au6+DVLb59CKg6omTSwe3RcU1adsppHVXxftbWzrBsAHSKhRJgxMo9upTFoRTnihQsvjA4b5zNRkmahuPGpOTiAQNjc+rfZ3j5u3Qe7NpyGbA9uutF9NieleuCNitwMPkBtzcLZGQ77snRvoERrerdQp04SeJSkZyahJ4KOc8jusjK33raAM1JJ+SsBm1XcxhCsHRT6fuP30iOPu5TfWn9fVuCyxn9qJhLtoOCHTex2QqkwJ66xm9cWUMiX+b4U4IJIqzLmeCb0N5NGUDXJLe4sLLvztLlfkuXrNCotGpyHUke0fQWPSbJA==;
31:RMGt8/8GEBhFcYQ/l9Zmmqh3TnHzi+CG0bDhGM6Abu24Wkmdi/ujOv7ShBu1Gl7gACKUmY9hx3O4WwI/X6BSOSpPsG1VAnevM7kDr+RuLuInsQfxs/5H5ziimFT9EGX+kAJc6zGzPM5B6zPccxuHuOTnk1rFppRwH8dNFh9v6J1l3bz0p17gK8fi5Y3B179xeoI0C4jBN8bSxFT0FVs0tMaqPZ1YqpDDv+ZQE5cAUBY=
X-MS-TrafficTypeDiagnostic: AM2PR04MB0754:
X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754;
20:HOnjVlbD75ts82MIWHvCqqFQZs7sz0imqDz6XtSu00Gm77O2yK8RLBr1elynCN19psw3FtmhWgIcGhd4HWwZ2EGFoNNjwWph1BodQkj9J8V3GfUXglJ1J3IcCIw4Og+K57W/2UrePdu7/YLkJ/ZxXKSPx4J4RNVswqucW1IRnkejkTuNX6kwhe4RekVKEhlUveW7S/widnfqkB3g434Ggfe5dO481LnNhyjlO7QpMh5Jig51mCx/GzkRTfkQ+057Ehk+RuKjVxPDxtMTc83HpyRW448vUUaPZhuiXoQ2dJUpedAEmkfkhRFGUbSEpKvyLpRsp/Ji2TShay7woNQ8+ZmJT10EKU+OKN63cv3p/BV9hASL621QDOXhApbDDqTRjTgODe78knguIQjFklirwBMQYIUNNaU1qJdeRdW2a6Un18dlZPYneWk8QJLq8+/cDbAtngn3bpyz/XgQr+vY+M7SyaPQ4kvQwoajk52Ajal6Qy16qwEULy5o7LOrH3wQ;
4:O426wuwMFOtIDbRWlCqFmTkwsNzsL7lFvJXNuZHKn57saS53LmOtCjhM3OrsEVfDpSnNxmeuTARy2Z5Tsu3VWcHJ9OTXxDjFLkHLGdJ0Luz2/r+6X9qv8AnrbXAHPelt/osYhDkyRe+HUzg166odRIJ5hr9l28ZDcQcSWsrFen2yN36qxuEAwGBZA32kA2XilTlIaheRjObpYJU1Y5OJMfiIZc9vyGUTyMtdKJAIq7IwNOjVYFAUenp+0BAZrLu8aFpaHZbQSGSsqG1CGZ70jioMCYrk3xQJM5BuQntFHbCPxYzzjR0VMq++iHpkv6fg
X-Microsoft-Antispam-PRVS: <AM2PR04MB0754F1CD354D0887CB6C411D89D10@AM2PR04MB0754.eurprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);
SRVR:AM2PR04MB0754; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0754;
X-Forefront-PRVS: 0611A21987
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(376002)(39860400002)(346002)(39380400002)(396003)(366004)(199004)(189003)(316002)(4326008)(16526019)(47776003)(6506007)(66066001)(186003)(52116002)(86362001)(386003)(55236004)(59450400001)(48376002)(2906002)(97736004)(68736007)(26005)(5660300001)(25786009)(105586002)(76176011)(51416003)(6512007)(50466002)(5009440100003)(36756003)(16586007)(81166006)(6486002)(8936002)(106356001)(305945005)(7736002)(50226002)(6116002)(53936002)(81156014)(8676002)(2950100002)(3846002)(478600001)(110426004);
DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0754; H:bf-netperf1.ap.freescale.net;
FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0754;
23:k+Jv+Dhlpc6NgW/Vftmy+vDdYglwTWl//vGQV3nbF?=
=?us-ascii?Q?429fwzH9tEaaD+LziO89x5G5lr6sUd9cHSs5VqUaSZcvYTSImLVbnYljF4vO?=
=?us-ascii?Q?XRpe/k5nhP8wD7TvnLfeJhgIvS9TKAux5VV8pXjHQZOASP7BWyMxwC3lEbLd?=
=?us-ascii?Q?3Lg8Eu1s02j17MkSat5kXQI2btR7odRtJCWzKxQlPewcovIrTEWLdqbGulb7?=
=?us-ascii?Q?JKJPzxK7ZSELnQ734fbkgRZ4elcoskV8bK0NK/HFDG1topMrABk9NQjGtq1Z?=
=?us-ascii?Q?JLahLlNP2XLihcVbwHk9JvQS2CeCpbUyB1RKSKtCz8qEDanbzm0PJc5NrbQL?=
=?us-ascii?Q?cuuumO1jffdXetDiu3aHcfd6eoxsXL+Fv+7/ELlgdJFzKU/JUIjwMIP4Jfzz?=
=?us-ascii?Q?PNWWDUyLpaLxZy07IMRoUYubMfG3Fsi7n4GWP0NGsuPeDjkP04G6kiwRCku0?=
=?us-ascii?Q?2Yqv7jT/OXTkGFtr0EaeejlYJZ94dJh5kI5NBnCNumNQ0ovV58LANPC3Nmbh?=
=?us-ascii?Q?zfUsj6pGebPcbFDJb6k90aEzk1wd4a8c0WoVxH2JhWUViVq1gXlTCp1zEdVO?=
=?us-ascii?Q?ntANVg1opomF+1QKU2fwIz26sj88vGyhuSd6iNL3mIQK9CrK0CJcNKFJmXoP?=
=?us-ascii?Q?gtSz561Os6QTU5wPgJPHad+CRtZZCmNGVs4014V9Ni/dkY15GgptWkKshStv?=
=?us-ascii?Q?tss2YQEM0s1nn0o5brMT+pVRaRVndIl+Gc4gtNBGuT+EqPW3I6xofuxoDkra?=
=?us-ascii?Q?ZATRZpgR/YckId/qSCCaga1IH8NfLblZ+lf6pA/PH5giIZpPVs0SDQHj7Hcy?=
=?us-ascii?Q?+AjtnbhVGdesP50XrcNyNtfs5r+vFCydUDXXJ3GpY2pEqHwIj4gGxY05cIj0?=
=?us-ascii?Q?SjUo/PyGQD/UErBkx1ggXTE7CdpF8pdKAeXfsXQ4v4Y/wvjH3ZUsTg2oKcyG?=
=?us-ascii?Q?Y0Ab37c/K0jivchFgIi6UPhlHjKSwdybUnnPvyMk1FgmAq9XFFWeRUdyaHkL?=
=?us-ascii?Q?/254lgfAZhP/s7sk7mWfjyZnddw3xkUS1qeYMjfB5u8ykRtZQzzEfP7X3ukq?=
=?us-ascii?Q?4zu2xn6AHh8IrWxaK9Pjppaozb1xFr3h8Bfk0R7EbGtKN7ghrAsjJtz05YwU?=
=?us-ascii?Q?/sTtOdBowCvCORQsVg6lCHzEGV0N67lWz488202U1XDm3rPQ5dSag=3D=3D?=
X-Microsoft-Antispam-Message-Info: iCplRrML8VMm5c+pD+rlME2Okf/heH3u0/OfgwfnEtvwBT2yOOODh63tn94mCLDvC65RQ41kXzUv2fuWDzob2hyndGT9UHRsGitsQCrN/0tJI3fNkLslZvbsMh/lNS+z2fG44zY9SabFOxrfnFarPSRVQDz782TOTsliMsQ9qZpMCqeW2FM/a12Vmmot3u/v
X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0754;
6:CTU4ToYt/zuenvWjbs+E8N78J9VLNpP53EasKWm3dbE6Sn84evIfSGAU312QHxj8MqZFfWvpMIcIT0OS6pb//7PsSPzgfIMsn3kwZTQeEbWIgcsoDlf2WzlQfzsG1fuy4N+b71xeqqo/u+get8SpZbiUiJXyuRC5vzE/Pr/maN2DZnj0OKa9Jf4UqXs/ODE0Q14h5UmBl7FAV+/DB4Q+O5W+ZluZ0bUO+smUt+/q7oqm+4XzsPdLyswpj9aekLy/eSp+6GPT1MTrwRZ0h23HRXR40qntOjrwDJdXx3zMkW4dLubRJL8cMEge8s5u0jAcTOpHTztG3lpthAfq7yzkJdSeTlwAPmUQ7q4XdO8aDoo=;
5:OrPmroZTBqpKTWrIo9VwKNJFtsCWutiGbHG+3FU0hLkdspieyj54DeepMW19ptAFVfM1nchwH1uyJMgfAMUo1BGaNoICqLi35YG00ENiAUwbmCxEC5RYXOPNvJU/utLHlyZGrTAwRnMA7CGuz8EneTWWrg2Iow6M/BBsUzOSht4=;
24:sHd5bhcdywd0Kic6rOfHw5daLKB3HNbyecF0H7dTs6Ey5g603OVnrBpnEEvXgiRjJrreXVo2iGWqyuKEv6utCbaOvdSzbz8Opf8JWf012VU=;
7:WDnBmlqAnRg6sKcAGdy73TjxChLpH8wtYV8jZmTn8FqXPv603nYQpFvSFHdbk3QRjPidHi1YIYWnvl1qQHJ7Heba5G2q8Fo6aVd8YlZFCVkIwDofKqwgL2VFDSkK72zK6FuhJrx1bXaros+D0D/9dUfmi6pSa7SIapOFh8j6VoGZYIU3XS3iUT5Ep8iOjjiOp/t6mljE9B8vEbw771J+qAnUv3Quggqr1YW1BoBa6tNwkkXcm/CyujdXiVbuzDyg
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 07:58:00.9046 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f998048-c4be-477b-264c-08d589814f5b
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0754
Subject: [dpdk-dev] [PATCH v3 02/10] bus/dpaa: fix the BE compilation issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Mar 2018 07:58:03 -0000
The array pointers were used without index.
Fixes: b9083ea5e084 ("net/dpaa: further push mode optimizations")
Cc: stable@dpdk.org
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
drivers/bus/dpaa/base/qbman/qman.c | 5 +++--
drivers/bus/dpaa/base/qbman/qman_driver.c | 5 +----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c
index 2b97671..2810fdd 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -1087,7 +1087,7 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit,
shadow[rx_number]->fd.opaque =
be32_to_cpu(dq[rx_number]->fd.opaque);
#else
- shadow = dq;
+ shadow[rx_number] = dq[rx_number];
#endif
/* SDQCR: context_b points to the FQ */
@@ -1095,7 +1095,8 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit,
fq[rx_number] = qman_fq_lookup_table[be32_to_cpu(
dq[rx_number]->contextB)];
#else
- fq[rx_number] = (void *)(uintptr_t)be32_to_cpu(dq->contextB);
+ fq[rx_number] = (void *)be32_to_cpu(
+ dq[rx_number]->contextB);
#endif
fq[rx_number]->cb.dqrr_prepare(shadow[rx_number],
&bufs[rx_number]);
diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c
index 7cfa8ee..66838d2 100644
--- a/drivers/bus/dpaa/base/qbman/qman_driver.c
+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c
@@ -246,7 +246,6 @@ int fsl_qman_portal_destroy(struct qman_portal *qp)
int qman_global_init(void)
{
const struct device_node *dt_node;
- int ret = 0;
size_t lenp;
const u32 *chanid;
static int ccsr_map_fd;
@@ -352,9 +351,7 @@ int qman_global_init(void)
qman_clk = be32_to_cpu(*clk);
#ifdef CONFIG_FSL_QMAN_FQ_LOOKUP
- ret = qman_setup_fq_lookup_table(CONFIG_FSL_QMAN_FQ_LOOKUP_MAX);
- if (ret)
- return ret;
+ return qman_setup_fq_lookup_table(CONFIG_FSL_QMAN_FQ_LOOKUP_MAX);
#endif
return 0;
}
--
2.7.4