From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id E8631593A
 for <dev@dpdk.org>; Fri, 23 May 2014 10:05:34 +0200 (CEST)
Received: by mail-wi0-f178.google.com with SMTP id cc10so425553wib.5
 for <dev@dpdk.org>; Fri, 23 May 2014 01:05:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Y35OEUgQUWfZP1jgQ6ikEd+GFg/7ZsC5KaYh9WxngbQ=;
 b=iU1tIOvLgIrbwIEIsMXtvgKysqhXj7SgPdnqFU7gz9OMrl9ERPoL2W0l5vCS1kWOst
 pwui4YeTgHF3lYdeozRKxBmlSytvFfNcYtpaoHVYFgLkcOc7gNxawa98EGQRndbiAXX/
 hwRBrALMNLsOl/t65Z3f3ZcVGefR/usL5owFj95IfDpfMGUfhd2PZXf8NeDSwp6CfF+L
 ahsLLOohEn5uXS9h8hqgjQwLxM1/cAv9/A8FfzIFSx5jkHbEptoCE468Qk+WrntnpfG2
 eOl1nmxepPeR75iZi659Jbc+Pjor1IOgVmDvUg+qYtBgNykSHkqBKJ8mUy2u/m0PFK3f
 Kncg==
X-Gm-Message-State: ALoCoQmjR0GgDvGu9/21RT3D2ViXIRaSLcfzPJLg6U44FO4ZBHgqYLuK+2Y1r7LXbnSDi+M4qhj5
X-Received: by 10.180.83.131 with SMTP id q3mr1676826wiy.31.1400832344836;
 Fri, 23 May 2014 01:05:44 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id y10sm1554406wix.24.2014.05.23.01.05.42
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 23 May 2014 01:05:44 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Date: Fri, 23 May 2014 10:05:39 +0200
Message-ID: <1521897.lqfSqWB2or@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <1400777742-498-1-git-send-email-konstantin.ananyev@intel.com>
References: <1400777742-498-1-git-send-email-konstantin.ananyev@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] L3FWD sample optimisation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 May 2014 08:05:35 -0000

Hi Konstantin,

2014-05-22 17:55, Konstantin Ananyev:
> With latest HW and optimised RX/TX path there is a huge gap between
> tespmd iofwd and l3fwd performance results.
> So there is an attempt to optimise l3fwd LPM code path and reduce the gap:
>  - Instead of processing each input packet up to completion -
>  divide packet processing into several stages and perform
>  stage by stage for the whole burst.
>  - Unroll things by the factor of 4 whenever possible.
>  - Use SSE instincts for some operations (bswap, replace MAC addresses,
> etc). - Avoid TX packet buffering whenever possible.
>  - Move some checks from RX/TX into setup phase.

As you are doing optimizations, it's important to know the performance gain.
It could help to mitigate future reworks.
So please, could you provide some benchmarking numbers in the commit log?

Thanks
-- 
Thomas