From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0053.outbound.protection.outlook.com [104.47.32.53]) by dpdk.org (Postfix) with ESMTP id 827D0AAC8; Wed, 28 Mar 2018 02:16:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rSjUSy7J5WKhi9FpeB/RK02DplAh9WpfqOjJtMdkR+E=; b=e5AP3yo4o6bnGwJZp5cQuF8rH6K0YiiTAPsqXF56bKhy+u9cWbkm79pALlcB372eSjNo0JzP1vMdvKYtKhRh0S3qo0zS/eFIIx73Qw7IoanLETZl3dclDRypKaxFmoLEftoCRS4xMlH3I0NAGCpSL6ptz1TTLAHJpvX2zXk88w4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by CY4PR0701MB3665.namprd07.prod.outlook.com (2603:10b6:910:93::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.10; Wed, 28 Mar 2018 00:16:15 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Tue, 27 Mar 2018 17:15:54 -0700 Message-Id: <1522196155-30972-4-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1522196155-30972-1-git-send-email-rasesh.mody@cavium.com> References: <1522196155-30972-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: CO2PR05CA0102.namprd05.prod.outlook.com (2603:10b6:104:1::28) To CY4PR0701MB3665.namprd07.prod.outlook.com (2603:10b6:910:93::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7638af1-ee81-41d9-14ef-08d594411f42 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR0701MB3665; X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3665; 3:AuJ+n4vPHZD/3IlPWiMch8d5vzBLkeb7bTGGgJqqb2I2aR7JFeUbmpRMrXQ/zMUzYTvtkFIX2Aja5/eFGDAK9EXKSTrrd3PVSRoOd718N1aaRxgdDhEdcQWdvEQYAXc3xuw5HOvxzVXSjCp0iHup4FFvA2J2ABygGjJ9EO6a/pXnjNLXlll52+Phcw4w2Zx/kaJxd4vpIIARR2BUzOawpdftFbmMCeak9FB14gbR2XHOIUPwK8BXtQscnlD5dqlQ; 25:cFaMgKDcQoMWw7gmnhtMZAWilP8GEyep2JUnNFnIIMZ5I/7vn2c0wPTXgL4+sd/R0x+lCRDhpZ3KAE/tkcQzROfF6N/YdVUvwfgrfL9/6Mmwf9huNyBv3GfPXjwJvdum99cYdpGMZrvtIoyYWMhz5tNJ2A2b5/nOd95AFdWWInSCUeBsIJZKIaMuACj4G7jTY0sCBaCx+N00n0xP72gUOC0vVFXrhT5bKntCLuik1u6neznRRYhGXvffnatbBP2Mj3nXWlvYGEq4eRjCibR6n/iUOmIuNJYJMve3QYU/mRsgZ8gEG9gfzgpDE6Qg7oZhPOUSFqjySbu8HdLqy43K3Q==; 31:pO9nmx9U5hxQXC7Djkav1XP1/pyVex9tuGeeC7IqYOrPvg9JUCqWmjNRRwvD+YA5nwVV/W87L8bHNAjUobI2L1ny66zLEu5sCf3Xln3GWN++9lzzTgdKwZExnp9zvM91FfNK04ObWM12WzkVTcBjBFPjp0HtHLQHX1cbvtB1PGbOrqeTybUSsvEXxXnC2jVpEL97ns1rkBSUwgGX++RacnzkjCn3PA/vjhRwbJkNUDQ= X-MS-TrafficTypeDiagnostic: CY4PR0701MB3665: X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3665; 20:GG/xLM2+LhstuLp41JwDGfF4jgq5UIa4KbB8xWfpvwG02wF1GB26jpKnWY87px6Wexz911GgIxyQNIdM9BM7nNtJjGlpyC4OIF3fhyIBtvS1vAubjYK8nAlC2j17klUJEb0+QphfTao3upSipM+y8xHUHvvwgEBhLe/sZA74DHHiTtvQY4AFNY5gTGVOpb71vCNSkXadWkoRhsaTxo+n9hHO+jCfvi5qNU7aU4f3Eu+HBdpBreD641LvgzMi2AM1wRyoxdSBSQKxxP5aKm6CWm5Wnerc/Zk9bd21r0rS7nxNPYIIUx8ZJnK9ZayBsu+5+varQq6VCVF/GnomBTlkLLZiyEGh3s3RTMmvqTiRzq57kSNUW8I943V8ZHxDIXVXyKKguqKDLkZZeEzIRVPynsK2wK3PCVwwbxGaqZAcVGk8K25eobCfZIFfitwmvCXz/f7vqDVHQSzmQNNBLAIaI6t0I3iMnx+KWq2kCWeBsXYg7OexoNfxpS4bJg9gIKDC; 4:bWWDFbKlZm30zEGIdF06F9ct8/1PBS/ZliqwMoiCiNaKawBsjGT0cEDtojh4kuNQDxNr/nVIBL+N2pPdP2B8a4g0jc5lJHYLughPCjoF7RyfL8pW9ff4oOgua8dLZzcp1cN+Glxhezgxvj7qnjienknFqNUkeDtD4ThgZWXQ5bNIbLI3WTiNYLSVoTLiVapRzi+qqm6uVg4PBZdVD32NSWugfY7prtFe7YskjcVZcYU2hEeDtl10GJYABLUGN2Gy3i+o4FDiAAcuCGS9b1XH0Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(10201501046)(93006095)(93001095)(3002001)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:CY4PR0701MB3665; BCL:0; PCL:0; RULEID:; SRVR:CY4PR0701MB3665; X-Forefront-PRVS: 06259BA5A2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(376002)(39380400002)(39860400002)(189003)(199004)(2906002)(48376002)(106356001)(50466002)(6116002)(16526019)(26005)(186003)(3846002)(68736007)(2351001)(316002)(2361001)(105586002)(4720700003)(16586007)(50226002)(72206003)(478600001)(69596002)(36756003)(21086003)(6666003)(25786009)(55016002)(7736002)(6916009)(53936002)(486005)(8936002)(81166006)(81156014)(305945005)(8676002)(476003)(956004)(76176011)(386003)(2616005)(486005)(4326008)(52116002)(59450400001)(47776003)(66066001)(446003)(11346002)(5660300001)(86362001)(51416003)(97736004)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3665; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR0701MB3665; 23:Oxtlq2q/lWUC7x1/OPwmk6jw7qLbuVvIUbi0+wK?= =?us-ascii?Q?mBQ2uJFBvGC195mo4UjGb22UjGZT3QhNyyuuhKCHBvr3LvELYtdquBDh85iE?= =?us-ascii?Q?7rkOV8XvXiESxM+MAYt0BIYsE3XI2ZrO30XpdwvueBjjHOZcDKq5YN1+Ykib?= =?us-ascii?Q?e4Jt1fzexM+DR8QnfISc1LiUBxhqFOJ6tBYdpTSNHuU6B4TqOojlkdhdYm+o?= =?us-ascii?Q?I4S44L/bFinHPuGJ1sDT+pkD4V5WGl/2V6LayMHNISKJzI8kidsQxgK7+i9V?= =?us-ascii?Q?WOHv4j0Ge7bIHlKSLZcnG+qG4GgMgX5r9C2+/XoK3TeKZaSZ4kJJTRhhP808?= =?us-ascii?Q?86KcPxwTPptPF+xpszr23TUrlJNvH3RIQsa1xyTCAHdDsnBN6+4GDmTFX6Vr?= =?us-ascii?Q?toFqyxxE5P9Hv1d8PECJ8O+T9GKIhwW9cauCd2IxCGRahJrqjB/mBnFXBpef?= =?us-ascii?Q?rL+9zVEJiL0tEcnJYbpirrrsr3UW4pKu6j72Jjv0z1R9ZLp0q+pe+XqvuiLE?= =?us-ascii?Q?AxnyO2S+Br5lQMX6Ibq1m2iA0vNiVGB1l9aFAZZdaygIYHBkkLMdSVlgxRyD?= =?us-ascii?Q?CVt41Q1jW/+LmGNtPDp6rGOp9pNnO7gjAvFgj0yjwzF0GtinD9UZrZ0ycZHl?= =?us-ascii?Q?PyMyc+ZVBS+vKbLreHNBm/qrpQVB+z36gjmtTxuybac2SUWLIePeNkQQ7Qlc?= =?us-ascii?Q?qHYSI7tOEV8PdCLFQprNcvdTM9JZTXCapROui09MM46ByFF11NPsqM68+M5O?= =?us-ascii?Q?gRIQod61A8arRtcQzZvNeyAHMU/lugDrycZYNs+sdYjskytGn7fn+C+Pz3VU?= =?us-ascii?Q?0KA3SOWxp5/Z2KlPDb/nRzO8rYTpMQ6srl6hbRVY0X2cI4Q6KLEvxMQh1qps?= =?us-ascii?Q?FNnbYMwmtEgUPI5CTy9Kuc+t2fGlEw46wmKoHnA1TWgaIiyIQ2ttS5JrrC4b?= =?us-ascii?Q?JRWP3D3bUw7pYADfdoH/IQDMlTYfsN0avOSvUWe93A6XeH2jGAq1+H7ZQhCR?= =?us-ascii?Q?RGOD0513ad4jn5Zm5HFdv3Eznq+2ij9oy3NK0zlEQpdSOt0zZV2oQNPzdtj0?= =?us-ascii?Q?/fmO+zGyIdMEq/krSLyIkDNaBCGGZB+CdBabUR7HOwiHIkJdStKaFBxtyPpa?= =?us-ascii?Q?I0fIZlEGQom401Ldrn+oisVlTgBWEb1d3i8s6rC3Hh0Gia++gienojaNJdMs?= =?us-ascii?Q?wm+pdscH+xUa8Q+yCsKaTF1r37Ji3Ooo4YAb4DbHvESOrMLqPNApaFz6L7Mn?= =?us-ascii?Q?V66chBDD2zdU09DzQGxFzqb4NwJ2JsW68W0IloTphCEI2IYShfpFsz8nYNsG?= =?us-ascii?Q?ULOV3yWM3lKEl/c6Xj6NeFg9UpenJcoBPQSDnzOylM0Ys?= X-Microsoft-Antispam-Message-Info: 5NW3vjzf4jB3SusK8jUWnm40vBAmwzAx+tPxGk9v/po1S33BqMeXpBdbjDNaGfic1BhFqT7sIVmpOV45UvfBiPkHoiFAw+tJVxelfFH9ImMCQqOmREd1iOy7mFLb08JwzEXs9qZm/0QFlFTYaj96U28RmGS6CBZUfG0EakRgM3U15kG+J3zEmO7xxS3JlcUj X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3665; 6:1im2GL005fQHMlKQkWCOiZSTS1AFGsknetfsRknzeTjrVU84q2qXY377G3gYv0GispK2+9NwRdx886pLGW+xEah47ShdgVE+ylbMrdu3wxn71I1MHCbRexq79HqW+/J83ZNYIG4L4p23Lq8QWhIPX/vq5dGSLBeZdNZi/RVEya8VuovMDSwt9h7ux2uYZJ+zpg4JngBak7EBy+/L9rdt04fde9P6iKE184qLNfnUmPNAL+v/xBd7d/Ogve6z9ycCyvv3H2mAAa/FX6aSjViDN9k86xVy0wfnXSn32k4iN5fvVtYAkjHwev9QPq41zgEqsi8hqrASKaqCvlhVedzIG9pMZDUzups1UaTPUHa30uWLm7RtSJhaph+/Yc5PXygWqiMRq0Fs+as+x/fyXgoz69yugtSpRsmXvv9SV75D37j8wDtOgLkq4XwHp7O4t+43oLNdtyHdCj70UvR/CFZYtw==; 5:jiDP3GV18d54quTI7CUN5JnhvRz5cbGewTKrLdNXILaorP4jimGcN+XkqOl6uH/m8txHQuwl2V+Irp2C4wNH2Gu9sIGcR8uVIYQt7iQUAj1NDXRjPH5yVtRSWyDBttO0rQ6vN4WX7L/dIHPVxOAzOLsDOn0PPEtzc5HELo/1JnI=; 24:CvI1eQX5plNEAp+wfUhfcdNdqjB9XBCNA6HJ6mIavu9UqMd8kNfZt4YXm9dbQj2lVE/qqJH1K4mcuSmGwuOc2BGG8EVgV+WfUXQutuLmhb0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3665; 7:jcBDF+sxJrBG22CQazCM6mz/XZ1TtpZF2UTnU9M0Aqffh+efFsmSIOAXKU7rxWWdDWtwTMrmuWCAMkRoBmPP2wWzcJ0cLz7h1LRtNWqyx2f3COsSu5DH78o2jvQSMIu+IVOwIqx97K4baYZdEK+dWrIMcvVpo/R0x7PWfd2A+XJzmUss1yK3HhiQU1oMJiFQ+6CSJHOmCiIhajAXblWMdu078WmvDkrDRKFZXOo6GK75EBPO9907cCQtkDC6Kn8l X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2018 00:16:15.6579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7638af1-ee81-41d9-14ef-08d594411f42 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3665 Subject: [dpdk-dev] [PATCH 4/5] net/qede: fix device stop to remove primary MAC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 00:16:18 -0000 This fix is to remove primary MAC filter during dev stop. Without the fix device start attempt to add the primary MAC fails. Perform MAC set remove under IS_PF() check. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 025cd2a..a4e9e75 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1038,7 +1038,7 @@ static void qede_set_ucast_cmn_params(struct ecore_filter_ucast *ucast) ether_addr_copy(ð_dev->data->mac_addrs[index], (struct ether_addr *)&ucast.mac); - ecore_filter_ucast_cmd(edev, &ucast, ECORE_SPQ_MODE_CB, NULL); + qede_mac_int_ops(eth_dev, &ucast, false); } static void @@ -1375,6 +1375,9 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) /* Disable traffic */ ecore_hw_stop_fastpath(edev); /* TBD - loop */ + if (IS_PF(edev)) + qede_mac_addr_remove(eth_dev, 0); + DP_INFO(edev, "Device is stopped\n"); } @@ -2443,6 +2446,9 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_started = 0; qede_dev_stop(dev); restart = true; + } else { + if (IS_PF(edev)) + qede_mac_addr_remove(dev, 0); } rte_delay_ms(1000); qede_start_vport(qdev, mtu); /* Recreate vport */ @@ -2470,7 +2476,9 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_conf.rxmode.jumbo_frame = 0; /* Restore config lost due to vport stop */ - qede_mac_addr_set(dev, &qdev->primary_mac); + if (IS_PF(edev)) + qede_mac_addr_set(dev, &qdev->primary_mac); + if (dev->data->promiscuous) qede_promiscuous_enable(dev); else -- 1.7.10.3