* [dpdk-dev] [PATCH] vhost: fix meson build issues
@ 2018-04-05 8:08 Tomasz Duszynski
2018-04-05 10:29 ` Bruce Richardson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tomasz Duszynski @ 2018-04-05 8:08 UTC (permalink / raw)
To: dev; +Cc: maxime.coquelin, jianfeng.tan, Tomasz Duszynski, zhihong.wang
This patch addresses following meson build issues:
1) Since rte_vdpa.h includes rte_pci.h it introduces pci
dependency thus deps array should be updated accordingly.
2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to
the sources list. Otherwise we end up with linker errors
caused by undefined references.
Fixes: 34b30b2e7e42 ("vhost: add apis for datapath configuration")
Cc: zhihong.wang@intel.com
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
lib/librte_vhost/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build
index 9e8c0e7..8d14877 100644
--- a/lib/librte_vhost/meson.build
+++ b/lib/librte_vhost/meson.build
@@ -10,6 +10,6 @@ endif
version = 4
allow_experimental_apis = true
sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
- 'virtio_net.c')
+ 'virtio_net.c', 'vdpa.c')
headers = files('rte_vhost.h')
-deps += ['ethdev']
+deps += ['ethdev', 'pci']
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix meson build issues
2018-04-05 8:08 [dpdk-dev] [PATCH] vhost: fix meson build issues Tomasz Duszynski
@ 2018-04-05 10:29 ` Bruce Richardson
2018-04-05 20:01 ` Maxime Coquelin
2018-04-05 20:03 ` Maxime Coquelin
2 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2018-04-05 10:29 UTC (permalink / raw)
To: Tomasz Duszynski; +Cc: dev, maxime.coquelin, jianfeng.tan, zhihong.wang
On Thu, Apr 05, 2018 at 10:08:16AM +0200, Tomasz Duszynski wrote:
> This patch addresses following meson build issues:
>
> 1) Since rte_vdpa.h includes rte_pci.h it introduces pci
> dependency thus deps array should be updated accordingly.
>
> 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to
> the sources list. Otherwise we end up with linker errors
> caused by undefined references.
>
> Fixes: 34b30b2e7e42 ("vhost: add apis for datapath configuration")
> Cc: zhihong.wang@intel.com
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
Confirmed that meson build on dpdk-next-virtio tree is broken and that this
fixes it.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix meson build issues
2018-04-05 8:08 [dpdk-dev] [PATCH] vhost: fix meson build issues Tomasz Duszynski
2018-04-05 10:29 ` Bruce Richardson
@ 2018-04-05 20:01 ` Maxime Coquelin
2018-04-05 20:03 ` Maxime Coquelin
2 siblings, 0 replies; 5+ messages in thread
From: Maxime Coquelin @ 2018-04-05 20:01 UTC (permalink / raw)
To: Tomasz Duszynski, dev; +Cc: jianfeng.tan, zhihong.wang
On 04/05/2018 10:08 AM, Tomasz Duszynski wrote:
> This patch addresses following meson build issues:
>
> 1) Since rte_vdpa.h includes rte_pci.h it introduces pci
> dependency thus deps array should be updated accordingly.
>
> 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to
> the sources list. Otherwise we end up with linker errors
> caused by undefined references.
>
> Fixes: 34b30b2e7e42 ("vhost: add apis for datapath configuration")
> Cc: zhihong.wang@intel.com
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
> lib/librte_vhost/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix meson build issues
2018-04-05 8:08 [dpdk-dev] [PATCH] vhost: fix meson build issues Tomasz Duszynski
2018-04-05 10:29 ` Bruce Richardson
2018-04-05 20:01 ` Maxime Coquelin
@ 2018-04-05 20:03 ` Maxime Coquelin
2018-04-11 17:38 ` Ferruh Yigit
2 siblings, 1 reply; 5+ messages in thread
From: Maxime Coquelin @ 2018-04-05 20:03 UTC (permalink / raw)
To: Tomasz Duszynski, dev; +Cc: jianfeng.tan, zhihong.wang
On 04/05/2018 10:08 AM, Tomasz Duszynski wrote:
> This patch addresses following meson build issues:
>
> 1) Since rte_vdpa.h includes rte_pci.h it introduces pci
> dependency thus deps array should be updated accordingly.
>
> 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to
> the sources list. Otherwise we end up with linker errors
> caused by undefined references.
>
> Fixes: 34b30b2e7e42 ("vhost: add apis for datapath configuration")
> Cc: zhihong.wang@intel.com
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
> lib/librte_vhost/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] vhost: fix meson build issues
2018-04-05 20:03 ` Maxime Coquelin
@ 2018-04-11 17:38 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-04-11 17:38 UTC (permalink / raw)
To: Maxime Coquelin, Tomasz Duszynski, dev; +Cc: jianfeng.tan, zhihong.wang
On 4/5/2018 9:03 PM, Maxime Coquelin wrote:
>
>
> On 04/05/2018 10:08 AM, Tomasz Duszynski wrote:
>> This patch addresses following meson build issues:
>>
>> 1) Since rte_vdpa.h includes rte_pci.h it introduces pci
>> dependency thus deps array should be updated accordingly.
>>
>> 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to
>> the sources list. Otherwise we end up with linker errors
>> caused by undefined references.
>>
>> Fixes: 34b30b2e7e42 ("vhost: add apis for datapath configuration")
>> Cc: zhihong.wang@intel.com
>>
>> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>> ---
>> lib/librte_vhost/meson.build | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Applied to dpdk-next-virtio/master.
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-11 17:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-05 8:08 [dpdk-dev] [PATCH] vhost: fix meson build issues Tomasz Duszynski
2018-04-05 10:29 ` Bruce Richardson
2018-04-05 20:01 ` Maxime Coquelin
2018-04-05 20:03 ` Maxime Coquelin
2018-04-11 17:38 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).